Changeset 268834 in webkit

Timestamp:

Oct 21, 2020, 3:15:58 PM (6 years ago)

Author:

Alan Coon

Message:

Cherry-pick r268602. rdar://problem/70541712

[WebAuthn] Remove the "alg" field in the attestation statement
​https://bugs.webkit.org/show_bug.cgi?id=217720
<rdar://problem/70349734>

Reviewed by Brent Fulgham.

Source/WebKit:

This old field was used in an unreleased old attestation statement format and is not used by
the final attestation statement format that will be added to the spec:
​https://github.com/w3c/webauthn/pull/1491.

Therefore, remove it to resolve confusion.

Covered by existing tests.

• UIProcess/WebAuthentication/Cocoa/LocalAuthenticator.mm: (WebKit::LocalAuthenticator::continueMakeCredentialAfterAttested):

LayoutTests:

• http/wpt/webauthn/public-key-credential-create-success-local.https.html:

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@268602 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Location:

branches/safari-610-branch

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/http/wpt/webauthn/public-key-credential-create-success-local.https.html (modified) (1 diff)
• Source/WebKit/ChangeLog (modified) (1 diff)
• Source/WebKit/UIProcess/WebAuthentication/Cocoa/LocalAuthenticator.mm (modified) (1 diff)

branches/safari-610-branch/LayoutTests/ChangeLog

@@ +1 @@
+2020-10-21  Russell Epstein  <repstein@apple.com>
+
+        Cherry-pick r268602. rdar://problem/70541712
+
+    [WebAuthn] Remove the "alg" field in the attestation statement
+    https://bugs.webkit.org/show_bug.cgi?id=217720
+    <rdar://problem/70349734>
+    
+    Reviewed by Brent Fulgham.
+    
+    Source/WebKit:
+    
+    This old field was used in an unreleased old attestation statement format and is not used by
+    the final attestation statement format that will be added to the spec:
+    https://github.com/w3c/webauthn/pull/1491.
+    
+    Therefore, remove it to resolve confusion.
+    
+    Covered by existing tests.
+    
+    * UIProcess/WebAuthentication/Cocoa/LocalAuthenticator.mm:
+    (WebKit::LocalAuthenticator::continueMakeCredentialAfterAttested):
+    
+    LayoutTests:
+    
+    * http/wpt/webauthn/public-key-credential-create-success-local.https.html:
+    
+    
+    git-svn-id: https://svn.webkit.org/repository/webkit/trunk@268602 268f45cc-cd09-0410-ab3c-d52691b4dbfc
+
+    2020-10-16  Jiewen Tan  <jiewen_tan@apple.com>
+
+            [WebAuthn] Remove the "alg" field in the attestation statement
+            https://bugs.webkit.org/show_bug.cgi?id=217720
+            <rdar://problem/70349734>
+
+            Reviewed by Brent Fulgham.
+
+            * http/wpt/webauthn/public-key-credential-create-success-local.https.html:
+
 2020-10-08  Russell Epstein  <repstein@apple.com>
 

branches/safari-610-branch/LayoutTests/http/wpt/webauthn/public-key-credential-create-success-local.https.html

@@ -39 +39 @@
             assert_object_equals(attestationObject.attStmt, { });
         else {
-            assert_equals(attestationObject.attStmt.alg, -7);
             assert_equals(attestationObject.attStmt.x5c.length, 2);
             assert_array_equals(attestationObject.attStmt.x5c[0], Base64URL.parse(testAttestationCertificateBase64));

branches/safari-610-branch/Source/WebKit/ChangeLog

@@ +1 @@
+2020-10-21  Russell Epstein  <repstein@apple.com>
+
+        Cherry-pick r268602. rdar://problem/70541712
+
+    [WebAuthn] Remove the "alg" field in the attestation statement
+    https://bugs.webkit.org/show_bug.cgi?id=217720
+    <rdar://problem/70349734>
+    
+    Reviewed by Brent Fulgham.
+    
+    Source/WebKit:
+    
+    This old field was used in an unreleased old attestation statement format and is not used by
+    the final attestation statement format that will be added to the spec:
+    https://github.com/w3c/webauthn/pull/1491.
+    
+    Therefore, remove it to resolve confusion.
+    
+    Covered by existing tests.
+    
+    * UIProcess/WebAuthentication/Cocoa/LocalAuthenticator.mm:
+    (WebKit::LocalAuthenticator::continueMakeCredentialAfterAttested):
+    
+    LayoutTests:
+    
+    * http/wpt/webauthn/public-key-credential-create-success-local.https.html:
+    
+    
+    git-svn-id: https://svn.webkit.org/repository/webkit/trunk@268602 268f45cc-cd09-0410-ab3c-d52691b4dbfc
+
+    2020-10-16  Jiewen Tan  <jiewen_tan@apple.com>
+
+            [WebAuthn] Remove the "alg" field in the attestation statement
+            https://bugs.webkit.org/show_bug.cgi?id=217720
+            <rdar://problem/70349734>
+
+            Reviewed by Brent Fulgham.
+
+            This old field was used in an unreleased old attestation statement format and is not used by
+            the final attestation statement format that will be added to the spec:
+            https://github.com/w3c/webauthn/pull/1491.
+
+            Therefore, remove it to resolve confusion.
+
+            Covered by existing tests.
+
+            * UIProcess/WebAuthentication/Cocoa/LocalAuthenticator.mm:
+            (WebKit::LocalAuthenticator::continueMakeCredentialAfterAttested):
+
 2020-10-21  Russell Epstein  <repstein@apple.com>
 

branches/safari-610-branch/Source/WebKit/UIProcess/WebAuthentication/Cocoa/LocalAuthenticator.mm

@@ -403 +403 @@
     cbor::CBORValue::MapValue attestationStatementMap;
     {
-        attestationStatementMap[cbor::CBORValue("alg")] = cbor::CBORValue(COSE::ES256);
         Vector<cbor::CBORValue> cborArray;
         for (size_t i = 0; i < [certificates count]; i++)