Changeset 268859 in webkit

Timestamp:

Oct 22, 2020, 3:00:32 AM (6 years ago)

Author:

commit-queue@webkit.org

Message:

[GStreamer] Restrict ImageDecoder to WebProcess
​https://bugs.webkit.org/show_bug.cgi?id=218023

Patch by Philippe Normand <​pnormand@igalia.com> on 2020-10-22
Reviewed by Carlos Garcia Campos.

Ideally this decoder should operate only from the WebProcess (or from the GPUProcess) which
should be the only process where GStreamer has been runtime initialized. This is a step
towards a GStreamer-free GTK/WPE UIProcess.

• platform/graphics/gstreamer/ImageDecoderGStreamer.cpp:

(WebCore::ImageDecoderGStreamer::supportsContainerType):
(WebCore::ImageDecoderGStreamer::canDecodeType):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• platform/graphics/gstreamer/ImageDecoderGStreamer.cpp (modified) (2 diffs)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2020-10-22  Philippe Normand  <pnormand@igalia.com>
+
+        [GStreamer] Restrict ImageDecoder to WebProcess
+        https://bugs.webkit.org/show_bug.cgi?id=218023
+
+        Reviewed by Carlos Garcia Campos.
+
+        Ideally this decoder should operate only from the WebProcess (or from the GPUProcess) which
+        should be the only process where GStreamer has been runtime initialized. This is a step
+        towards a GStreamer-free GTK/WPE UIProcess.
+
+        * platform/graphics/gstreamer/ImageDecoderGStreamer.cpp:
+        (WebCore::ImageDecoderGStreamer::supportsContainerType):
+        (WebCore::ImageDecoderGStreamer::canDecodeType):
+
 2020-10-22  Martin Robinson  <mrobinson@igalia.com>
 

trunk/Source/WebCore/platform/graphics/gstreamer/ImageDecoderGStreamer.cpp

@@ -99 +99 @@
 bool ImageDecoderGStreamer::supportsContainerType(const String& type)
 {
+    // Ideally this decoder should operate only from the WebProcess (or from the GPUProcess) which
+    // should be the only process where GStreamer has been runtime initialized.
+    if (!gst_is_initialized())
+        return false;
+
     return GStreamerRegistryScanner::singleton().isContainerTypeSupported(GStreamerRegistryScanner::Configuration::Decoding, type);
 }
@@ -104 +109 @@
 bool ImageDecoderGStreamer::canDecodeType(const String& mimeType)
 {
+    // Ideally this decoder should operate only from the WebProcess (or from the GPUProcess) which
+    // should be the only process where GStreamer has been runtime initialized.
+    if (!gst_is_initialized())
+        return false;
+
     if (mimeType.isEmpty())
         return false;