Changeset 268862 in webkit

Timestamp:

Oct 22, 2020, 6:22:32 AM (6 years ago)

Author:

Antti Koivisto

Message:

[LFC][Integration] Lines with outline should be marked having visual overflow
​https://bugs.webkit.org/show_bug.cgi?id=218071

Reviewed by Zalan Bujtas.

Source/WebCore:

Seen in fast/repaint/focus-ring-repaint.html

We may fail to paint newly added outlines correctly. This is a legacy line layout bug exposed by IFC integration.

• rendering/InlineFlowBox.cpp:

(WebCore::InlineFlowBox::addToLine):

Mark when adding content to line.

LayoutTests:

• fast/repaint/focus-ring-repaint-expected.txt:

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/fast/repaint/focus-ring-repaint-expected.txt (modified) (1 diff)
• Source/WebCore/ChangeLog (modified) (1 diff)
• Source/WebCore/rendering/InlineFlowBox.cpp (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2020-10-22  Antti Koivisto  <antti@apple.com>
+
+        [LFC][Integration] Lines with outline should be marked having visual overflow
+        https://bugs.webkit.org/show_bug.cgi?id=218071
+
+        Reviewed by Zalan Bujtas.
+
+        * fast/repaint/focus-ring-repaint-expected.txt:
+
 2020-10-22  Diego Pino Garcia  <dpino@igalia.com>
 

trunk/LayoutTests/fast/repaint/focus-ring-repaint-expected.txt

@@ -7 +7 @@
 
 (repaint rects
-  (rect 5 457 103 67)
+  (rect 5 457 106 70)
   (rect 5 457 106 70)
   (rect 5 542 106 70)
   (rect 15 62 36 40)
   (rect 18 65 30 34)
-  (rect 5 89 56 10)
-  (rect 5 35 56 64)
+  (rect 5 92 56 10)
+  (rect 5 35 56 67)
   (rect 5 117 36 60)
   (rect 8 120 30 54)
   (rect 5 117 36 86)
   (rect 8 120 30 80)
-  (rect 5 174 56 30)
-  (rect 5 120 56 84)
+  (rect 5 177 56 30)
+  (rect 5 120 56 87)
   (rect 5 205 56 37)
   (rect 5 375 56 37)
-  (rect 5 457 103 67)
+  (rect 5 457 106 70)
   (rect 8 460 100 64)
   (rect 8 545 100 64)
-  (rect 5 542 103 67)
+  (rect 5 542 106 70)
+  (rect 5 609 772 3)
+  (rect 0 609 785 3)
   (rect 45 212 36 40)
   (rect 48 215 30 34)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2020-10-22  Antti Koivisto  <antti@apple.com>
+
+        [LFC][Integration] Lines with outline should be marked having visual overflow
+        https://bugs.webkit.org/show_bug.cgi?id=218071
+
+        Reviewed by Zalan Bujtas.
+
+        Seen in fast/repaint/focus-ring-repaint.html
+
+        We may fail to paint newly added outlines correctly. This is a legacy line layout bug exposed by IFC integration.
+
+        * rendering/InlineFlowBox.cpp:
+        (WebCore::InlineFlowBox::addToLine):
+
+        Mark when adding content to line.
+
 2020-10-22  Cathie Chen  <cathiechen@igalia.com>
 

trunk/Source/WebCore/rendering/InlineFlowBox.cpp

@@ -176 +176 @@
         else if (childStyle.hasOutlineInVisualOverflow())
             child->clearKnownToHaveNoOverflow();
+
+        if (lineStyle().hasOutlineInVisualOverflow())
+            clearKnownToHaveNoOverflow();
         
         if (knownToHaveNoOverflow() && is<InlineFlowBox>(*child) && !downcast<InlineFlowBox>(*child).knownToHaveNoOverflow())