Changeset 268870 in webkit

Timestamp:

Oct 22, 2020, 10:31:05 AM (6 years ago)

Author:

commit-queue@webkit.org

Message:

Detect unrecognized options in build-jsc
​https://bugs.webkit.org/show_bug.cgi?id=218077

Patch by Angelos Oikonomopoulos <Angelos Oikonomopoulos> on 2020-10-22
Reviewed by Yusuke Suzuki.

Currently, Getopt::Long is configured with pass_through, in order to
be able to forward arbitrary arguments in buildMyProject. However, that
means that typos in option names (e.g. using --cmake-args instead of
--cmakeargs) go undetected and the option is silently ignored.

For cmake builds, there is no such forwarding, so check that there are
no remaining arguments in ARGV and refuse to continue if so. This runs
the risk of breaking wrapper scripts that incorrectly pass unrecognized
options, but that seems like a good thing.

• Scripts/build-jsc:

Location:

trunk/Tools

Files:

• ChangeLog (modified) (1 diff)
• Scripts/build-jsc (modified) (1 diff)

trunk/Tools/ChangeLog

@@ +1 @@
+2020-10-22  Angelos Oikonomopoulos  <angelos@igalia.com>
+
+        Detect unrecognized options in build-jsc
+        https://bugs.webkit.org/show_bug.cgi?id=218077
+
+        Reviewed by Yusuke Suzuki.
+
+        Currently, Getopt::Long is configured with pass_through, in order to
+        be able to forward arbitrary arguments in buildMyProject. However, that
+        means that typos in option names (e.g. using --cmake-args instead of
+        --cmakeargs) go undetected and the option is silently ignored.
+ 
+        For cmake builds, there is no such forwarding, so check that there are
+        no remaining arguments in ARGV and refuse to continue if so. This runs
+        the risk of breaking wrapper scripts that incorrectly pass unrecognized
+        options, but that seems like a good thing.
+
+        * Scripts/build-jsc:
+
 2020-10-22  Peng Liu  <peng.liu6@apple.com>
 

trunk/Tools/Scripts/build-jsc

@@ -156 +156 @@
 
 if (isCMakeBuild()) {
+    if (scalar(@ARGV) > 0) {
+        foreach (@ARGV) {
+            my $arg = $_;
+            if ($arg =~ /^-.*/) {
+                print STDERR "Unrecognized option `$arg'\n";
+            } else {
+                print STDERR "Stray anonymous argument `$arg'\n";
+            }
+        }
+        exit 2;
+    }
     if ($forceCLoop) {
         push @cmakeArgs, " -DENABLE_JIT=OFF";