Changeset 268871 in webkit

Timestamp:

Oct 22, 2020, 10:45:53 AM (6 years ago)

Author:

rmorisset@apple.com

Message:

Use operand names when dumping Bytecode
​https://bugs.webkit.org/show_bug.cgi?id=218084

Reviewed by Saam Barati.

For example this would output the following:

[ 258] put_to_scope scope:loc7, var:3, value:loc8, getPutInfo:1048576<DoNotThrowIfNotFound|GlobalProperty|Initialization|NotStrictMode>, symbolTableOrScopeDepth:0, offset:0

instead of

[ 258] put_to_scope loc7, 3, loc8, 1048576<DoNotThrowIfNotFound|GlobalProperty|Initialization|NotStrictMode>, 0, 0

• bytecode/BytecodeDumper.h:

(JSC::BytecodeDumperBase::dumpOperand):

• generator/Opcode.rb:

Location:

trunk/Source/JavaScriptCore

Files:

• ChangeLog (modified) (1 diff)
• bytecode/BytecodeDumper.h (modified) (1 diff)
• generator/Opcode.rb (modified) (1 diff)

trunk/Source/JavaScriptCore/ChangeLog

@@ +1 @@
+2020-10-22  Robin Morisset  <rmorisset@apple.com>
+
+        Use operand names when dumping Bytecode
+        https://bugs.webkit.org/show_bug.cgi?id=218084
+
+        Reviewed by Saam Barati.
+
+        For example this would output the following:
+          [ 258] put_to_scope       scope:loc7, var:3, value:loc8, getPutInfo:1048576<DoNotThrowIfNotFound|GlobalProperty|Initialization|NotStrictMode>, symbolTableOrScopeDepth:0, offset:0
+        instead of
+          [ 258] put_to_scope       loc7, 3, loc8, 1048576<DoNotThrowIfNotFound|GlobalProperty|Initialization|NotStrictMode>, 0, 0
+
+        * bytecode/BytecodeDumper.h:
+        (JSC::BytecodeDumperBase::dumpOperand):
+        * generator/Opcode.rb:
+
 2020-10-21  Caitlin Potter  <caitp@igalia.com>
 

trunk/Source/JavaScriptCore/bytecode/BytecodeDumper.h

@@ -48 +48 @@
 
     template<typename T>
-    void dumpOperand(T operand, bool isFirst = false)
+    void dumpOperand(const char* operandName, T operand, bool isFirst = false)
     {
         if (!isFirst)
             m_out.print(", ");
+        m_out.print(operandName);
+        m_out.print(":");
         dumpValue(operand);
     }

trunk/Source/JavaScriptCore/generator/Opcode.rb

@@ -270 +270 @@
 #{print_args { |arg|
 <<-EOF.chomp
-        dumper->dumpOperand(#{arg.field_name}, #{arg.index == 0});
+        dumper->dumpOperand("#{arg.name}", #{arg.field_name}, #{arg.index == 0});
 EOF
     }}