Changeset 268918 in webkit

Timestamp:

Oct 23, 2020, 2:44:14 AM (6 years ago)

Author:

commit-queue@webkit.org

Message:

[JSC] Fix argument order for double and/or ops on ARMv7
​https://bugs.webkit.org/show_bug.cgi?id=218118

Patch by Angelos Oikonomopoulos <Angelos Oikonomopoulos> on 2020-10-23
Reviewed by Adrian Perez de Castro.

The andDouble and orDouble macro assembler methods for ARMv7
incorrectly pass the destination register as the last argument,
whereas the assembler expects the destination to be the first
argument.

This fixes a failing testmasm test.

• assembler/MacroAssemblerARMv7.h:

(JSC::MacroAssemblerARMv7::andDouble):
(JSC::MacroAssemblerARMv7::orDouble):

Location:

trunk/Source/JavaScriptCore

Files:

• ChangeLog (modified) (1 diff)
• assembler/MacroAssemblerARMv7.h (modified) (1 diff)

trunk/Source/JavaScriptCore/ChangeLog

@@ +1 @@
+2020-10-23  Angelos Oikonomopoulos  <angelos@igalia.com>
+
+        [JSC] Fix argument order for double and/or ops on ARMv7
+        https://bugs.webkit.org/show_bug.cgi?id=218118
+
+        Reviewed by Adrian Perez de Castro.
+
+        The andDouble and orDouble macro assembler methods for ARMv7
+        incorrectly pass the destination register as the last argument,
+        whereas the assembler expects the destination to be the first
+        argument.
+
+        This fixes a failing testmasm test.
+
+        * assembler/MacroAssemblerARMv7.h:
+        (JSC::MacroAssemblerARMv7::andDouble):
+        (JSC::MacroAssemblerARMv7::orDouble):
+
 2020-10-22  Robin Morisset  <rmorisset@apple.com>
 

trunk/Source/JavaScriptCore/assembler/MacroAssemblerARMv7.h

@@ -1188 +1188 @@
     void andDouble(FPRegisterID op1, FPRegisterID op2, FPRegisterID dest)
     {
-        m_assembler.vand(op1, op2, dest);
+        m_assembler.vand(dest, op1, op2);
     }
 
     void orDouble(FPRegisterID op1, FPRegisterID op2, FPRegisterID dest)
     {
-        m_assembler.vorr(op1, op2, dest);
+        m_assembler.vorr(dest, op1, op2);
     }