Changeset 268982 in webkit

Timestamp:

Oct 26, 2020, 10:27:47 AM (6 years ago)

Author:

commit-queue@webkit.org

Message:

Web Inspector: Uncaught Exception: TypeError: undefined is not an object (evaluating 'this._boxModelDiagramRow.minimumWidth')
​https://bugs.webkit.org/show_bug.cgi?id=218135

Patch by Patrick Angle <Patrick Angle> on 2020-10-26
Reviewed by Brian Burg.

minimumWidth may be retrieved before the ComputedStylesDetailsPanel has done its initial layout, which means the
_boxModelDiagramRow will not have been initialized. In this case, we want to return 0 causing the absolute
minimum width of a sidebar to be used for calculations instead.

• UserInterface/Views/ComputedStyleDetailsPanel.js:

(WI.ComputedStyleDetailsPanel.prototype.get minimumWidth):

Location:

trunk/Source/WebInspectorUI

Files:

• ChangeLog (modified) (1 diff)
• UserInterface/Views/ComputedStyleDetailsPanel.js (modified) (1 diff)

trunk/Source/WebInspectorUI/ChangeLog

@@ +1 @@
+2020-10-26  Patrick Angle  <pangle@apple.com>
+
+        Web Inspector: Uncaught Exception: TypeError: undefined is not an object (evaluating 'this._boxModelDiagramRow.minimumWidth')
+        https://bugs.webkit.org/show_bug.cgi?id=218135
+
+        Reviewed by Brian Burg.
+
+        minimumWidth may be retrieved before the ComputedStylesDetailsPanel has done its initial layout, which means the
+        _boxModelDiagramRow will not have been initialized. In this case, we want to return 0 causing the absolute
+        minimum width of a sidebar to be used for calculations instead.
+
+        * UserInterface/Views/ComputedStyleDetailsPanel.js:
+        (WI.ComputedStyleDetailsPanel.prototype.get minimumWidth):
+
 2020-10-26  Patrick Angle  <pangle@apple.com>
 

trunk/Source/WebInspectorUI/UserInterface/Views/ComputedStyleDetailsPanel.js

@@ -40 +40 @@
     get minimumWidth()
     {
-        return this._boxModelDiagramRow.minimumWidth;
+        return this._boxModelDiagramRow?.minimumWidth ?? 0;
     }