Changeset 269038 in webkit

Timestamp:

Oct 27, 2020, 6:56:30 AM (6 years ago)

Author:

Antti Koivisto

Message:

Assert in BoxTree::layoutBoxForRenderer() under RenderLayer::updateScrollCornerStyle()
​https://bugs.webkit.org/show_bug.cgi?id=218205
<rdar://problem/70694256>

Reviewed by Zalan Bujtas.

• layout/integration/LayoutIntegrationLineLayout.cpp:

(WebCore::LayoutIntegration::LineLayout::containing):

Similar to RenderReplica, RenderScrollbarPart is a fake renderer that is not in the tree even
though it has the parent pointer set.

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• layout/integration/LayoutIntegrationLineLayout.cpp (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2020-10-27  Antti Koivisto  <antti@apple.com>
+
+        Assert in BoxTree::layoutBoxForRenderer() under RenderLayer::updateScrollCornerStyle()
+        https://bugs.webkit.org/show_bug.cgi?id=218205
+        <rdar://problem/70694256>
+
+        Reviewed by Zalan Bujtas.
+
+        * layout/integration/LayoutIntegrationLineLayout.cpp:
+        (WebCore::LayoutIntegration::LineLayout::containing):
+
+        Similar to RenderReplica, RenderScrollbarPart is a fake renderer that is not in the tree even
+        though it has the parent pointer set.
+
 2020-10-27  Zalan Bujtas  <zalan@apple.com>
 

trunk/Source/WebCore/layout/integration/LayoutIntegrationLineLayout.cpp

@@ -72 +72 @@
         return nullptr;
 
-    if (renderer.isReplica())
+    // FIXME: These fake renderers have their parent set but are not actually in the tree.
+    if (renderer.isReplica() || renderer.isRenderScrollbarPart())
         return nullptr;