Changeset 269042 in webkit

Timestamp:

Oct 27, 2020, 8:57:51 AM (6 years ago)

Author:

clopez@igalia.com

Message:

[GTK] Move step for generating the JSC bundle back to the release build bot
​https://bugs.webkit.org/show_bug.cgi?id=218207

Reviewed by Adrian Perez de Castro.

On r266208 I moved the step to generate the JSC bundle from the default
GTK release build bot to the new bots for Ubuntu-20.04 packaging.

But it seems the ICU version of Ubuntu-20.04 (66) is not new enough for
testing some Intl features like Intl.ListFormat as JS Intl feature behaviors
are derived from ICU versions.

Move back this step to the GTK release build bot that runs with flatpak,
so it bundles the version of ICU from the FreeDesktop SDK (67 currently)

• BuildSlaveSupport/build.webkit.org-config/config.json:
• BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:

Location:

trunk/Tools

Files:

• BuildSlaveSupport/build.webkit.org-config/config.json (modified) (2 diffs)
• BuildSlaveSupport/build.webkit.org-config/steps_unittest.py (modified) (2 diffs)
• ChangeLog (modified) (1 diff)

trunk/Tools/BuildSlaveSupport/build.webkit.org-config/config.json

@@ -292 +292 @@
                     },
                     {
-                      "name": "GTK-Linux-64-bit-Release-Build", "factory": "BuildFactory", "builddir": "gtk-linux-64-release",
+                      "name": "GTK-Linux-64-bit-Release-Build", "factory": "BuildAndGenerateJSCBundleFactory", "builddir": "gtk-linux-64-release",
                       "platform": "gtk", "configuration": "release", "architectures": ["x86_64"],
                       "triggers": ["gtk-linux-64-release-tests", "gtk-linux-64-release-tests-js", "gtk-linux-64-release-tests-webdriver",
@@ -365 +365 @@
                     },
                     {
-                      "name": "GTK-Linux-64bit-Release-Packaging-Nightly-Ubuntu2004", "factory": "BuildAndGenerateMiniBrowserJSCBundleFactory", "builddir": "gtk-linux-64-packaging-nigthly-ubuntu2004",
+                      "name": "GTK-Linux-64bit-Release-Packaging-Nightly-Ubuntu2004", "factory": "BuildAndGenerateMiniBrowserBundleFactory", "builddir": "gtk-linux-64-packaging-nigthly-ubuntu2004",
                       "platform": "gtk", "configuration": "release", "architectures": ["x86_64"],
                       "additionalArguments": ["--no-bubblewrap-sandbox"],

trunk/Tools/BuildSlaveSupport/build.webkit.org-config/steps_unittest.py

@@ -571 +571 @@
     'GTK-Linux-64-bit-Debug-WebDriver-Tests': ['configure-build', 'svn', 'kill-old-processes', 'delete-WebKitBuild-directory', 'delete-stale-build-files', 'jhbuild', 'download-built-product', 'extract-built-product', 'webdriver-test'],
     'GTK-Linux-64-bit-Debug-JS-Tests': ['configure-build', 'svn', 'kill-old-processes', 'delete-WebKitBuild-directory', 'delete-stale-build-files', 'jhbuild', 'download-built-product', 'extract-built-product', 'jscore-test', 'test262-test'],
-    'GTK-Linux-64-bit-Release-Build': ['configure-build', 'svn', 'kill-old-processes', 'delete-WebKitBuild-directory', 'delete-stale-build-files', 'jhbuild', 'compile-webkit', 'archive-built-product', 'upload', 'transfer-to-s3', 'trigger'],
+    'GTK-Linux-64-bit-Release-Build': ['configure-build', 'svn', 'kill-old-processes', 'delete-WebKitBuild-directory', 'delete-stale-build-files', 'jhbuild', 'compile-webkit', 'generate-jsc-bundle', 'archive-built-product', 'upload', 'transfer-to-s3', 'trigger'],
     'GTK-Linux-64-bit-Release-Perf': ['configure-build', 'svn', 'kill-old-processes', 'delete-WebKitBuild-directory', 'delete-stale-build-files', 'jhbuild', 'download-built-product', 'extract-built-product', 'perf-test', 'benchmark-test'],
     'GTK-Linux-64-bit-Release-Tests': ['configure-build', 'svn', 'kill-old-processes', 'delete-WebKitBuild-directory', 'delete-stale-build-files', 'jhbuild', 'download-built-product', 'extract-built-product', 'layout-test', 'webkitpy-test', 'webkitperl-test', 'bindings-generation-tests', 'builtins-generator-tests', 'dashboard-tests', 'archive-test-results', 'upload', 'MasterShellCommand', 'API-tests'],
@@ -597 +597 @@
     'WPE-Linux-64-bit-Debug-JS-Tests': ['configure-build', 'svn', 'kill-old-processes', 'delete-WebKitBuild-directory', 'delete-stale-build-files', 'jhbuild', 'download-built-product', 'extract-built-product', 'jscore-test', 'test262-test'],
     'GTK-Linux-64bit-Release-Packaging-Nightly-Ubuntu1804': ['configure-build', 'svn', 'kill-old-processes', 'delete-WebKitBuild-directory', 'delete-stale-build-files', 'jhbuild', 'compile-webkit', 'generate-minibrowser-bundle'],
-    'GTK-Linux-64bit-Release-Packaging-Nightly-Ubuntu2004': ['configure-build', 'svn', 'kill-old-processes', 'delete-WebKitBuild-directory', 'delete-stale-build-files', 'jhbuild', 'compile-webkit', 'generate-jsc-bundle', 'generate-minibrowser-bundle'],
+    'GTK-Linux-64bit-Release-Packaging-Nightly-Ubuntu2004': ['configure-build', 'svn', 'kill-old-processes', 'delete-WebKitBuild-directory', 'delete-stale-build-files', 'jhbuild', 'compile-webkit', 'generate-minibrowser-bundle'],
     'WPE-Linux-64bit-Release-Packaging-Nightly-Ubuntu1804': ['configure-build', 'svn', 'kill-old-processes', 'delete-WebKitBuild-directory', 'delete-stale-build-files', 'jhbuild', 'compile-webkit', 'generate-minibrowser-bundle'],
     'WPE-Linux-64bit-Release-Packaging-Nightly-Ubuntu2004': ['configure-build', 'svn', 'kill-old-processes', 'delete-WebKitBuild-directory', 'delete-stale-build-files', 'jhbuild', 'compile-webkit', 'generate-minibrowser-bundle'],

trunk/Tools/ChangeLog

@@ +1 @@
+2020-10-27  Carlos Alberto Lopez Perez  <clopez@igalia.com>
+
+        [GTK] Move step for generating the JSC bundle back to the release build bot
+        https://bugs.webkit.org/show_bug.cgi?id=218207
+
+        Reviewed by Adrian Perez de Castro.
+
+        On r266208 I moved the step to generate the JSC bundle from the default
+        GTK release build bot to the new bots for Ubuntu-20.04 packaging.
+
+        But it seems the ICU version of Ubuntu-20.04 (66) is not new enough for
+        testing some Intl features like Intl.ListFormat as JS Intl feature behaviors
+        are derived from ICU versions.
+
+        Move back this step to the GTK release build bot that runs with flatpak,
+        so it bundles the version of ICU from the FreeDesktop SDK (67 currently)
+
+        * BuildSlaveSupport/build.webkit.org-config/config.json:
+        * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:
+
 2020-10-26  Federico Bucchi  <fbucchi@apple.com>