Changeset 269048 in webkit

Timestamp:

Oct 27, 2020, 10:25:58 AM (6 years ago)

Author:

weinig@apple.com

Message:

Rename WKPreferencesSet*ValueForKey SPI to WKPreferencesSet*ValueForKeyForTesting
​https://bugs.webkit.org/show_bug.cgi?id=218240

Reviewed by Darin Adler.

Source/WebKit:

Addresses feedback from initial naming to make it clear what they are used
for and for consistency with WebKitLegacy.

• UIProcess/API/C/WKPreferences.cpp:

(WKPreferencesSetBoolValueForKeyForTesting):
(WKPreferencesSetDoubleValueForKeyForTesting):
(WKPreferencesSetUInt32ValueForKeyForTesting):
(WKPreferencesSetStringValueForKeyForTesting):
(WKPreferencesSetBoolValueForKey): Deleted.
(WKPreferencesSetDoubleValueForKey): Deleted.
(WKPreferencesSetUInt32ValueForKey): Deleted.
(WKPreferencesSetStringValueForKey): Deleted.

• UIProcess/API/C/WKPreferencesRefPrivate.h:

Tools:

• WebKitTestRunner/TestController.cpp:

(WTR::TestController::resetPreferencesToConsistentValues):
Update for renamed function names.

Location:

trunk

Files:

• Source/WebKit/ChangeLog (modified) (1 diff)
• Source/WebKit/UIProcess/API/C/WKPreferences.cpp (modified) (1 diff)
• Source/WebKit/UIProcess/API/C/WKPreferencesRefPrivate.h (modified) (1 diff)
• Tools/ChangeLog (modified) (1 diff)
• Tools/WebKitTestRunner/TestController.cpp (modified) (1 diff)

trunk/Source/WebKit/ChangeLog

@@ +1 @@
+2020-10-27  Sam Weinig  <weinig@apple.com>
+
+        Rename WKPreferencesSet*ValueForKey SPI to WKPreferencesSet*ValueForKeyForTesting
+        https://bugs.webkit.org/show_bug.cgi?id=218240
+
+        Reviewed by Darin Adler.
+
+        Addresses feedback from initial naming to make it clear what they are used
+        for and for consistency with WebKitLegacy.
+
+        * UIProcess/API/C/WKPreferences.cpp:
+        (WKPreferencesSetBoolValueForKeyForTesting):
+        (WKPreferencesSetDoubleValueForKeyForTesting):
+        (WKPreferencesSetUInt32ValueForKeyForTesting):
+        (WKPreferencesSetStringValueForKeyForTesting):
+        (WKPreferencesSetBoolValueForKey): Deleted.
+        (WKPreferencesSetDoubleValueForKey): Deleted.
+        (WKPreferencesSetUInt32ValueForKey): Deleted.
+        (WKPreferencesSetStringValueForKey): Deleted.
+        * UIProcess/API/C/WKPreferencesRefPrivate.h:
+
 2020-10-27  Carlos Garcia Campos  <cgarcia@igalia.com>
 

trunk/Source/WebKit/UIProcess/API/C/WKPreferences.cpp

@@ -79 +79 @@
 }
 
-void WKPreferencesSetBoolValueForKey(WKPreferencesRef preferencesRef, bool value, WKStringRef key)
+void WKPreferencesSetBoolValueForKeyForTesting(WKPreferencesRef preferencesRef, bool value, WKStringRef key)
 {
     toImpl(preferencesRef)->setBoolValueForKey(toWTFString(key), value);
 }
 
-void WKPreferencesSetDoubleValueForKey(WKPreferencesRef preferencesRef, double value, WKStringRef key)
+void WKPreferencesSetDoubleValueForKeyForTesting(WKPreferencesRef preferencesRef, double value, WKStringRef key)
 {
     toImpl(preferencesRef)->setBoolValueForKey(toWTFString(key), value);
 }
 
-void WKPreferencesSetUInt32ValueForKey(WKPreferencesRef preferencesRef, uint32_t value, WKStringRef key)
+void WKPreferencesSetUInt32ValueForKeyForTesting(WKPreferencesRef preferencesRef, uint32_t value, WKStringRef key)
 {
     toImpl(preferencesRef)->setUInt32ValueForKey(toWTFString(key), value);
 }
 
-void WKPreferencesSetStringValueForKey(WKPreferencesRef preferencesRef, WKStringRef value, WKStringRef key)
+void WKPreferencesSetStringValueForKeyForTesting(WKPreferencesRef preferencesRef, WKStringRef value, WKStringRef key)
 {
     toImpl(preferencesRef)->setStringValueForKey(toWTFString(key), toWTFString(value));

trunk/Source/WebKit/UIProcess/API/C/WKPreferencesRefPrivate.h

@@ -57 +57 @@
 
 // The following generic setter functions are only intended for use by testing infrastructure.
-WK_EXPORT void WKPreferencesSetBoolValueForKey(WKPreferencesRef preferencesRef, bool value, WKStringRef key);
-WK_EXPORT void WKPreferencesSetDoubleValueForKey(WKPreferencesRef preferencesRef, double value, WKStringRef key);
-WK_EXPORT void WKPreferencesSetUInt32ValueForKey(WKPreferencesRef preferencesRef, uint32_t value, WKStringRef key);
-WK_EXPORT void WKPreferencesSetStringValueForKey(WKPreferencesRef preferencesRef, WKStringRef value, WKStringRef key);
+WK_EXPORT void WKPreferencesSetBoolValueForKeyForTesting(WKPreferencesRef preferencesRef, bool value, WKStringRef key);
+WK_EXPORT void WKPreferencesSetDoubleValueForKeyForTesting(WKPreferencesRef preferencesRef, double value, WKStringRef key);
+WK_EXPORT void WKPreferencesSetUInt32ValueForKeyForTesting(WKPreferencesRef preferencesRef, uint32_t value, WKStringRef key);
+WK_EXPORT void WKPreferencesSetStringValueForKeyForTesting(WKPreferencesRef preferencesRef, WKStringRef value, WKStringRef key);
 
 // For Test Runner Use only.

trunk/Tools/ChangeLog

@@ +1 @@
+2020-10-27  Sam Weinig  <weinig@apple.com>
+
+        Rename WKPreferencesSet*ValueForKey SPI to WKPreferencesSet*ValueForKeyForTesting
+        https://bugs.webkit.org/show_bug.cgi?id=218240
+
+        Reviewed by Darin Adler.
+
+        * WebKitTestRunner/TestController.cpp:
+        (WTR::TestController::resetPreferencesToConsistentValues):
+        Update for renamed function names.
+
 2020-10-27  Carlos Alberto Lopez Perez  <clopez@igalia.com>
 

trunk/Tools/WebKitTestRunner/TestController.cpp

@@ -922 +922 @@
 
     for (const auto& [key, value] : options.boolWebPreferenceFeatures())
-        WKPreferencesSetBoolValueForKey(preferences, value, toWK(key).get());
+        WKPreferencesSetBoolValueForKeyForTesting(preferences, value, toWK(key).get());
 
     for (const auto& [key, value] : options.doubleWebPreferenceFeatures())
-        WKPreferencesSetDoubleValueForKey(preferences, value, toWK(key).get());
+        WKPreferencesSetDoubleValueForKeyForTesting(preferences, value, toWK(key).get());
 
     for (const auto& [key, value] : options.uint32WebPreferenceFeatures())
-        WKPreferencesSetUInt32ValueForKey(preferences, value, toWK(key).get());
+        WKPreferencesSetUInt32ValueForKeyForTesting(preferences, value, toWK(key).get());
 
     for (const auto& [key, value] : options.stringWebPreferenceFeatures())
-        WKPreferencesSetStringValueForKey(preferences, toWK(value).get(), toWK(key).get());
-
+        WKPreferencesSetStringValueForKeyForTesting(preferences, toWK(value).get(), toWK(key).get());
 }