Changeset 269049 in webkit

Timestamp:

Oct 27, 2020, 10:30:14 AM (6 years ago)

Author:

commit-queue@webkit.org

Message:

Use NSURLSessionAuthChallengeRejectProtectionSpace if WKNavigationDelegate didReceiveAuthenticationChallenge is not implemented
​https://bugs.webkit.org/show_bug.cgi?id=218008

Patch by Alex Christensen <​achristensen@webkit.org> on 2020-10-27
Reviewed by Darin Adler.

This is documented in WKNavigationDelegate.h, and the behavior is basically identical.
The difference is if there is a challenge with multiple protection spaces and a delegate that implements didReceiveAuthenticationChallenge
is attached between the delegate callbacks, it will receive the second callback. This is unlikely and next to impossible to test, but
out of principle we should behave like we have documented that we do.

• UIProcess/Cocoa/NavigationState.mm:

(WebKit::NavigationState::NavigationClient::didReceiveAuthenticationChallenge):

Location:

trunk/Source/WebKit

Files:

• ChangeLog (modified) (1 diff)
• UIProcess/Cocoa/NavigationState.mm (modified) (1 diff)

trunk/Source/WebKit/ChangeLog

@@ +1 @@
+2020-10-27  Alex Christensen  <achristensen@webkit.org>
+
+        Use NSURLSessionAuthChallengeRejectProtectionSpace if WKNavigationDelegate didReceiveAuthenticationChallenge is not implemented
+        https://bugs.webkit.org/show_bug.cgi?id=218008
+
+        Reviewed by Darin Adler.
+
+        This is documented in WKNavigationDelegate.h, and the behavior is basically identical.
+        The difference is if there is a challenge with multiple protection spaces and a delegate that implements didReceiveAuthenticationChallenge
+        is attached between the delegate callbacks, it will receive the second callback.  This is unlikely and next to impossible to test, but
+        out of principle we should behave like we have documented that we do.
+
+        * UIProcess/Cocoa/NavigationState.mm:
+        (WebKit::NavigationState::NavigationClient::didReceiveAuthenticationChallenge):
+
 2020-10-27  Sam Weinig  <weinig@apple.com>
 

trunk/Source/WebKit/UIProcess/Cocoa/NavigationState.mm

@@ -1002 +1002 @@
 {
     if (!m_navigationState.m_navigationDelegateMethods.webViewDidReceiveAuthenticationChallengeCompletionHandler)
-        return authenticationChallenge.listener().completeChallenge(WebKit::AuthenticationChallengeDisposition::PerformDefaultHandling);
-
-    auto navigationDelegate = m_navigationState.m_navigationDelegate.get();
-    if (!navigationDelegate)
-        return authenticationChallenge.listener().completeChallenge(WebKit::AuthenticationChallengeDisposition::PerformDefaultHandling);
+        return authenticationChallenge.listener().completeChallenge(WebKit::AuthenticationChallengeDisposition::RejectProtectionSpaceAndContinue);
+
+    auto navigationDelegate = m_navigationState.m_navigationDelegate.get();
+    if (!navigationDelegate)
+        return authenticationChallenge.listener().completeChallenge(WebKit::AuthenticationChallengeDisposition::RejectProtectionSpaceAndContinue);
 
     auto checker = CompletionHandlerCallChecker::create(navigationDelegate.get(), @selector(webView:didReceiveAuthenticationChallenge:completionHandler:));