Changeset 269138 in webkit

Timestamp:

Oct 28, 2020, 11:13:47 PM (6 years ago)

Author:

Russell Epstein

Message:

Cherry-pick r268791. rdar://problem/70795323

[iOS] Disable audio capture in the background for non Safari applications
​https://bugs.webkit.org/show_bug.cgi?id=217948
<rdar://problem/70241557>

Reviewed by Eric Carlson.

Source/WebCore:

We do not have good OS support when capturing audio in a WebProcess for a backgrounded application.
Until we have proper support, it seems best to mute audio capture when being backgrounded.
Manually tested.

• platform/mediastream/mac/RealtimeMediaSourceCenterMac.mm: (WebCore::RealtimeMediaSourceCenter::shouldInterruptAudioOnPageVisibilityChange):

LayoutTests:

• platform/ios/mediastream/video-muted-in-background-tab.html: By default, audio capture will be muted in WTR if page goes to background. Update the test to explicitly request for audio capture to continue while in background.

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@268791 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Location:

branches/safari-610-branch

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/platform/ios/mediastream/video-muted-in-background-tab.html (modified) (1 diff)
• Source/WebCore/ChangeLog (modified) (1 diff)
• Source/WebCore/platform/mediastream/mac/RealtimeMediaSourceCenterMac.mm (modified) (2 diffs)

branches/safari-610-branch/LayoutTests/ChangeLog

@@ +1 @@
+2020-10-28  Russell Epstein  <repstein@apple.com>
+
+        Cherry-pick r268791. rdar://problem/70795323
+
+    [iOS] Disable audio capture in the background for non Safari applications
+    https://bugs.webkit.org/show_bug.cgi?id=217948
+    <rdar://problem/70241557>
+    
+    Reviewed by Eric Carlson.
+    
+    Source/WebCore:
+    
+    We do not have good OS support when capturing audio in a WebProcess for a backgrounded application.
+    Until we have proper support, it seems best to mute audio capture when being backgrounded.
+    Manually tested.
+    
+    * platform/mediastream/mac/RealtimeMediaSourceCenterMac.mm:
+    (WebCore::RealtimeMediaSourceCenter::shouldInterruptAudioOnPageVisibilityChange):
+    
+    LayoutTests:
+    
+    * platform/ios/mediastream/video-muted-in-background-tab.html:
+    By default, audio capture will be muted in WTR if page goes to background.
+    Update the test to explicitly request for audio capture to continue while in background.
+    
+    
+    git-svn-id: https://svn.webkit.org/repository/webkit/trunk@268791 268f45cc-cd09-0410-ab3c-d52691b4dbfc
+
+    2020-10-21  Youenn Fablet  <youenn@apple.com>
+
+            [iOS] Disable audio capture in the background for non Safari applications
+            https://bugs.webkit.org/show_bug.cgi?id=217948
+            <rdar://problem/70241557>
+
+            Reviewed by Eric Carlson.
+
+            * platform/ios/mediastream/video-muted-in-background-tab.html:
+            By default, audio capture will be muted in WTR if page goes to background.
+            Update the test to explicitly request for audio capture to continue while in background.
+
 2020-10-26  Karl Rackler  <rackler@apple.com>
 

branches/safari-610-branch/LayoutTests/platform/ios/mediastream/video-muted-in-background-tab.html

@@ -43 +43 @@
 
             promise_test(async (t) => {
-                if (window.internals)
+                if (window.internals) {
+                    window.internals.setShouldInterruptAudioOnPageVisibilityChange(false);
                     window.internals.setPageVisibility(false);
+                }
                 assert_false(audioTrack.muted, "audio track is active");
                 assert_true(videoTrack.muted, "video track is muted");

branches/safari-610-branch/Source/WebCore/ChangeLog

@@ +1 @@
+2020-10-28  Russell Epstein  <repstein@apple.com>
+
+        Cherry-pick r268791. rdar://problem/70795323
+
+    [iOS] Disable audio capture in the background for non Safari applications
+    https://bugs.webkit.org/show_bug.cgi?id=217948
+    <rdar://problem/70241557>
+    
+    Reviewed by Eric Carlson.
+    
+    Source/WebCore:
+    
+    We do not have good OS support when capturing audio in a WebProcess for a backgrounded application.
+    Until we have proper support, it seems best to mute audio capture when being backgrounded.
+    Manually tested.
+    
+    * platform/mediastream/mac/RealtimeMediaSourceCenterMac.mm:
+    (WebCore::RealtimeMediaSourceCenter::shouldInterruptAudioOnPageVisibilityChange):
+    
+    LayoutTests:
+    
+    * platform/ios/mediastream/video-muted-in-background-tab.html:
+    By default, audio capture will be muted in WTR if page goes to background.
+    Update the test to explicitly request for audio capture to continue while in background.
+    
+    
+    git-svn-id: https://svn.webkit.org/repository/webkit/trunk@268791 268f45cc-cd09-0410-ab3c-d52691b4dbfc
+
+    2020-10-21  Youenn Fablet  <youenn@apple.com>
+
+            [iOS] Disable audio capture in the background for non Safari applications
+            https://bugs.webkit.org/show_bug.cgi?id=217948
+            <rdar://problem/70241557>
+
+            Reviewed by Eric Carlson.
+
+            We do not have good OS support when capturing audio in a WebProcess for a backgrounded application.
+            Until we have proper support, it seems best to mute audio capture when being backgrounded.
+            Manually tested.
+
+            * platform/mediastream/mac/RealtimeMediaSourceCenterMac.mm:
+            (WebCore::RealtimeMediaSourceCenter::shouldInterruptAudioOnPageVisibilityChange):
+
 2020-10-21  Russell Epstein  <repstein@apple.com>
 

branches/safari-610-branch/Source/WebCore/platform/mediastream/mac/RealtimeMediaSourceCenterMac.mm

@@ -29 +29 @@
 #if ENABLE(MEDIA_STREAM)
 
+#include "RuntimeApplicationChecks.h"
+
 namespace WebCore {
 
@@ -34 +36 @@
 {
 #if PLATFORM(IOS)
+    if (!WebCore::IOSApplication::isMobileSafari() && !WebCore::IOSApplication::isSafariViewService())
+        return true;
+
     NSArray *modes = [[NSBundle mainBundle] objectForInfoDictionaryKey:@"UIBackgroundModes"];
     if (!modes)