Changeset 269147 in webkit

Timestamp:

Oct 29, 2020, 7:29:52 AM (6 years ago)

Author:

youenn@apple.com

Message:

Disable VP9 VTB hardware decoding
​https://bugs.webkit.org/show_bug.cgi?id=218326

Reviewed by Alex Christensen.

VP9 hardware decoder does not work properly yet as used in WebRTC pipeline.
Disable hardware support for now and use software based VP9 through VTB.

• Source/webrtc/sdk/objc/components/video_codec/RTCVideoDecoderVTBVP9.mm:

(-[RTCVideoDecoderVTBVP9 resetDecompressionSession]):

Location:

trunk/Source/ThirdParty/libwebrtc

Files:

• ChangeLog (modified) (1 diff)
• Source/webrtc/sdk/objc/components/video_codec/RTCVideoDecoderVTBVP9.mm (modified) (1 diff)

trunk/Source/ThirdParty/libwebrtc/ChangeLog

@@ +1 @@
+2020-10-29  Youenn Fablet  <youenn@apple.com>
+
+        Disable VP9 VTB hardware decoding
+        https://bugs.webkit.org/show_bug.cgi?id=218326
+
+        Reviewed by Alex Christensen.
+
+        VP9 hardware decoder does not work properly yet as used in WebRTC pipeline.
+        Disable hardware support for now and use software based VP9 through VTB.
+
+        * Source/webrtc/sdk/objc/components/video_codec/RTCVideoDecoderVTBVP9.mm:
+        (-[RTCVideoDecoderVTBVP9 resetDecompressionSession]):
+
 2020-10-26  Youenn Fablet  <youenn@apple.com>
 

trunk/Source/ThirdParty/libwebrtc/Source/webrtc/sdk/objc/components/video_codec/RTCVideoDecoderVTBVP9.mm

@@ -261 +261 @@
     pixelFormat = nullptr;
   }
+
+  // rdar://problem/70701816. Disable hardware decoding until working properly.
+  auto videoDecoderSpecification = @{
+#if !defined(WEBRTC_IOS)
+    (__bridge NSString *)kVTVideoDecoderSpecification_EnableHardwareAcceleratedVideoDecoder: @NO
+#endif
+  };
+
   VTDecompressionOutputCallbackRecord record = {
       vp9DecompressionOutputCallback, (__bridge void *)self,
   };
   OSStatus status = VTDecompressionSessionCreate(
-      nullptr, _videoFormat, nullptr, attributes, &record, &_decompressionSession);
+      nullptr, _videoFormat, (__bridge CFDictionaryRef)videoDecoderSpecification, attributes, &record, &_decompressionSession);
   CFRelease(attributes);
   if (status != noErr) {