Changeset 269156 in webkit

Timestamp:

Oct 29, 2020, 11:10:27 AM (6 years ago)

Author:

youenn@apple.com

Message:

Add some logging to SequenceCheckerImpl::IsCurrent
​https://bugs.webkit.org/show_bug.cgi?id=218328

Reviewed by Eric Carlson.

• Source/webrtc/rtc_base/synchronization/sequence_checker.cc:

This might help debugging ​https://bugs.webkit.org/show_bug.cgi?id=218063.

Location:

trunk/Source/ThirdParty/libwebrtc

Files:

• ChangeLog (modified) (1 diff)
• Source/webrtc/rtc_base/synchronization/sequence_checker.cc (modified) (2 diffs)

trunk/Source/ThirdParty/libwebrtc/ChangeLog

@@ +1 @@
+2020-10-29  Youenn Fablet  <youenn@apple.com>
+
+        Add some logging to SequenceCheckerImpl::IsCurrent
+        https://bugs.webkit.org/show_bug.cgi?id=218328
+
+        Reviewed by Eric Carlson.
+
+        * Source/webrtc/rtc_base/synchronization/sequence_checker.cc:
+        This might help debugging https://bugs.webkit.org/show_bug.cgi?id=218063.
+
 2020-10-29  Youenn Fablet  <youenn@apple.com>
 

trunk/Source/ThirdParty/libwebrtc/Source/webrtc/rtc_base/synchronization/sequence_checker.cc

@@ -9 +9 @@
  */
 #include "rtc_base/synchronization/sequence_checker.h"
+
+#include "rtc_base/logging.h"
 
 #if defined(WEBRTC_MAC)
@@ -48 +50 @@
   }
   if (valid_queue_ || current_queue) {
+    if (valid_queue_ != current_queue)
+      RTC_LOG(LS_ERROR) << "SequenceCheckerImpl queue check is failing";
     return valid_queue_ == current_queue;
   }
   if (valid_system_queue_ && valid_system_queue_ == current_system_queue) {
+    if (valid_queue_ != current_queue)
+      RTC_LOG(LS_ERROR) << "SequenceCheckerImpl system queue check is failing";
     return true;
   }
-  return rtc::IsThreadRefEqual(valid_thread_, current_thread);
+  auto result = rtc::IsThreadRefEqual(valid_thread_, current_thread);
+  if (!result)
+    RTC_LOG(LS_ERROR) << "SequenceCheckerImpl thread check is failing";
+  return result;
 }