⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Changeset 269208 in webkit


Ignore:
Timestamp:
Oct 30, 2020, 3:59:11 PM (6 years ago)
Author:
Chris Fleizach
Message:

AX: Incorrect list of voices being displayed on iOS
​https://bugs.webkit.org/show_bug.cgi?id=218293

Reviewed by Per Arne Vollan.

Source/WebCore:

Limit the voices that we display in WebSpeech to only built-in system voices. This was the intention of the "compact"
decision, but some mobile assets have compact voices, which are not available WebContent.

  • platform/ios/PlatformSpeechSynthesizerIOS.mm:

(WebCore::PlatformSpeechSynthesizer::initializeVoiceList):

Source/WebCore/PAL:

  • PAL.xcodeproj/project.pbxproj:
  • pal/PlatformMac.cmake:
  • pal/spi/cocoa/AXSpeechManagerSPI.h: Added.

Source/WTF:

  • wtf/PlatformHave.h:
Location:
trunk/Source
Files:
1 added
7 edited

Legend:

Unmodified
Added
Removed

  • trunk/Source/WTF/ChangeLog

    r269168 r269208  
     12020-10-30  Chris Fleizach  <cfleizach@apple.com>
     2
     3        AX: Incorrect list of voices being displayed on iOS
     4        https://bugs.webkit.org/show_bug.cgi?id=218293
     5
     6        Reviewed by Per Arne Vollan.
     7
     8        * wtf/PlatformHave.h:
     9
    1102020-10-29  Jiewen Tan  <jiewen_tan@apple.com>
    211

  • trunk/Source/WTF/wtf/PlatformHave.h

    r269082 r269208  
    736736#endif
    737737#endif
     738
     739#if (PLATFORM(IOS) || PLATFORM(MACCATALYST)) && __IPHONE_OS_VERSION_MIN_REQUIRED >= 140300
     740#if !defined(HAVE_AVSPEECHSYNTHESIS_SYSTEMVOICE)
     741#define HAVE_AVSPEECHSYNTHESIS_SYSTEMVOICE 1
     742#endif
     743#endif

  • trunk/Source/WebCore/ChangeLog

    r269206 r269208  
     12020-10-30  Chris Fleizach  <cfleizach@apple.com>
     2
     3        AX: Incorrect list of voices being displayed on iOS
     4        https://bugs.webkit.org/show_bug.cgi?id=218293
     5
     6        Reviewed by Per Arne Vollan.
     7
     8        Limit the voices that we display in WebSpeech to only built-in system voices. This was the intention of the "compact"
     9        decision, but some mobile assets have compact voices, which are not available WebContent.
     10
     11        * platform/ios/PlatformSpeechSynthesizerIOS.mm:
     12        (WebCore::PlatformSpeechSynthesizer::initializeVoiceList):
     13
    1142020-10-30  Keith Rollin  <krollin@apple.com>
    215

  • trunk/Source/WebCore/PAL/ChangeLog

    r268420 r269208  
     12020-10-30  Chris Fleizach  <cfleizach@apple.com>
     2
     3        AX: Incorrect list of voices being displayed on iOS
     4        https://bugs.webkit.org/show_bug.cgi?id=218293
     5
     6        Reviewed by Per Arne Vollan.
     7
     8        * PAL.xcodeproj/project.pbxproj:
     9        * pal/PlatformMac.cmake:
     10        * pal/spi/cocoa/AXSpeechManagerSPI.h: Added.
     11
    1122020-10-13  Keith Rollin  <krollin@apple.com>
    213

  • trunk/Source/WebCore/PAL/PAL.xcodeproj/project.pbxproj

    r267870 r269208  
    116116                293EE4A824154F8F0047493D /* AccessibilitySupportSoftLink.cpp in Sources */ = {isa = PBXBuildFile; fileRef = 293EE4A624154F8F0047493D /* AccessibilitySupportSoftLink.cpp */; };
    117117                293EE4A924154F8F0047493D /* AccessibilitySupportSoftLink.h in Headers */ = {isa = PBXBuildFile; fileRef = 293EE4A724154F8F0047493D /* AccessibilitySupportSoftLink.h */; };
     118                29CDEBA62548D57F007C07B7 /* AXSpeechManagerSPI.h in Headers */ = {isa = PBXBuildFile; fileRef = 29CDEB9E2548D055007C07B7 /* AXSpeechManagerSPI.h */; };
    118119                2D02E93C2056FAA700A13797 /* AudioToolboxSPI.h in Headers */ = {isa = PBXBuildFile; fileRef = 2D02E93B2056FAA700A13797 /* AudioToolboxSPI.h */; };
    119120                2E1342CC215AA10A007199D2 /* UIKitSoftLink.h in Headers */ = {isa = PBXBuildFile; fileRef = 2E1342CA215AA10A007199D2 /* UIKitSoftLink.h */; };
    … …  
    305306                293EE4A624154F8F0047493D /* AccessibilitySupportSoftLink.cpp */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.cpp.cpp; path = AccessibilitySupportSoftLink.cpp; sourceTree = "<group>"; };
    306307                293EE4A724154F8F0047493D /* AccessibilitySupportSoftLink.h */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.c.h; path = AccessibilitySupportSoftLink.h; sourceTree = "<group>"; };
     308                29CDEB9E2548D055007C07B7 /* AXSpeechManagerSPI.h */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.c.h; path = AXSpeechManagerSPI.h; sourceTree = "<group>"; };
    307309                2D02E93B2056FAA700A13797 /* AudioToolboxSPI.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = AudioToolboxSPI.h; sourceTree = "<group>"; };
    308310                2E1342CA215AA10A007199D2 /* UIKitSoftLink.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = UIKitSoftLink.h; sourceTree = "<group>"; };
    … …  
    455457                                0C7785701F45130F00F4EBB6 /* AVFoundationSPI.h */,
    456458                                0C2DA1221F3BEB4900DBC317 /* AVKitSPI.h */,
     459                                29CDEB9E2548D055007C07B7 /* AXSpeechManagerSPI.h */,
    457460                                0C2DA1231F3BEB4900DBC317 /* CFNSURLConnectionSPI.h */,
    458461                                7A36D0F8223AD9AB00B0522E /* CommonCryptoSPI.h */,
    … …  
    899902                                07611DB6243FA5BF00D80704 /* UsageTrackingSoftLink.h in Headers */,
    900903                                0C2DA1591F3BEB4900DBC317 /* WebFilterEvaluatorSPI.h in Headers */,
     904                                29CDEBA62548D57F007C07B7 /* AXSpeechManagerSPI.h in Headers */,
    901905                                A10826F91F576292004772AC /* WebPanel.h in Headers */,
    902906                        );

  • trunk/Source/WebCore/PAL/pal/PlatformMac.cmake

    r267602 r269208  
    2424    spi/cocoa/AVFoundationSPI.h
    2525    spi/cocoa/AVKitSPI.h
     26    spi/cocoa/AXSpeechManagerSPI.h
    2627    spi/cocoa/AccessibilitySupportSPI.h
    2728    spi/cocoa/AccessibilitySupportSoftLink.h

  • trunk/Source/WebCore/platform/ios/PlatformSpeechSynthesizerIOS.mm

    r251960 r269208  
    3131#import "PlatformSpeechSynthesisVoice.h"
    3232#import <AVFoundation/AVSpeechSynthesis.h>
     33#import <pal/spi/cocoa/AXSpeechManagerSPI.h>
    3334#import <wtf/BlockObjCExceptions.h>
    3435#import <wtf/RetainPtr.h>
    … …  
    266267       
    267268        // Only show built-in voices when requesting through WebKit to reduce fingerprinting surface area.
     269#if HAVE(AVSPEECHSYNTHESIS_SYSTEMVOICE)
     270        if (voice.isSystemVoice)
     271#else
    268272        if (voice.quality == AVSpeechSynthesisVoiceQualityDefault)
     273#endif
    269274            m_voiceList.append(PlatformSpeechSynthesisVoice::create(voiceURI, name, language, true, isDefault));
    270275    }
Note: See TracChangeset for help on using the changeset viewer.