Changeset 269752 in webkit

Timestamp:

Nov 12, 2020, 2:18:46 PM (6 years ago)

Author:

ajuma@chromium.org

Message:

configure-xcode-for-embedded-development breaks @available in Swift files
​https://bugs.webkit.org/show_bug.cgi?id=218850

Reviewed by Jonathan Bedard.

The changes applied by configure-xcode-for-embedded-development
for AvailabilityProhibitedInternal.h cause API_AVAILABLE to be ignored
in Objective-C, but @available is not ignored in Swift. As a result,
if an Objective-C method marked with API_AVAILABLE makes a call
into a Swift class marked with @available, this can lead to an
availability warning even when the calling method is only available
when the callee is available.

To fix this, ensure that @available is also ignored in Swift.

• Scripts/configure-xcode-for-embedded-development:

Location:

trunk/Tools

Files:

• ChangeLog (modified) (1 diff)
• Scripts/configure-xcode-for-embedded-development (modified) (1 diff)

trunk/Tools/ChangeLog

@@ +1 @@
+2020-11-12  Ali Juma  <ajuma@chromium.org>
+
+        configure-xcode-for-embedded-development breaks @available in Swift files
+        https://bugs.webkit.org/show_bug.cgi?id=218850
+
+        Reviewed by Jonathan Bedard.
+
+        The changes applied by configure-xcode-for-embedded-development
+        for AvailabilityProhibitedInternal.h cause API_AVAILABLE to be ignored
+        in Objective-C, but @available is not ignored in Swift. As a result,
+        if an Objective-C method marked with API_AVAILABLE makes a call
+        into a Swift class marked with @available, this can lead to an
+        availability warning even when the calling method is only available
+        when the callee is available.
+
+        To fix this, ensure that @available is also ignored in Swift.
+
+        * Scripts/configure-xcode-for-embedded-development:
+
 2020-11-12  Chris Dumez  <cdumez@apple.com>
 

trunk/Tools/Scripts/configure-xcode-for-embedded-development

@@ -98 +98 @@
 #define __API_AVAILABLE_GET_MACRO(...) __NULL_AVAILABILITY
 
+#undef SWIFT_AVAILABILITY
+#define SWIFT_AVAILABILITY __NULL_AVAILABILITY
+
 // Take care of {A,S}PI_DEPRECATED{,WITH_REPLACEMENT}{,_BEGIN,_END}
 #undef __API_DEPRECATED_MSG_GET_MACRO