Changeset 269758 in webkit

Timestamp:

Nov 12, 2020, 3:45:06 PM (6 years ago)

Author:

timothy_horton@apple.com

Message:

canvas-createPattern-video-modify-crash-log.txt asserts on debug GPUProcess bots
​https://bugs.webkit.org/show_bug.cgi?id=218872

Reviewed by Simon Fraser.

• WebProcess/GPU/graphics/ImageBufferShareableBitmapBackend.cpp:

(WebKit::ImageBufferShareableBitmapBackend::create):
This assertion is wrong; make it the same as the one in ImageBufferCGBitmapBackend.

Location:

trunk/Source/WebKit

Files:

• ChangeLog (modified) (1 diff)
• WebProcess/GPU/graphics/ImageBufferShareableBitmapBackend.cpp (modified) (1 diff)

trunk/Source/WebKit/ChangeLog

@@ +1 @@
+2020-11-12  Tim Horton  <timothy_horton@apple.com>
+
+        canvas-createPattern-video-modify-crash-log.txt asserts on debug GPUProcess bots
+        https://bugs.webkit.org/show_bug.cgi?id=218872
+
+        Reviewed by Simon Fraser.
+
+        * WebProcess/GPU/graphics/ImageBufferShareableBitmapBackend.cpp:
+        (WebKit::ImageBufferShareableBitmapBackend::create):
+        This assertion is wrong; make it the same as the one in ImageBufferCGBitmapBackend.
+
 2020-11-12  Said Abou-Hallawa  <said@apple.com>
 

trunk/Source/WebKit/WebProcess/GPU/graphics/ImageBufferShareableBitmapBackend.cpp

@@ -46 +46 @@
 std::unique_ptr<ImageBufferShareableBitmapBackend> ImageBufferShareableBitmapBackend::create(const FloatSize& size, float resolutionScale, ColorSpace colorSpace, PixelFormat pixelFormat, const HostWindow*)
 {
-    ASSERT(pixelFormat == PixelFormat::RGBA8);
+    ASSERT(pixelFormat == PixelFormat::BGRA8);
 
     IntSize backendSize = calculateBackendSize(size, resolutionScale);