Changeset 269782 in webkit

Timestamp:

Nov 13, 2020, 9:22:37 AM (6 years ago)

Author:

youenn@apple.com

Message:

Remote encoder should set its encoder frame callback to nullptr when being released
​https://bugs.webkit.org/show_bug.cgi?id=218906

Reviewed by Eric Carlson.

• Source/webrtc/sdk/WebKit/WebKitEncoder.mm:

(webrtc::RemoteVideoEncoder::Release):
We need to reset the callback at Release call time so that WebKit will take a lock to set it back to null.
That way, we ensure to not call this callback while libwebrtc expects not to be called.

Location:

trunk/Source/ThirdParty/libwebrtc

Files:

• ChangeLog (modified) (1 diff)
• Source/webrtc/sdk/WebKit/WebKitEncoder.mm (modified) (1 diff)

trunk/Source/ThirdParty/libwebrtc/ChangeLog

@@ +1 @@
+2020-11-13  Youenn Fablet  <youenn@apple.com>
+
+        Remote encoder should set its encoder frame callback to nullptr when being released
+        https://bugs.webkit.org/show_bug.cgi?id=218906
+
+        Reviewed by Eric Carlson.
+
+        * Source/webrtc/sdk/WebKit/WebKitEncoder.mm:
+        (webrtc::RemoteVideoEncoder::Release):
+        We need to reset the callback at Release call time so that WebKit will take a lock to set it back to null.
+        That way, we ensure to not call this callback while libwebrtc expects not to be called.
+
 2020-11-12  Youenn Fablet  <youenn@apple.com>
 

trunk/Source/ThirdParty/libwebrtc/Source/webrtc/sdk/WebKit/WebKitEncoder.mm

@@ -249 +249 @@
 int32_t RemoteVideoEncoder::Release()
 {
+    RegisterEncodeCompleteCallback(nullptr);
     return 0;
 }