Changeset 269794 in webkit

Timestamp:

Nov 13, 2020, 2:16:29 PM (6 years ago)

Author:

Russell Epstein

Message:

Cherry-pick r268782. rdar://problem/71381941

Release assert in ~Node due to render element of pseudo element not getting removed in time
​https://bugs.webkit.org/show_bug.cgi?id=217996

Patch by Julian Gonzalez <​julian_a_gonzalez@apple.com> on 2020-10-20
Reviewed by Ryosuke Niwa.

When attaching a shadow root to an element, remember to tear down renderers not only if
one exists on the element, but also if it uses display: contents.

• dom/Element.cpp: (WebCore::Element::addShadowRoot):

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@268782 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Location:

branches/safari-610-branch/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• dom/Element.cpp (modified) (1 diff)

branches/safari-610-branch/Source/WebCore/ChangeLog

@@ +1 @@
+2020-11-13  Russell Epstein  <repstein@apple.com>
+
+        Cherry-pick r268782. rdar://problem/71381941
+
+    Release assert in ~Node due to render element of pseudo element not getting removed in time
+    https://bugs.webkit.org/show_bug.cgi?id=217996
+    
+    Patch by Julian Gonzalez <julian_a_gonzalez@apple.com> on 2020-10-20
+    Reviewed by Ryosuke Niwa.
+    
+    When attaching a shadow root to an element, remember to tear down renderers not only if
+    one exists on the element, but also if it uses display: contents.
+    
+    * dom/Element.cpp:
+    (WebCore::Element::addShadowRoot):
+    
+    git-svn-id: https://svn.webkit.org/repository/webkit/trunk@268782 268f45cc-cd09-0410-ab3c-d52691b4dbfc
+
+    2020-10-20  Julian Gonzalez  <julian_a_gonzalez@apple.com>
+
+            Release assert in ~Node due to render element of pseudo element not getting removed in time
+            https://bugs.webkit.org/show_bug.cgi?id=217996
+
+            Reviewed by Ryosuke Niwa.
+
+            When attaching a shadow root to an element, remember to tear down renderers not only if
+            one exists on the element, but also if it uses display: contents.
+
+            * dom/Element.cpp:
+            (WebCore::Element::addShadowRoot):
+
 2020-11-13  Russell Epstein  <repstein@apple.com>
 

branches/safari-610-branch/Source/WebCore/dom/Element.cpp

@@ -2290 +2290 @@
         WidgetHierarchyUpdatesSuspensionScope suspendWidgetHierarchyUpdates;
         ScriptDisallowedScope::InMainThread scriptDisallowedScope;
-        if (renderer())
+        if (renderer() || hasDisplayContents())
             RenderTreeUpdater::tearDownRenderers(*this);