Changeset 269804 in webkit

Timestamp:

Nov 13, 2020, 3:46:07 PM (6 years ago)

Author:

aakash_jain@apple.com

Message:

[build.webkit.org] Update CompileWebKit step for new buildbot
​https://bugs.webkit.org/show_bug.cgi?id=218922

Reviewed by Jonathan Bedard.

• CISupport/build-webkit-org/steps.py:

(CompileWebKit.start): Initialize logobserver.
(CompileWebKit.parseOutputLine): Method to process each line.
(CompileWebKit._addToLog): Method to add to the log which is displayed in UI.
(CompileWebKit.createSummary):

Location:

trunk/Tools

Files:

• CISupport/build-webkit-org/steps.py (modified) (4 diffs)
• ChangeLog (modified) (1 diff)

trunk/Tools/CISupport/build-webkit-org/steps.py

@@ -31 +31 @@
 import socket
 import json
-import cStringIO
 import urllib
 
@@ -48 +47 @@
     from buildbot.steps.source.svn import SVN
 else:
+    import cStringIO
     from buildbot.steps.source import SVN
     logobserver = lambda: None
@@ -273 +273 @@
         additionalArguments = self.getProperty('additionalArguments')
 
+        if USE_BUILDBOT_VERSION2:
+            self.log_observer = ParseByLineLogObserver(self.parseOutputLine)
+            self.addLogObserver('stdio', self.log_observer)
+
         if additionalArguments:
             self.setCommand(self.command + additionalArguments)
@@ -290 +294 @@
         return shell.Compile.start(self)
 
+    def parseOutputLine(self, line):
+        if "arning:" in line:
+            self._addToLog('warnings', line + '\n')
+        if "rror:" in line:
+            self._addToLog('errors', line + '\n')
+
+    @defer.inlineCallbacks
+    def _addToLog(self, logName, message):
+        try:
+            log = self.getLog(logName)
+        except KeyError:
+            log = yield self.addLog(logName)
+        log.addStdout(message)
+
     def createSummary(self, log):
+        # FIXME: delete this method after switching to Buildbot v2
+        if USE_BUILDBOT_VERSION2:
+            return
         platform = self.getProperty('platform')
         if platform.startswith('mac'):

trunk/Tools/ChangeLog

@@ +1 @@
+2020-11-13  Aakash Jain  <aakash_jain@apple.com>
+
+        [build.webkit.org] Update CompileWebKit step for new buildbot
+        https://bugs.webkit.org/show_bug.cgi?id=218922
+
+        Reviewed by Jonathan Bedard.
+
+        * CISupport/build-webkit-org/steps.py:
+        (CompileWebKit.start): Initialize logobserver.
+        (CompileWebKit.parseOutputLine): Method to process each line.
+        (CompileWebKit._addToLog): Method to add to the log which is displayed in UI.
+        (CompileWebKit.createSummary):
+
 2020-11-13  Jonathan Bedard  <jbedard@apple.com>