Changeset 269833 in webkit

Timestamp:

Nov 15, 2020, 1:03:32 PM (6 years ago)

Author:

Andres Gonzalez

Message:

Fix for infinite recursion crash in isolated tree mode.
​https://bugs.webkit.org/show_bug.cgi?id=218961

Reviewed by Chris Fleizach.

Covered by existing tests.

[WebAccessibilityObjectWrapper attachmentView] can cause the
initialization of a new AXIsolatedObject which in turn can invoke
indirectly AccessibilityObject::accessibilityIgnoreAttachment, thus
creating an infinite recursion. This change avoids this problem and
makes this method more efficient even in those cases where there was no
infinite recursion.

• accessibility/mac/AccessibilityObjectMac.mm:

(WebCore::AccessibilityObject::accessibilityIgnoreAttachment const):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• accessibility/mac/AccessibilityObjectMac.mm (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2020-11-15  Andres Gonzalez  <andresg_22@apple.com>
+
+        Fix for infinite recursion crash in isolated tree mode.
+        https://bugs.webkit.org/show_bug.cgi?id=218961
+
+        Reviewed by Chris Fleizach.
+
+        Covered by existing tests.
+
+        [WebAccessibilityObjectWrapper attachmentView] can cause the
+        initialization of a new AXIsolatedObject which in turn can invoke
+        indirectly AccessibilityObject::accessibilityIgnoreAttachment, thus
+        creating an infinite recursion. This change avoids this problem and
+        makes this method more efficient even in those cases where there was no
+        infinite recursion.
+
+        * accessibility/mac/AccessibilityObjectMac.mm:
+        (WebCore::AccessibilityObject::accessibilityIgnoreAttachment const):
+
 2020-11-15  Youenn Fablet  <youenn@apple.com>
 

trunk/Source/WebCore/accessibility/mac/AccessibilityObjectMac.mm

@@ -106 +106 @@
 
     ALLOW_DEPRECATED_DECLARATIONS_BEGIN
-    if ([wrapper() attachmentView])
-        return [[wrapper() attachmentView] accessibilityIsIgnored];
+    id attachmentView = widget ? NSAccessibilityUnignoredDescendant(widget->platformWidget()) : nil;
+    if (attachmentView)
+        return [attachmentView accessibilityIsIgnored];
     ALLOW_DEPRECATED_DECLARATIONS_END