Changeset 27013 in webkit
- Timestamp:
- Oct 24, 2007, 8:50:17 PM (17 years ago)
- Location:
- trunk/WebKitTools
- Files:
-
- 2 edited
Legend:
- Unmodified
- Added
- Removed
-
TabularUnified trunk/WebKitTools/ChangeLog ¶
r27005 r27013 1 2007-10-24 David Kilzer <ddkilzer@webkit.org> 2 3 Minor clean-up of prepare-ChangeLog script. 4 5 Reviewed by Adam. 6 7 * Scripts/prepare-ChangeLog: Keep list of updated ChangeLog files in an array instead 8 of a string. Use multi-argument versions of open() and system() for flexibility and 9 security. 10 1 11 2007-10-24 Alice Liu <alice.liu@apple.com> 2 12 -
TabularUnified trunk/WebKitTools/Scripts/prepare-ChangeLog ¶
r26866 r27013 4 4 # 5 5 # Copyright (C) 2000, 2001 Eazel, Inc. 6 # Copyright (C) 2002, 2003, 2004, 2005, 2006, 2007 Apple Inc. 6 # Copyright (C) 2002, 2003, 2004, 2005, 2006, 2007 Apple Inc. All rights reserved. 7 7 # 8 8 # prepare-ChangeLog is free software; you can redistribute it and/or … … 262 262 263 263 # Get the latest ChangeLog files from svn. 264 my $logs = "";264 my @logs = (); 265 265 foreach my $prefix (sort keys %files) { 266 $logs .= " ${prefix}ChangeLog";267 } 268 269 if ( $logs && $updateChangeLogs && $isSVN) {266 push @logs, File::Spec->catfile($prefix, "ChangeLog"); 267 } 268 269 if (@logs && $updateChangeLogs && $isSVN) { 270 270 print STDERR " Running 'svn update' to update ChangeLog files.\n"; 271 open ERRORS, "$SVN update -q$logs |" or die "The svn update of ChangeLog files failed: $!.\n"; 271 open ERRORS, "-|", $SVN, "update", "-q", @logs 272 or die "The svn update of ChangeLog files failed: $!.\n"; 272 273 print STDERR " $_" while <ERRORS>; 273 274 close ERRORS; … … 317 318 318 319 # Open ChangeLogs. 319 if ($openChangeLogs && $logs) {320 if ($openChangeLogs && @logs) { 320 321 print STDERR " Opening the edited ChangeLog files.\n"; 321 322 my $editor = $ENV{"CHANGE_LOG_EDIT_APPLICATION"}; 322 323 if ($editor) { 323 system "open -a '$editor'$logs";324 system "open", "-a", $editor, @logs; 324 325 } else { 325 system "open -e$logs";326 system "open", "-e", @logs; 326 327 } 327 328 }
Note:
See TracChangeset
for help on using the changeset viewer.