Changeset 27051 in webkit

Timestamp:

Oct 25, 2007, 11:23:01 AM (17 years ago)

Author:

mitz

Message:

WebCore:

Reviewed by Dave Hyatt.

• fix ​http://bugs.webkit.org/show_bug.cgi?id=15362 <rdar://problem/5558715> Safari Crashes when opening a JS TreeGrid widget

Test: fast/dynamic/insert-before-table-part-in-continuation.html

• rendering/RenderFlow.cpp: (WebCore::RenderFlow::addChildWithContinuation): If beforeChild's parent is an anonymous table part, let the table figure out where to insert the new child.

LayoutTests:

Reviewed by Dave Hyatt.

• test for ​http://bugs.webkit.org/show_bug.cgi?id=15362 <rdar://problem/5558715> Safari Crashes when opening a JS TreeGrid widget

• fast/dynamic/insert-before-table-part-in-continuation.html: Added.
• platform/mac/fast/dynamic/insert-before-table-part-in-continuation-expected.checksum: Added.
• platform/mac/fast/dynamic/insert-before-table-part-in-continuation-expected.png: Added.
• platform/mac/fast/dynamic/insert-before-table-part-in-continuation-expected.txt: Added.

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/fast/dynamic/insert-before-table-part-in-continuation.html (added)
• LayoutTests/platform/mac/fast/dynamic/insert-before-table-part-in-continuation-expected.checksum (added)
• LayoutTests/platform/mac/fast/dynamic/insert-before-table-part-in-continuation-expected.png (added)
• LayoutTests/platform/mac/fast/dynamic/insert-before-table-part-in-continuation-expected.txt (added)
• WebCore/ChangeLog (modified) (1 diff)
• WebCore/rendering/RenderFlow.cpp (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2007-10-25  Dan Bernstein  <mitz@apple.com>
+
+        Reviewed by Dave Hyatt.
+
+        - test for http://bugs.webkit.org/show_bug.cgi?id=15362
+          <rdar://problem/5558715> Safari Crashes when opening a JS TreeGrid widget
+
+        * fast/dynamic/insert-before-table-part-in-continuation.html: Added.
+        * platform/mac/fast/dynamic/insert-before-table-part-in-continuation-expected.checksum: Added.
+        * platform/mac/fast/dynamic/insert-before-table-part-in-continuation-expected.png: Added.
+        * platform/mac/fast/dynamic/insert-before-table-part-in-continuation-expected.txt: Added.
+
 2007-10-25  Holger Freyther  <zecke@selfish.org>
 

trunk/WebCore/ChangeLog

@@ +1 @@
+2007-10-25  Dan Bernstein  <mitz@apple.com>
+
+        Reviewed by Dave Hyatt.
+
+        - fix http://bugs.webkit.org/show_bug.cgi?id=15362
+          <rdar://problem/5558715> Safari Crashes when opening a JS TreeGrid widget
+
+        Test: fast/dynamic/insert-before-table-part-in-continuation.html
+
+        * rendering/RenderFlow.cpp:
+        (WebCore::RenderFlow::addChildWithContinuation): If beforeChild's
+        parent is an anonymous table part, let the table figure out where to
+        insert the new child.
+
 2007-10-25  Alp Toker  <alp@atoker.com>
 

trunk/WebCore/rendering/RenderFlow.cpp

@@ -86 +86 @@
 void RenderFlow::addChildWithContinuation(RenderObject* newChild, RenderObject* beforeChild)
 {
+    if (beforeChild && (beforeChild->parent()->isTableRow() || beforeChild->parent()->isTableSection() || beforeChild->parent()->isTable())) {
+        RenderObject* anonymousTablePart = beforeChild->parent();
+        ASSERT(anonymousTablePart->isAnonymous());
+        while (!anonymousTablePart->isTable()) {
+            anonymousTablePart = anonymousTablePart->parent();
+            ASSERT(anonymousTablePart->isAnonymous());
+        }
+        return anonymousTablePart->addChild(newChild, beforeChild);
+    }
+
     RenderFlow* flow = continuationBefore(beforeChild);
     ASSERT(!beforeChild || beforeChild->parent()->isRenderBlock() ||