Changeset 27051 in webkit


Ignore:
Timestamp:
Oct 25, 2007 11:23:01 AM (16 years ago)
Author:
mitz
Message:

WebCore:

Reviewed by Dave Hyatt.

Test: fast/dynamic/insert-before-table-part-in-continuation.html

  • rendering/RenderFlow.cpp: (WebCore::RenderFlow::addChildWithContinuation): If beforeChild's parent is an anonymous table part, let the table figure out where to insert the new child.

LayoutTests:

Reviewed by Dave Hyatt.

  • fast/dynamic/insert-before-table-part-in-continuation.html: Added.
  • platform/mac/fast/dynamic/insert-before-table-part-in-continuation-expected.checksum: Added.
  • platform/mac/fast/dynamic/insert-before-table-part-in-continuation-expected.png: Added.
  • platform/mac/fast/dynamic/insert-before-table-part-in-continuation-expected.txt: Added.
Location:
trunk
Files:
4 added
3 edited

Legend:

Unmodified
Added
Removed
  • trunk/LayoutTests/ChangeLog

    r27045 r27051  
     12007-10-25  Dan Bernstein  <mitz@apple.com>
     2
     3        Reviewed by Dave Hyatt.
     4
     5        - test for http://bugs.webkit.org/show_bug.cgi?id=15362
     6          <rdar://problem/5558715> Safari Crashes when opening a JS TreeGrid widget
     7
     8        * fast/dynamic/insert-before-table-part-in-continuation.html: Added.
     9        * platform/mac/fast/dynamic/insert-before-table-part-in-continuation-expected.checksum: Added.
     10        * platform/mac/fast/dynamic/insert-before-table-part-in-continuation-expected.png: Added.
     11        * platform/mac/fast/dynamic/insert-before-table-part-in-continuation-expected.txt: Added.
     12
    1132007-10-25  Holger Freyther  <zecke@selfish.org>
    214
  • trunk/WebCore/ChangeLog

    r27050 r27051  
     12007-10-25  Dan Bernstein  <mitz@apple.com>
     2
     3        Reviewed by Dave Hyatt.
     4
     5        - fix http://bugs.webkit.org/show_bug.cgi?id=15362
     6          <rdar://problem/5558715> Safari Crashes when opening a JS TreeGrid widget
     7
     8        Test: fast/dynamic/insert-before-table-part-in-continuation.html
     9
     10        * rendering/RenderFlow.cpp:
     11        (WebCore::RenderFlow::addChildWithContinuation): If beforeChild's
     12        parent is an anonymous table part, let the table figure out where to
     13        insert the new child.
     14
    1152007-10-25  Alp Toker  <alp@atoker.com>
    216
  • trunk/WebCore/rendering/RenderFlow.cpp

    r26573 r27051  
    8686void RenderFlow::addChildWithContinuation(RenderObject* newChild, RenderObject* beforeChild)
    8787{
     88    if (beforeChild && (beforeChild->parent()->isTableRow() || beforeChild->parent()->isTableSection() || beforeChild->parent()->isTable())) {
     89        RenderObject* anonymousTablePart = beforeChild->parent();
     90        ASSERT(anonymousTablePart->isAnonymous());
     91        while (!anonymousTablePart->isTable()) {
     92            anonymousTablePart = anonymousTablePart->parent();
     93            ASSERT(anonymousTablePart->isAnonymous());
     94        }
     95        return anonymousTablePart->addChild(newChild, beforeChild);
     96    }
     97
    8898    RenderFlow* flow = continuationBefore(beforeChild);
    8999    ASSERT(!beforeChild || beforeChild->parent()->isRenderBlock() ||
Note: See TracChangeset for help on using the changeset viewer.