Changeset 270592 in webkit

Timestamp:

Dec 9, 2020, 11:53:41 AM (6 years ago)

Author:

commit-queue@webkit.org

Message:

Make PDFHUD.MoveIFrame API test more robust
​https://bugs.webkit.org/show_bug.cgi?id=219667
<rdar://problem/68639688>

Patch by Alex Christensen <​achristensen@webkit.org> on 2020-12-09
Reviewed by Geoffrey Garen.

This test would time out if the place where the TestWKWebView is obscured, which happens frequently on the bots.
Make the test pass if this is the case. It's unfortunate to skip it often, but it still runs sometimes,
and I think this is better than having no test.

• TestWebKitAPI/Tests/WebKitCocoa/WKPDFView.mm:

(TEST):

Location:

trunk/Tools

Files:

• ChangeLog (modified) (1 diff)
• TestWebKitAPI/Tests/WebKitCocoa/WKPDFView.mm (modified) (1 diff)

trunk/Tools/ChangeLog

@@ +1 @@
+2020-12-09  Alex Christensen  <achristensen@webkit.org>
+
+        Make PDFHUD.MoveIFrame API test more robust
+        https://bugs.webkit.org/show_bug.cgi?id=219667
+        <rdar://problem/68639688>
+
+        Reviewed by Geoffrey Garen.
+
+        This test would time out if the place where the TestWKWebView is obscured, which happens frequently on the bots.
+        Make the test pass if this is the case.  It's unfortunate to skip it often, but it still runs sometimes,
+        and I think this is better than having no test.
+
+        * TestWebKitAPI/Tests/WebKitCocoa/WKPDFView.mm:
+        (TEST):
+
 2020-12-09  Jonathan Bedard  <jbedard@apple.com>
 

trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/WKPDFView.mm

@@ -215 +215 @@
     EXPECT_EQ(webView._pdfHUDs.count, 0u);
     [webView _test_waitForDidFinishNavigation];
+
+    // If the TestWKWebView is not visible, visibilityDidChange will be called with false, and there will be no HUD.
+    if (!webView._pdfHUDs.count)
+        return;
+
     EXPECT_EQ(webView._pdfHUDs.count, 1u);
     checkFrame(webView._pdfHUDs.anyObject.frame, 10, 28, 300, 150);