Changeset 270593 in webkit

Timestamp:

Dec 9, 2020, 11:58:30 AM (6 years ago)

Author:

commit-queue@webkit.org

Message:

Fix clicking on links in PDFs on Big Sur after r266654
​https://bugs.webkit.org/show_bug.cgi?id=219665
<rdar://problem/72080683>

Patch by Alex Christensen <​achristensen@webkit.org> on 2020-12-09
Reviewed by Tim Horton.

mouseUp: was being called by AppKit on the WKPDFHUDView instead of the WKWebView, causing the event to not make it to the PDFPlugin,
which meant PDFKit wasn't being told it was clicked on, which means it wasn't telling WebKit to change the frame's location.
Overriding hitTest to forward all mouse events to the WKWebView solves this problem.

Covered by the WebKit.PDFLinkReferrer API test, which was failing on Big Sur, where ENABLE(UI_PROCESS_PDF_HUD) is true.

• UIProcess/PDF/WKPDFHUDView.mm:

(-[WKPDFHUDView hitTest:]):

Location:

trunk/Source/WebKit

Files:

• ChangeLog (modified) (1 diff)
• UIProcess/PDF/WKPDFHUDView.mm (modified) (2 diffs)

trunk/Source/WebKit/ChangeLog

@@ +1 @@
+2020-12-09  Alex Christensen  <achristensen@webkit.org>
+
+        Fix clicking on links in PDFs on Big Sur after r266654
+        https://bugs.webkit.org/show_bug.cgi?id=219665
+        <rdar://problem/72080683>
+
+        Reviewed by Tim Horton.
+
+        mouseUp: was being called by AppKit on the WKPDFHUDView instead of the WKWebView, causing the event to not make it to the PDFPlugin,
+        which meant PDFKit wasn't being told it was clicked on, which means it wasn't telling WebKit to change the frame's location.
+        Overriding hitTest to forward all mouse events to the WKWebView solves this problem.
+
+        Covered by the WebKit.PDFLinkReferrer API test, which was failing on Big Sur, where ENABLE(UI_PROCESS_PDF_HUD) is true.
+
+        * UIProcess/PDF/WKPDFHUDView.mm:
+        (-[WKPDFHUDView hitTest:]):
+
 2020-12-09  Wenson Hsieh  <wenson_hsieh@apple.com>
 

trunk/Source/WebKit/UIProcess/PDF/WKPDFHUDView.mm

@@ -29 +29 @@
 #if ENABLE(UI_PROCESS_PDF_HUD)
 
+#import "WKWebViewInternal.h"
 #import "WebPageProxy.h"
 #import <QuartzCore/CATransaction.h>
@@ -161 +162 @@
 }
 
+- (NSView *)hitTest:(NSPoint)point
+{
+    if (_page)
+        return fromWebPageProxy(*_page);
+
+    ASSERT_NOT_REACHED();
+    return self;
+}
+
 - (void)mouseMoved:(NSEvent *)event
 {