Changeset 270599 in webkit

Timestamp:

Dec 9, 2020, 1:38:56 PM (6 years ago)

Author:

Wenson Hsieh

Message:

Some WebGL tests crash in WebKit::RemoteRenderingBackendProxy::willAppendItem(WebCore::RenderingResourceIdentifier)
​https://bugs.webkit.org/show_bug.cgi?id=219700

Reviewed by Tim Horton.

Fixes these assertions by resetting the identifier of the "most recently appended" image buffer
(m_currentDestinationImageBufferIdentifier) when the image buffer is released in the rendering
backend. We keep track of this so that we can append MetaCommandChangeDestinationImageBuffer
items when painting into multiple image buffers; the code to do this in willAppendItem is
actually robust against the case where m_currentDestinationImageBufferIdentifier is unknown,
but still debug asserts.

• WebProcess/GPU/graphics/RemoteRenderingBackendProxy.cpp:

(WebKit::RemoteRenderingBackendProxy::releaseRemoteResource):

Location:

trunk/Source/WebKit

Files:

• ChangeLog (modified) (1 diff)
• WebProcess/GPU/graphics/RemoteRenderingBackendProxy.cpp (modified) (1 diff)

trunk/Source/WebKit/ChangeLog

@@ +1 @@
+2020-12-09  Wenson Hsieh  <wenson_hsieh@apple.com>
+
+        Some WebGL tests crash in WebKit::RemoteRenderingBackendProxy::willAppendItem(WebCore::RenderingResourceIdentifier)
+        https://bugs.webkit.org/show_bug.cgi?id=219700
+
+        Reviewed by Tim Horton.
+
+        Fixes these assertions by resetting the identifier of the "most recently appended" image buffer
+        (m_currentDestinationImageBufferIdentifier) when the image buffer is released in the rendering
+        backend. We keep track of this so that we can append MetaCommandChangeDestinationImageBuffer
+        items when painting into multiple image buffers; the code to do this in willAppendItem is
+        actually robust against the case where m_currentDestinationImageBufferIdentifier is unknown,
+        but still debug asserts.
+
+        * WebProcess/GPU/graphics/RemoteRenderingBackendProxy.cpp:
+        (WebKit::RemoteRenderingBackendProxy::releaseRemoteResource):
+
 2020-12-09  Alex Christensen  <achristensen@webkit.org>
 

trunk/Source/WebKit/WebProcess/GPU/graphics/RemoteRenderingBackendProxy.cpp

@@ -157 +157 @@
 void RemoteRenderingBackendProxy::releaseRemoteResource(RenderingResourceIdentifier renderingResourceIdentifier)
 {
+    if (renderingResourceIdentifier == m_currentDestinationImageBufferIdentifier)
+        m_currentDestinationImageBufferIdentifier = WTF::nullopt;
+
     send(Messages::RemoteRenderingBackend::ReleaseRemoteResource(renderingResourceIdentifier), m_renderingBackendIdentifier);
 }