⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Changeset 270765 in webkit


Ignore:
Timestamp:
Dec 14, 2020, 2:35:05 AM (6 years ago)
Author:
Lauro Moura
Message:

REGRESSSION(270435) [GStreamer] Many media source tests failing and timing out
​https://bugs.webkit.org/show_bug.cgi?id=219565

Reviewed by Philippe Normand.

Source/WebCore:

Fix the recursing calls due to the refactoring of SourceBufferPrivate.
(As Philippe Normand pointed out and Peng Liu added in the first
version of the patch).

Also fix the didReceiveInitializationSegment signature after r270612.

Covered by existing tests.

  • platform/graphics/gstreamer/mse/AppendPipeline.cpp:

(WebCore::AppendPipeline::didReceiveInitializationSegment):

  • platform/graphics/gstreamer/mse/SourceBufferPrivateGStreamer.cpp:

(WebCore::SourceBufferPrivateGStreamer::didReceiveInitializationSegment):
(WebCore::SourceBufferPrivateGStreamer::didReceiveSample):

  • platform/graphics/gstreamer/mse/SourceBufferPrivateGStreamer.h:

LayoutTests:

Revert the gardened expectations and garden remaining failures.

  • platform/glib/TestExpectations:
  • platform/gtk/TestExpectations:
Location:
trunk
Files:
7 edited

Legend:

Unmodified
Added
Removed

  • trunk/LayoutTests/ChangeLog

    r270758 r270765  
     12020-12-14  Lauro Moura  <lmoura@igalia.com>
     2
     3        REGRESSSION(270435) [GStreamer] Many media source tests failing and timing out
     4        https://bugs.webkit.org/show_bug.cgi?id=219565
     5
     6        Reviewed by Philippe Normand.
     7
     8        Revert the gardened expectations and garden remaining failures.
     9
     10        * platform/glib/TestExpectations:
     11        * platform/gtk/TestExpectations:
     12
    1132020-12-13  Andy Estes  <aestes@apple.com>
    214

  • trunk/LayoutTests/platform/glib/TestExpectations

    r270757 r270765  
    436436webkit.org/b/210528 media/media-source/media-source-seek-back.html [ Crash Pass ]
    437437webkit.org/b/214636 media/media-source/media-source-webm.html [ Timeout Crash ]
    438 webkit.org/b/218317 webkit.org/b/219565 media/media-source/media-source-trackid-change.html [ Failure Timeout ]
     438webkit.org/b/218317 media/media-source/media-source-trackid-change.html [ Failure ]
    439439
    440440webkit.org/b/210528 media/video-src-blob-replay.html [ Crash Pass ]
    … …  
    461461webkit.org/b/219245 webrtc/peer-connection-remote-audio-mute2.html [ Crash ]
    462462
    463 webkit.org/b/219565 media/media-source/media-source-abort-resets-parser.html [ Timeout ]
    464 webkit.org/b/219565 media/media-source/media-source-canplaythrough-event.html [ Timeout ]
    465 webkit.org/b/219565 media/media-source/media-source-error-crash.html [ Timeout ]
    466 webkit.org/b/219565 media/media-source/media-source-paint-to-canvas.html [ Timeout ]
    467 webkit.org/b/219565 media/media-source/media-source-remove-crash.html [ Timeout ]
    468 webkit.org/b/219565 media/media-source/media-source-resize.html [ Timeout ]
    469 webkit.org/b/219565 media/media-source/media-source-samples-resolution-change.html [ Timeout ]
    470 webkit.org/b/219565 media/media-source/media-source-seek-detach-crash.html [ Timeout ]
    471 webkit.org/b/219565 media/media-source/media-source-seek-redundant-append.html [ Timeout ]
    472 webkit.org/b/219565 media/media-source/media-source-seek-twice.html [ Timeout ]
    473 webkit.org/b/219565 media/media-source/media-source-stalled-holds-sleep-assertion.html [ Timeout ]
    474 webkit.org/b/219565 media/media-source/media-source-unnecessary-seek-seeked.html [ Timeout ]
    475 webkit.org/b/219565 media/media-source/media-source-webm-init-inside-segment.html [ Timeout ]
    476 webkit.org/b/219565 imported/w3c/web-platform-tests/encrypted-media/clearkey-mp4-playback-temporary-clear-encrypted.https.html [ Timeout ]
    477 webkit.org/b/219565 imported/w3c/web-platform-tests/encrypted-media/clearkey-mp4-playback-temporary-encrypted-clear-sources.https.html [ Timeout ]
    478 webkit.org/b/219565 imported/w3c/web-platform-tests/encrypted-media/clearkey-mp4-playback-temporary-encrypted-clear.https.html [ Timeout ]
    479 webkit.org/b/219565 imported/w3c/web-platform-tests/encrypted-media/clearkey-mp4-playback-temporary-events.https.html [ Timeout ]
    480 webkit.org/b/219565 imported/w3c/web-platform-tests/encrypted-media/clearkey-mp4-playback-temporary-multikey-sequential-readyState.https.html [ Timeout ]
    481 webkit.org/b/219565 imported/w3c/web-platform-tests/encrypted-media/clearkey-mp4-playback-temporary-multikey-sequential.https.html [ Timeout ]
    482 webkit.org/b/219565 imported/w3c/web-platform-tests/encrypted-media/clearkey-mp4-playback-temporary-multikey.https.html [ Timeout ]
    483 webkit.org/b/219565 imported/w3c/web-platform-tests/encrypted-media/clearkey-mp4-playback-temporary-multisession.https.html [ Timeout ]
    484 webkit.org/b/219565 imported/w3c/web-platform-tests/encrypted-media/clearkey-mp4-playback-temporary-setMediaKeys-after-src.https.html [ Timeout ]
    485 webkit.org/b/219565 imported/w3c/web-platform-tests/encrypted-media/clearkey-mp4-playback-temporary-setMediaKeys-after-update.https.html [ Timeout ]
    486 webkit.org/b/219565 imported/w3c/web-platform-tests/encrypted-media/clearkey-mp4-playback-temporary-setMediaKeys-onencrypted.https.html [ Timeout ]
    487 webkit.org/b/219565 imported/w3c/web-platform-tests/encrypted-media/clearkey-mp4-playback-temporary-two-videos.https.html [ Timeout ]
    488 webkit.org/b/219565 imported/w3c/web-platform-tests/encrypted-media/clearkey-mp4-playback-temporary-waitingforkey.https.html [ Timeout ]
    489 webkit.org/b/219565 imported/w3c/web-platform-tests/encrypted-media/clearkey-mp4-playback-temporary.https.html [ Timeout ]
    490 webkit.org/b/219565 imported/w3c/web-platform-tests/encrypted-media/clearkey-mp4-setmediakeys-again-after-playback.https.html [ Timeout ]
    491 webkit.org/b/219565 imported/w3c/web-platform-tests/encrypted-media/clearkey-mp4-setmediakeys-again-after-resetting-src.https.html [ Timeout ]
    492 webkit.org/b/219565 imported/w3c/web-platform-tests/encrypted-media/clearkey-mp4-waiting-for-a-key.https.html [ Timeout ]
    493 webkit.org/b/219565 imported/w3c/web-platform-tests/media-source/ [ Timeout ]
    494 
     463# Seek failures likely related to r270612
     464webkit.org/b/219822 imported/w3c/web-platform-tests/media-source/mediasource-buffered-seek.html [ Failure ]
     465webkit.org/b/219822 imported/w3c/web-platform-tests/media-source/mediasource-changetype-play-negative.html [ Failure ]
     466webkit.org/b/219822 imported/w3c/web-platform-tests/media-source/mediasource-config-change-webm-av-video-bitrate.html [ Pass Failure ]
     467webkit.org/b/219822 imported/w3c/web-platform-tests/media-source/mediasource-h264-play-starved.html [ Failure ]
     468webkit.org/b/219822 imported/w3c/web-platform-tests/media-source/mediasource-liveseekable.html [ Failure ]
     469webkit.org/b/219822 imported/w3c/web-platform-tests/media-source/mediasource-play-then-seek-back.html [ Failure ]
     470webkit.org/b/219822 imported/w3c/web-platform-tests/media-source/mediasource-redundant-seek.html [ Failure ]
     471webkit.org/b/219822 imported/w3c/web-platform-tests/media-source/mediasource-seek-during-pending-seek.html [ Failure ]
     472webkit.org/b/219822 imported/w3c/web-platform-tests/media-source/mediasource-seekable.html [ Failure ]
     473webkit.org/b/219822 imported/w3c/web-platform-tests/media-source/mediasource-sequencemode-append-buffer.html [ Failure ]
     474webkit.org/b/219822 media/media-source/media-source-canplaythrough-event.html [ Failure ]
     475webkit.org/b/219822 media/media-source/media-source-stalled-holds-sleep-assertion.html [ Failure ]
     476webkit.org/b/219822 media/media-source/media-source-unnecessary-seek-seeked.html [ Failure ]
     477webkit.org/b/219822 imported/w3c/web-platform-tests/media-source/mediasource-video-is-visible.html [ Timeout ]
     478webkit.org/b/219822 media/encrypted-media/clearKey/clearKey-cenc-audio-playback-mse.html [ Timeout ]
     479webkit.org/b/219822 media/encrypted-media/clearKey/clearKey-cenc-video-playback-mse.html [ Timeout ]
     480webkit.org/b/219822 media/media-source/media-source-paint-to-canvas.html [ Timeout ]
     481webkit.org/b/219822 media/media-source/media-source-seek-redundant-append.html [ Timeout ]
     482webkit.org/b/219822 media/media-source/media-source-seek-twice.html [ Timeout ]
    495483
    496484#////////////////////////////////////////////////////////////////////////////////////////
    … …  
    12421230webkit.org/b/190991 imported/w3c/web-platform-tests/encrypted-media/clearkey-check-status-for-hdcp.https.html [ Failure ]
    12431231webkit.org/b/211375 imported/w3c/web-platform-tests/encrypted-media/clearkey-mp4-playback-temporary-clear-encrypted-segmented.https.html [ Skip ]
    1244 # Uncomment after bug219565 webkit.org/b/198830 imported/w3c/web-platform-tests/encrypted-media/clearkey-mp4-playback-temporary.https.html [ Crash Pass ]
     1232webkit.org/b/198830 imported/w3c/web-platform-tests/encrypted-media/clearkey-mp4-playback-temporary.https.html [ Crash Pass ]
    12451233webkit.org/b/210113 imported/w3c/web-platform-tests/encrypted-media/clearkey-mp4-reset-src-after-setmediakeys.https.html [ Failure Pass ]
    1246 # Ditto webkit.org/b/210390 imported/w3c/web-platform-tests/encrypted-media/clearkey-mp4-setmediakeys-again-after-resetting-src.https.html [ Crash Pass ]
    1247 # Ditto webkit.org/b/210965 imported/w3c/web-platform-tests/encrypted-media/clearkey-mp4-playback-temporary-multikey-sequential-readyState.https.html [ Failure ]
    1248 # Ditto webkit.org/b/210966 imported/w3c/web-platform-tests/encrypted-media/clearkey-mp4-setmediakeys-again-after-playback.https.html [ Crash Pass ]
     1234webkit.org/b/210390 imported/w3c/web-platform-tests/encrypted-media/clearkey-mp4-setmediakeys-again-after-resetting-src.https.html [ Crash Pass ]
     1235webkit.org/b/210965 imported/w3c/web-platform-tests/encrypted-media/clearkey-mp4-playback-temporary-multikey-sequential-readyState.https.html [ Failure ]
     1236webkit.org/b/210966 imported/w3c/web-platform-tests/encrypted-media/clearkey-mp4-setmediakeys-again-after-playback.https.html [ Crash Pass ]
    12491237webkit.org/b/178707 imported/w3c/web-platform-tests/encrypted-media/encrypted-media-default-feature-policy.https.sub.html [ Skip ]
    12501238
    1251 # Uncomment the lines below once bug219565 is fixed
    1252 #imported/w3c/web-platform-tests/encrypted-media/clearkey-check-encryption-scheme.https.html [ Pass ]
    1253 #imported/w3c/web-platform-tests/encrypted-media/clearkey-check-initdata-type.https.html [ Pass ]
    1254 #imported/w3c/web-platform-tests/encrypted-media/clearkey-events.https.html [ Pass ]
    1255 #imported/w3c/web-platform-tests/encrypted-media/clearkey-events-session-closed-event.https.html [ Pass ]
    1256 #imported/w3c/web-platform-tests/encrypted-media/clearkey-generate-request-disallowed-input.https.html [ Pass ]
    1257 #imported/w3c/web-platform-tests/encrypted-media/clearkey-invalid-license.https.html [ Pass ]
    1258 #imported/w3c/web-platform-tests/encrypted-media/clearkey-keystatuses.https.html [ Pass ]
    1259 #imported/w3c/web-platform-tests/encrypted-media/clearkey-keystatuses-multiple-sessions.https.html [ Pass ]
    1260 #imported/w3c/web-platform-tests/encrypted-media/clearkey-mp4-playback-temporary-clear-encrypted.https.html [ Pass ]
    1261 #imported/w3c/web-platform-tests/encrypted-media/clearkey-mp4-playback-temporary-encrypted-clear.https.html [ Pass ]
    1262 #imported/w3c/web-platform-tests/encrypted-media/clearkey-mp4-playback-temporary-encrypted-clear-sources.https.html [ Pass ]
    1263 #imported/w3c/web-platform-tests/encrypted-media/clearkey-mp4-playback-temporary-events.https.html [ Pass ]
    1264 #imported/w3c/web-platform-tests/encrypted-media/clearkey-mp4-playback-temporary-multikey.https.html [ Pass ]
    1265 #imported/w3c/web-platform-tests/encrypted-media/clearkey-mp4-playback-temporary-multikey-sequential.https.html [ Pass ]
    1266 #imported/w3c/web-platform-tests/encrypted-media/clearkey-mp4-playback-temporary-multisession.https.html [ Pass ]
    1267 #imported/w3c/web-platform-tests/encrypted-media/clearkey-mp4-playback-temporary-setMediaKeys-after-src.https.html [ Pass ]
    1268 #imported/w3c/web-platform-tests/encrypted-media/clearkey-mp4-playback-temporary-setMediaKeys-after-update.https.html [ Pass ]
    1269 #imported/w3c/web-platform-tests/encrypted-media/clearkey-mp4-playback-temporary-setMediaKeys-onencrypted.https.html [ Pass ]
    1270 #imported/w3c/web-platform-tests/encrypted-media/clearkey-mp4-playback-temporary-two-videos.https.html [ Pass ]
    1271 #imported/w3c/web-platform-tests/encrypted-media/clearkey-mp4-playback-temporary-waitingforkey.https.html [ Pass ]
    1272 #imported/w3c/web-platform-tests/encrypted-media/clearkey-mp4-requestmediakeysystemaccess.https.html [ Pass ]
    1273 #imported/w3c/web-platform-tests/encrypted-media/clearkey-mp4-setmediakeys-at-same-time.https.html [ Pass ]
    1274 #imported/w3c/web-platform-tests/encrypted-media/clearkey-mp4-setmediakeys.https.html [ Pass ]
    1275 #imported/w3c/web-platform-tests/encrypted-media/clearkey-mp4-setmediakeys-multiple-times-with-different-mediakeys.https.html [ Pass ]
    1276 #imported/w3c/web-platform-tests/encrypted-media/clearkey-mp4-setmediakeys-multiple-times-with-the-same-mediakeys.https.html [ Pass ]
    1277 #imported/w3c/web-platform-tests/encrypted-media/clearkey-mp4-setmediakeys-to-multiple-video-elements.https.html [ Pass ]
    1278 #imported/w3c/web-platform-tests/encrypted-media/clearkey-mp4-syntax-mediakeysession.https.html [ Pass ]
    1279 #imported/w3c/web-platform-tests/encrypted-media/clearkey-mp4-syntax-mediakeys.https.html [ Pass ]
    1280 #imported/w3c/web-platform-tests/encrypted-media/clearkey-mp4-syntax-mediakeysystemaccess.https.html [ Pass ]
    1281 #imported/w3c/web-platform-tests/encrypted-media/clearkey-mp4-unique-origin.https.html [ Pass ]
    1282 #imported/w3c/web-platform-tests/encrypted-media/clearkey-mp4-update-disallowed-input.https.html [ Pass ]
    1283 #imported/w3c/web-platform-tests/encrypted-media/clearkey-mp4-waiting-for-a-key.https.html [ Pass ]
    1284 #imported/w3c/web-platform-tests/encrypted-media/clearkey-not-callable-after-createsession.https.html [ Pass ]
    1285 #imported/w3c/web-platform-tests/encrypted-media/clearkey-update-non-ascii-input.https.html [ Pass ]
     1239
     1240imported/w3c/web-platform-tests/encrypted-media/clearkey-check-encryption-scheme.https.html [ Pass ]
     1241imported/w3c/web-platform-tests/encrypted-media/clearkey-check-initdata-type.https.html [ Pass ]
     1242imported/w3c/web-platform-tests/encrypted-media/clearkey-events.https.html [ Pass ]
     1243imported/w3c/web-platform-tests/encrypted-media/clearkey-events-session-closed-event.https.html [ Pass ]
     1244imported/w3c/web-platform-tests/encrypted-media/clearkey-generate-request-disallowed-input.https.html [ Pass ]
     1245imported/w3c/web-platform-tests/encrypted-media/clearkey-invalid-license.https.html [ Pass ]
     1246imported/w3c/web-platform-tests/encrypted-media/clearkey-keystatuses.https.html [ Pass ]
     1247imported/w3c/web-platform-tests/encrypted-media/clearkey-keystatuses-multiple-sessions.https.html [ Pass ]
     1248imported/w3c/web-platform-tests/encrypted-media/clearkey-mp4-playback-temporary-clear-encrypted.https.html [ Pass ]
     1249imported/w3c/web-platform-tests/encrypted-media/clearkey-mp4-playback-temporary-encrypted-clear.https.html [ Pass ]
     1250imported/w3c/web-platform-tests/encrypted-media/clearkey-mp4-playback-temporary-encrypted-clear-sources.https.html [ Pass ]
     1251imported/w3c/web-platform-tests/encrypted-media/clearkey-mp4-playback-temporary-events.https.html [ Pass ]
     1252imported/w3c/web-platform-tests/encrypted-media/clearkey-mp4-playback-temporary-multikey.https.html [ Pass ]
     1253imported/w3c/web-platform-tests/encrypted-media/clearkey-mp4-playback-temporary-multikey-sequential.https.html [ Pass ]
     1254imported/w3c/web-platform-tests/encrypted-media/clearkey-mp4-playback-temporary-multisession.https.html [ Pass ]
     1255imported/w3c/web-platform-tests/encrypted-media/clearkey-mp4-playback-temporary-setMediaKeys-after-src.https.html [ Pass ]
     1256imported/w3c/web-platform-tests/encrypted-media/clearkey-mp4-playback-temporary-setMediaKeys-after-update.https.html [ Pass ]
     1257imported/w3c/web-platform-tests/encrypted-media/clearkey-mp4-playback-temporary-setMediaKeys-onencrypted.https.html [ Pass ]
     1258imported/w3c/web-platform-tests/encrypted-media/clearkey-mp4-playback-temporary-two-videos.https.html [ Pass ]
     1259imported/w3c/web-platform-tests/encrypted-media/clearkey-mp4-playback-temporary-waitingforkey.https.html [ Pass ]
     1260imported/w3c/web-platform-tests/encrypted-media/clearkey-mp4-requestmediakeysystemaccess.https.html [ Pass ]
     1261imported/w3c/web-platform-tests/encrypted-media/clearkey-mp4-setmediakeys-at-same-time.https.html [ Pass ]
     1262imported/w3c/web-platform-tests/encrypted-media/clearkey-mp4-setmediakeys.https.html [ Pass ]
     1263imported/w3c/web-platform-tests/encrypted-media/clearkey-mp4-setmediakeys-multiple-times-with-different-mediakeys.https.html [ Pass ]
     1264imported/w3c/web-platform-tests/encrypted-media/clearkey-mp4-setmediakeys-multiple-times-with-the-same-mediakeys.https.html [ Pass ]
     1265imported/w3c/web-platform-tests/encrypted-media/clearkey-mp4-setmediakeys-to-multiple-video-elements.https.html [ Pass ]
     1266imported/w3c/web-platform-tests/encrypted-media/clearkey-mp4-syntax-mediakeysession.https.html [ Pass ]
     1267imported/w3c/web-platform-tests/encrypted-media/clearkey-mp4-syntax-mediakeys.https.html [ Pass ]
     1268imported/w3c/web-platform-tests/encrypted-media/clearkey-mp4-syntax-mediakeysystemaccess.https.html [ Pass ]
     1269imported/w3c/web-platform-tests/encrypted-media/clearkey-mp4-unique-origin.https.html [ Pass ]
     1270imported/w3c/web-platform-tests/encrypted-media/clearkey-mp4-update-disallowed-input.https.html [ Pass ]
     1271imported/w3c/web-platform-tests/encrypted-media/clearkey-mp4-waiting-for-a-key.https.html [ Pass ]
     1272imported/w3c/web-platform-tests/encrypted-media/clearkey-not-callable-after-createsession.https.html [ Pass ]
     1273imported/w3c/web-platform-tests/encrypted-media/clearkey-update-non-ascii-input.https.html [ Pass ]
    12861274
    12871275#////////////////////////////////////////////////////////////////////////////////////////
    … …  
    16811669webkit.org/b/169917 webgl/1.0.3/conformance/uniforms/gl-uniform-arrays.html [ Slow ]
    16821670webkit.org/b/169917 webgl/1.0.3/conformance/uniforms/out-of-bounds-uniform-array-access.html [ Slow ]
    1683 webkit.org/b/219565 webkit.org/b/171726 media/media-source/media-source-init-segment-duration.html [ Failure Timeout ]
     1671webkit.org/b/171726 media/media-source/media-source-init-segment-duration.html [ Failure ]
    16841672webkit.org/b/172270 fast/text/web-font-load-invisible-during-loading.html [ Failure ]
    16851673webkit.org/b/172271 fast/text/emoji-overlap.html [ ImageOnlyFailure ]

  • trunk/LayoutTests/platform/gtk/TestExpectations

    r270757 r270765  
    402402webkit.org/b/167108 imported/w3c/web-platform-tests/media-source/URL-createObjectURL-revoke.html [ Failure ]
    403403
    404 # Timing out after r270435.
    405 webkit.org/b/219565 http/tests/media/media-source/mediasource-play-then-seek-back-with-remote-control.html [ Skip ]
    406 webkit.org/b/219565 imported/w3c/web-platform-tests/media-source/mediasource-activesourcebuffers.html [ Skip ]
    407 webkit.org/b/219565 imported/w3c/web-platform-tests/media-source/mediasource-append-buffer.html [ Skip ]
    408 webkit.org/b/219565 imported/w3c/web-platform-tests/media-source/mediasource-avtracks.html [ Skip ]
    409 webkit.org/b/219565 imported/w3c/web-platform-tests/media-source/mediasource-buffered.html [ Skip ]
    410 webkit.org/b/219565 imported/w3c/web-platform-tests/media-source/mediasource-changetype.html [ Skip ]
    411 webkit.org/b/219565 imported/w3c/web-platform-tests/media-source/mediasource-duration.html [ Skip ]
    412 webkit.org/b/219565 imported/w3c/web-platform-tests/media-source/mediasource-endofstream.html [ Skip ]
    413 webkit.org/b/219565 imported/w3c/web-platform-tests/media-source/mediasource-errors.html [ Skip ]
    414 webkit.org/b/219565 imported/w3c/web-platform-tests/media-source/mediasource-removesourcebuffer.html [ Skip ]
    415 webkit.org/b/219565 imported/w3c/web-platform-tests/media-source/mediasource-duration-boundaryconditions.html [ Skip ]
    416 webkit.org/b/219565 imported/w3c/web-platform-tests/media-source/mediasource-correct-frames.html [ Skip ]
    417 webkit.org/b/219565 imported/w3c/web-platform-tests/media-source/mediasource-config-change-mp4-v-framesize.html [ Skip ]
    418 webkit.org/b/219565 imported/w3c/web-platform-tests/media-source/mediasource-replay.html [ Skip ]
    419 webkit.org/b/219565 imported/w3c/web-platform-tests/media-source/mediasource-seek-beyond-duration.html [ Skip ]
    420 webkit.org/b/219565 imported/w3c/web-platform-tests/media-source/mediasource-changetype-play.html [ Skip ]
    421 webkit.org/b/219565 imported/w3c/web-platform-tests/media-source/mediasource-correct-frames-after-reappend.html [ Skip ]
    422 webkit.org/b/219565 media/encrypted-media/clearKey/clearKey-cenc-audio-playback-mse.html [ Skip ]
    423 webkit.org/b/219565 media/encrypted-media/clearKey/clearKey-cenc-video-playback-mse.html [ Skip ]
    424 webkit.org/b/219565 media/encrypted-media/clearKey/clearKey-message-cenc-event-mse.html [ Skip ]
    425 webkit.org/b/219565 media/encrypted-media/clearKey/clearKey-webm-video-playback-mse.html [ Skip ]
    426 
    427 # REGRESSION(r270435). Uncomment failures below after bug is fixed.
     404
    428405# See also bug #175578.
    429 # webkit.org/b/167108 imported/w3c/web-platform-tests/media-source/mediasource-activesourcebuffers.html [ Failure ]
    430 # webkit.org/b/167108 imported/w3c/web-platform-tests/media-source/mediasource-append-buffer.html [ Failure ]
    431 # webkit.org/b/167108 imported/w3c/web-platform-tests/media-source/mediasource-avtracks.html [ Failure ]
    432 # webkit.org/b/167108 imported/w3c/web-platform-tests/media-source/mediasource-buffered.html [ Failure ]
    433 # webkit.org/b/167108 imported/w3c/web-platform-tests/media-source/mediasource-changetype.html [ Failure Crash ]
     406webkit.org/b/167108 imported/w3c/web-platform-tests/media-source/mediasource-activesourcebuffers.html [ Failure ]
     407webkit.org/b/167108 imported/w3c/web-platform-tests/media-source/mediasource-append-buffer.html [ Failure ]
     408webkit.org/b/167108 imported/w3c/web-platform-tests/media-source/mediasource-avtracks.html [ Failure ]
     409webkit.org/b/167108 imported/w3c/web-platform-tests/media-source/mediasource-buffered.html [ Failure ]
     410webkit.org/b/167108 imported/w3c/web-platform-tests/media-source/mediasource-changetype.html [ Failure Crash ]
    434411
    435412# Crash is webkit.org/b/176020.
    436 # webkit.org/b/167108 imported/w3c/web-platform-tests/media-source/mediasource-duration.html [ Failure ]
     413webkit.org/b/167108 imported/w3c/web-platform-tests/media-source/mediasource-duration.html [ Failure ]
    437414
    438415# Crash in bug #176019.
    439 # webkit.org/b/167108 imported/w3c/web-platform-tests/media-source/mediasource-endofstream.html [ Failure ]
    440 # webkit.org/b/167108 imported/w3c/web-platform-tests/media-source/mediasource-errors.html [ Failure ]
    441 # webkit.org/b/210486 imported/w3c/web-platform-tests/media-source/mediasource-correct-frames-after-reappend.html [ Failure Crash Pass ]
     416webkit.org/b/167108 imported/w3c/web-platform-tests/media-source/mediasource-endofstream.html [ Failure ]
     417webkit.org/b/167108 imported/w3c/web-platform-tests/media-source/mediasource-errors.html [ Failure ]
     418webkit.org/b/210486 imported/w3c/web-platform-tests/media-source/mediasource-correct-frames-after-reappend.html [ Failure Crash Pass ]
    442419
    443420# Known issues that were fixed by the WebKitMediaSrc rework that is now reverted.
    444 # webkit.org/b/203078 imported/w3c/web-platform-tests/media-source/mediasource-seek-beyond-duration.html [ Failure ]
    445 # webkit.org/b/203078 imported/w3c/web-platform-tests/media-source/mediasource-replay.html [ Failure Crash ]
    446 # webkit.org/b/203078 imported/w3c/web-platform-tests/media-source/mediasource-config-change-mp4-v-framesize.html [ Pass Failure ]
    447 
    448 # webkit.org/b/176020 imported/w3c/web-platform-tests/media-source/mediasource-removesourcebuffer.html [ Crash Pass ]
    449 # webkit.org/b/180803 imported/w3c/web-platform-tests/media-source/mediasource-duration-boundaryconditions.html [ Failure ]
    450 # webkit.org/b/197711 imported/w3c/web-platform-tests/media-source/mediasource-correct-frames.html [ Pass Failure ]
    451 # webkit.org/b/205110 imported/w3c/web-platform-tests/media-source/mediasource-changetype-play.html [ Failure Crash Pass ]
    452 #
    453 # End of REGRESSION(r270435).
     421webkit.org/b/203078 imported/w3c/web-platform-tests/media-source/mediasource-seek-beyond-duration.html [ Failure ]
     422webkit.org/b/203078 imported/w3c/web-platform-tests/media-source/mediasource-replay.html [ Failure Crash ]
     423webkit.org/b/203078 imported/w3c/web-platform-tests/media-source/mediasource-config-change-mp4-v-framesize.html [ Pass Failure ]
     424
     425webkit.org/b/176020 imported/w3c/web-platform-tests/media-source/mediasource-removesourcebuffer.html [ Crash Pass ]
     426webkit.org/b/180803 imported/w3c/web-platform-tests/media-source/mediasource-duration-boundaryconditions.html [ Failure ]
     427webkit.org/b/197711 imported/w3c/web-platform-tests/media-source/mediasource-correct-frames.html [ Pass Failure ]
     428webkit.org/b/205110 imported/w3c/web-platform-tests/media-source/mediasource-changetype-play.html [ Failure Crash Pass ]
    454429
    455430webkit.org/b/167108 imported/w3c/web-platform-tests/media-source/mediasource-preload.html [ Failure ]

  • trunk/Source/WebCore/ChangeLog

    r270764 r270765  
     12020-12-14  Lauro Moura  <lmoura@igalia.com>
     2
     3        REGRESSSION(270435) [GStreamer] Many media source tests failing and timing out
     4        https://bugs.webkit.org/show_bug.cgi?id=219565
     5
     6        Reviewed by Philippe Normand.
     7
     8        Fix the recursing calls due to the refactoring of `SourceBufferPrivate`.
     9        (As Philippe Normand pointed out and Peng Liu added in the first
     10        version of the patch).
     11
     12        Also fix the didReceiveInitializationSegment signature after r270612.
     13
     14        Covered by existing tests.
     15
     16        * platform/graphics/gstreamer/mse/AppendPipeline.cpp:
     17        (WebCore::AppendPipeline::didReceiveInitializationSegment):
     18        * platform/graphics/gstreamer/mse/SourceBufferPrivateGStreamer.cpp:
     19        (WebCore::SourceBufferPrivateGStreamer::didReceiveInitializationSegment):
     20        (WebCore::SourceBufferPrivateGStreamer::didReceiveSample):
     21        * platform/graphics/gstreamer/mse/SourceBufferPrivateGStreamer.h:
     22
    1232020-12-13  Yusuke Suzuki  <ysuzuki@apple.com>
    224

  • trunk/Source/WebCore/platform/graphics/gstreamer/mse/AppendPipeline.cpp

    r268576 r270765  
    529529    }
    530530
    531     m_sourceBufferPrivate.didReceiveInitializationSegment(initializationSegment);
     531    m_sourceBufferPrivate.didReceiveInitializationSegment(WTFMove(initializationSegment), []() { });
    532532}
    533533

  • trunk/Source/WebCore/platform/graphics/gstreamer/mse/SourceBufferPrivateGStreamer.cpp

    r270435 r270765  
    182182}
    183183
    184 void SourceBufferPrivateGStreamer::didReceiveInitializationSegment(const SourceBufferPrivateClient::InitializationSegment& initializationSegment)
    185 {
    186     didReceiveInitializationSegment(initializationSegment);
     184void SourceBufferPrivateGStreamer::didReceiveInitializationSegment(SourceBufferPrivateClient::InitializationSegment&& initializationSegment, CompletionHandler<void()>&& completionHandler)
     185{
     186    SourceBufferPrivate::didReceiveInitializationSegment(WTFMove(initializationSegment), WTFMove(completionHandler));
    187187}
    188188
    189189void SourceBufferPrivateGStreamer::didReceiveSample(MediaSample& sample)
    190190{
    191     didReceiveSample(sample);
     191    SourceBufferPrivate::didReceiveSample(sample);
    192192}
    193193

  • trunk/Source/WebCore/platform/graphics/gstreamer/mse/SourceBufferPrivateGStreamer.h

    r270435 r270765  
    7373    void notifyReadyForMoreSamples();
    7474
    75     void didReceiveInitializationSegment(const SourceBufferPrivateClient::InitializationSegment&);
     75    void didReceiveInitializationSegment(SourceBufferPrivateClient::InitializationSegment&&, CompletionHandler<void()>&&);
    7676    void didReceiveSample(MediaSample&);
    7777    void didReceiveAllPendingSamples();
Note: See TracChangeset for help on using the changeset viewer.