Changeset 271208 in webkit

Timestamp:

Jan 6, 2021, 12:02:59 PM (6 years ago)

Author:

graouts@webkit.org

Message:

REGRESSION (2020-10-23): webanimations/accelerated-animation-with-easing.html is flaky on Mac Debug
​https://bugs.webkit.org/show_bug.cgi?id=220187
<rdar://problem/72796329>

Reviewed by Dean Jackson.

Ensure there were two stable presentation updates prior to starting animations and two after that to ensure
they are visually running accelerated.

• platform/mac/TestExpectations:
• webanimations/accelerated-animation-with-easing.html:

Location:

trunk/LayoutTests

Files:

• ChangeLog (modified) (1 diff)
• platform/mac/TestExpectations (modified) (1 diff)
• webanimations/accelerated-animation-with-easing.html (modified) (3 diffs)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2021-01-06  Antoine Quint  <graouts@webkit.org>
+
+        REGRESSION (2020-10-23): webanimations/accelerated-animation-with-easing.html is flaky on Mac Debug
+        https://bugs.webkit.org/show_bug.cgi?id=220187
+        <rdar://problem/72796329>
+
+        Reviewed by Dean Jackson.
+
+        Ensure there were two stable presentation updates prior to starting animations and two after that to ensure
+        they are visually running accelerated.
+
+        * platform/mac/TestExpectations:
+        * webanimations/accelerated-animation-with-easing.html:
+
 2021-01-06  Ryan Haddad  <ryanhaddad@apple.com>
 

trunk/LayoutTests/platform/mac/TestExpectations

@@ -1814 +1814 @@
 webkit.org/b/208519 [ Catalina ] webanimations/accelerated-animation-slot-invalidation.html [ Pass ImageOnlyFailure ]
 
-webkit.org/b/220187 [ Debug ] webanimations/accelerated-animation-with-easing.html [ Pass ImageOnlyFailure ]
-
 webkit.org/b/208722 imported/w3c/web-platform-tests/html/semantics/embedded-content/media-elements/seeking/seek-to-max-value.htm [ Pass Failure ]
 

trunk/LayoutTests/webanimations/accelerated-animation-with-easing.html

@@ -27 +27 @@
 <div id="easing-on-animation-three-keyframes"></div>
 <div id="easing-on-keyframe"></div>
+<script src="../resources/ui-helper.js"></script>
 <script>
 
@@ -32 +33 @@
     if (window.testRunner)
         testRunner.waitUntilDone();
+
+    await UIHelper.ensureStablePresentationUpdate();
+    await UIHelper.ensureStablePresentationUpdate();
 
     const animations = [];
@@ -73 +77 @@
 
     await Promise.all(animations.map(animation => animation.ready));
-    await new Promise(requestAnimationFrame);
-    await new Promise(requestAnimationFrame);
-    await new Promise(requestAnimationFrame);
+    await UIHelper.ensureStablePresentationUpdate();
+    await UIHelper.ensureStablePresentationUpdate();
 
     if (window.testRunner)