Changeset 271213 in webkit

Timestamp:

Jan 6, 2021, 1:08:16 PM (6 years ago)

Author:

Chris Dumez

Message:

[GPUProcess] RemoteAudioSourceProviderManager should be a WorkQueueMessageReceiver
​https://bugs.webkit.org/show_bug.cgi?id=220371

Reviewed by Youenn Fablet.

RemoteAudioSourceProviderManager should be a WorkQueueMessageReceiver (not a ThreadMessageReceiver),
since it uses a WorkQueue (not a WTF::Thread). This simplifies the code a bit.

• WebProcess/GPU/media/RemoteAudioSourceProviderManager.cpp:

(WebKit::RemoteAudioSourceProviderManager::setConnection):
(WebKit::RemoteAudioSourceProviderManager::addProvider):
(WebKit::RemoteAudioSourceProviderManager::removeProvider):

• WebProcess/GPU/media/RemoteAudioSourceProviderManager.h:

Location:

trunk/Source/WebKit

Files:

• ChangeLog (modified) (1 diff)
• WebProcess/GPU/media/RemoteAudioSourceProviderManager.cpp (modified) (3 diffs)
• WebProcess/GPU/media/RemoteAudioSourceProviderManager.h (modified) (2 diffs)

trunk/Source/WebKit/ChangeLog

@@ +1 @@
+2021-01-06  Chris Dumez  <cdumez@apple.com>
+
+        [GPUProcess] RemoteAudioSourceProviderManager should be a WorkQueueMessageReceiver
+        https://bugs.webkit.org/show_bug.cgi?id=220371
+
+        Reviewed by Youenn Fablet.
+
+        RemoteAudioSourceProviderManager should be a WorkQueueMessageReceiver (not a ThreadMessageReceiver),
+        since it uses a WorkQueue (not a WTF::Thread). This simplifies the code a bit.
+
+        * WebProcess/GPU/media/RemoteAudioSourceProviderManager.cpp:
+        (WebKit::RemoteAudioSourceProviderManager::setConnection):
+        (WebKit::RemoteAudioSourceProviderManager::addProvider):
+        (WebKit::RemoteAudioSourceProviderManager::removeProvider):
+        * WebProcess/GPU/media/RemoteAudioSourceProviderManager.h:
+
 2021-01-06  Wenson Hsieh  <wenson_hsieh@apple.com>
 

trunk/Source/WebKit/WebProcess/GPU/media/RemoteAudioSourceProviderManager.cpp

@@ -55 +55 @@
 
     if (m_connection)
-        m_connection->removeThreadMessageReceiver(Messages::RemoteAudioSourceProviderManager::messageReceiverName());
+        m_connection->removeWorkQueueMessageReceiver(Messages::RemoteAudioSourceProviderManager::messageReceiverName());
 
     m_connection = WTFMove(connection);
 
     if (m_connection)
-        m_connection->addThreadMessageReceiver(Messages::RemoteAudioSourceProviderManager::messageReceiverName(), this);
+        m_connection->addWorkQueueMessageReceiver(Messages::RemoteAudioSourceProviderManager::messageReceiverName(), m_queue, this);
 }
 
@@ -68 +68 @@
     setConnection(&WebProcess::singleton().ensureGPUProcessConnection().connection());
 
-    dispatchToThread([this, provider = WTFMove(provider)]() mutable {
+    m_queue->dispatch([this, provider = WTFMove(provider)]() mutable {
         auto identifier = provider->identifier();
 
@@ -80 +80 @@
     ASSERT(WTF::isMainRunLoop());
 
-    dispatchToThread([this, identifier] {
+    m_queue->dispatch([this, identifier] {
         ASSERT(m_providers.contains(identifier));
         m_providers.remove(identifier);
     });
-}
-
-void RemoteAudioSourceProviderManager::dispatchToThread(Function<void()>&& callback)
-{
-    m_queue->dispatch(WTFMove(callback));
 }
 

trunk/Source/WebKit/WebProcess/GPU/media/RemoteAudioSourceProviderManager.h

@@ -40 +40 @@
 class RemoteAudioSourceProvider;
 
-class RemoteAudioSourceProviderManager : public IPC::Connection::ThreadMessageReceiverRefCounted {
+class RemoteAudioSourceProviderManager : public IPC::Connection::WorkQueueMessageReceiver {
 public:
     static Ref<RemoteAudioSourceProviderManager> create() { return adoptRef(*new RemoteAudioSourceProviderManager()); }
@@ -52 +52 @@
 private:
     RemoteAudioSourceProviderManager();
-
-    // IPC::Connection::ThreadMessageReceiver
-    void dispatchToThread(Function<void()>&&) final;
 
     // Messages