Changeset 271227 in webkit

Timestamp:

Jan 7, 2021, 12:10:47 AM (6 years ago)

Author:

youenn@apple.com

Message:

Remove non-inclusive language from libwebrtc
​https://bugs.webkit.org/show_bug.cgi?id=220101
<rdar://problem/72727968>

Reviewed by Beth Dakin.

Remove logging erroneously added in ​https://trac.webkit.org/changeset/271150.
Remove non-inclusive language from Source/webrtc/rtc_base/message_digest.h as done in
​https://webrtc-review.googlesource.com/c/src/+/200701.

• Source/webrtc/rtc_base/message_digest.h:
• Source/webrtc/sdk/objc/components/video_codec/RTCVideoDecoderH264.mm:

(-[RTCVideoDecoderH264 init]):
(-[RTCVideoDecoderH264 decodeData:size:timeStamp:]):

• Source/webrtc/sdk/objc/components/video_codec/RTCVideoEncoderH264.mm:

(-[RTCVideoEncoderH264 initWithCodecInfo:]):
(-[RTCVideoEncoderH264 encode:codecSpecificInfo:frameTypes:]):
(-[RTCVideoEncoderH264 frameWasEncoded:flags:sampleBuffer:codecSpecificInfo:width:height:renderTimeMs:timestamp:rotation:isKeyFrameRequired:]):

Location:

trunk/Source/ThirdParty/libwebrtc

Files:

• ChangeLog (modified) (1 diff)
• Source/webrtc/rtc_base/message_digest.h (modified) (1 diff)
• Source/webrtc/sdk/objc/components/video_codec/RTCVideoDecoderH264.mm (modified) (2 diffs)
• Source/webrtc/sdk/objc/components/video_codec/RTCVideoEncoderH264.mm (modified) (3 diffs)

trunk/Source/ThirdParty/libwebrtc/ChangeLog

@@ +1 @@
+2021-01-07  Youenn Fablet  <youenn@apple.com>
+
+        Remove non-inclusive language from libwebrtc
+        https://bugs.webkit.org/show_bug.cgi?id=220101
+        <rdar://problem/72727968>
+
+        Reviewed by Beth Dakin.
+
+        Remove logging erroneously added in https://trac.webkit.org/changeset/271150.
+        Remove non-inclusive language from Source/webrtc/rtc_base/message_digest.h as done in
+        https://webrtc-review.googlesource.com/c/src/+/200701.
+
+        * Source/webrtc/rtc_base/message_digest.h:
+        * Source/webrtc/sdk/objc/components/video_codec/RTCVideoDecoderH264.mm:
+        (-[RTCVideoDecoderH264 init]):
+        (-[RTCVideoDecoderH264 decodeData:size:timeStamp:]):
+        * Source/webrtc/sdk/objc/components/video_codec/RTCVideoEncoderH264.mm:
+        (-[RTCVideoEncoderH264 initWithCodecInfo:]):
+        (-[RTCVideoEncoderH264 encode:codecSpecificInfo:frameTypes:]):
+        (-[RTCVideoEncoderH264 frameWasEncoded:flags:sampleBuffer:codecSpecificInfo:width:height:renderTimeMs:timestamp:rotation:isKeyFrameRequired:]):
+
 2021-01-05  Youenn Fablet  <youenn@apple.com>
 

trunk/Source/ThirdParty/libwebrtc/Source/webrtc/rtc_base/message_digest.h

@@ -46 +46 @@
 };
 
-// A whitelist of approved digest algorithms from RFC 4572 (FIPS 180).
+// A check that an algorithm is in a list of approved digest algorithms
+// from RFC 4572 (FIPS 180).
 bool IsFips180DigestAlgorithm(const std::string& alg);
 

trunk/Source/ThirdParty/libwebrtc/Source/webrtc/sdk/objc/components/video_codec/RTCVideoDecoderH264.mm

@@ -83 +83 @@
     _memoryPool = CMMemoryPoolCreate(nil);
   }
-    RTC_LOG(LS_ERROR) << "H264 decode init";
   return self;
 }
@@ -111 +110 @@
         timeStamp:(uint32_t)timeStamp {
 
-    RTC_LOG(LS_ERROR) << "H264 decodeData";
   if (_error != noErr) {
     RTC_LOG(LS_WARNING) << "Last frame decode failed.";

trunk/Source/ThirdParty/libwebrtc/Source/webrtc/sdk/objc/components/video_codec/RTCVideoEncoderH264.mm

@@ -378 +378 @@
   _isH264LowLatencyEncoderEnabled = true;
 
-  RTC_LOG(LS_ERROR) << "H264 encode initWithCodecInfo";
-
   return self;
 }
@@ -430 +428 @@
     codecSpecificInfo:(nullable id<RTCCodecSpecificInfo>)codecSpecificInfo
            frameTypes:(NSArray<NSNumber *> *)frameTypes {
-
-  RTC_LOG(LS_ERROR) << "H264 encode new frame";
-
   if (!_callback || ![self hasCompressionSession]) {
     return WEBRTC_VIDEO_CODEC_UNINITIALIZED;
@@ -885 +880 @@
                rotation:(RTCVideoRotation)rotation
      isKeyFrameRequired:(bool)isKeyFrameRequired {
-  RTC_LOG(LS_ERROR) << "H264 encoded frame " << status;
   if (status != noErr) {
     RTC_LOG(LS_ERROR) << "H264 encode failed with code: " << status;