Changeset 271242 in webkit

Timestamp:

Jan 7, 2021, 10:17:44 AM (6 years ago)

Author:

ysuzuki@apple.com

Message:

Unreviewed, check ICU header version instead of ICU version
​https://bugs.webkit.org/show_bug.cgi?id=220419

Since open-source WebKit is built against old ICU header, we sometimes disable features based on ICU header version.
So, need to check features based on ICU header version instead of ICU version.

• stress/intl-datetimeformat-format-range-should-check-practically-equal.js:

(vm.icuHeaderVersion):
(vm.icuVersion): Deleted.

• stress/intl-datetimeformat-format-range-to-parts-should-check-practically-equal.js:

(vm.icuHeaderVersion):
(vm.icuVersion): Deleted.

Location:

trunk/JSTests

Files:

• ChangeLog (modified) (1 diff)
• stress/intl-datetimeformat-format-range-should-check-practically-equal.js (modified) (1 diff)
• stress/intl-datetimeformat-format-range-to-parts-should-check-practically-equal.js (modified) (1 diff)

trunk/JSTests/ChangeLog

@@ +1 @@
+2021-01-07  Yusuke Suzuki  <ysuzuki@apple.com>
+
+        Unreviewed, check ICU header version instead of ICU version
+        https://bugs.webkit.org/show_bug.cgi?id=220419
+
+        Since open-source WebKit is built against old ICU header, we sometimes disable features based on ICU header version.
+        So, need to check features based on ICU header version instead of ICU version.
+
+        * stress/intl-datetimeformat-format-range-should-check-practically-equal.js:
+        (vm.icuHeaderVersion):
+        (vm.icuVersion): Deleted.
+        * stress/intl-datetimeformat-format-range-to-parts-should-check-practically-equal.js:
+        (vm.icuHeaderVersion):
+        (vm.icuVersion): Deleted.
+
 2021-01-07  Yusuke Suzuki  <ysuzuki@apple.com>
 

trunk/JSTests/stress/intl-datetimeformat-format-range-should-check-practically-equal.js

@@ -35 +35 @@
 }
 
-if ($vm.icuVersion() >= 64) {
+if ($vm.icuHeaderVersion() >= 64) {
     {
         const date = new Date(2019, 7, 10,  1, 2, 3, 234);

trunk/JSTests/stress/intl-datetimeformat-format-range-to-parts-should-check-practically-equal.js

@@ -49 +49 @@
 }
 
-if ($vm.icuVersion() >= 64) {
+if ($vm.icuHeaderVersion() >= 64) {
     {
         const date = new Date(2019, 7, 10,  1, 2, 3, 234);