Changeset 271267 in webkit

Timestamp:

Jan 7, 2021, 3:24:19 PM (6 years ago)

Author:

commit-queue@webkit.org

Message:

Unreviewed, reverting r271192.
​https://bugs.webkit.org/show_bug.cgi?id=220440

Reverted changeset:

"NSCrossWebsiteTrackingUsageDescription is not working on Mac,
ITP is always enabled"
​https://bugs.webkit.org/show_bug.cgi?id=220190
​https://trac.webkit.org/changeset/271192

Location:

trunk/Source

Files:

• WTF/ChangeLog (modified) (1 diff)
• WTF/wtf/PlatformUse.h (modified) (1 diff)
• WebKit/ChangeLog (modified) (1 diff)
• WebKit/Shared/Cocoa/DefaultWebBrowserChecks.mm (modified) (1 diff)

trunk/Source/WTF/ChangeLog

@@ +1 @@
+2021-01-07  Commit Queue  <commit-queue@webkit.org>
+
+        Unreviewed, reverting r271192.
+        https://bugs.webkit.org/show_bug.cgi?id=220440
+
+
+        Reverted changeset:
+
+        "NSCrossWebsiteTrackingUsageDescription is not working on Mac,
+        ITP is always enabled"
+        https://bugs.webkit.org/show_bug.cgi?id=220190
+        https://trac.webkit.org/changeset/271192
+
 2021-01-07  Monson Shao  <holymonson@gmail.com>
 

trunk/Source/WTF/wtf/PlatformUse.h

@@ -327 +327 @@
 #define USE_OPENXR 0
 #endif
-
-#if (PLATFORM(IOS) && __IPHONE_OS_VERSION_MIN_REQUIRED >= 140000) || PLATFORM(MACCATALYST)
-// FIXME: Include macOS once <rdar://problem/72817121> is fixed.
-#define USE_ITP_TCC_CHECK 1
-#endif

trunk/Source/WebKit/ChangeLog

@@ +1 @@
+2021-01-07  Commit Queue  <commit-queue@webkit.org>
+
+        Unreviewed, reverting r271192.
+        https://bugs.webkit.org/show_bug.cgi?id=220440
+
+
+        Reverted changeset:
+
+        "NSCrossWebsiteTrackingUsageDescription is not working on Mac,
+        ITP is always enabled"
+        https://bugs.webkit.org/show_bug.cgi?id=220190
+        https://trac.webkit.org/changeset/271192
+
 2021-01-07  Alex Christensen  <achristensen@webkit.org>
 

trunk/Source/WebKit/Shared/Cocoa/DefaultWebBrowserChecks.mm

@@ -113 +113 @@
         return true;
 
-#if USE(ITP_TCC_CHECK)
-    TCCAccessPreflightResult result = TCCAccessPreflight(getkTCCServiceWebKitIntelligentTrackingPrevention(), nullptr);
+    TCCAccessPreflightResult result = kTCCAccessPreflightDenied;
+#if (PLATFORM(IOS) && __IPHONE_OS_VERSION_MIN_REQUIRED >= 140000) || (PLATFORM(MAC) && __MAC_OS_X_VERSION_MIN_REQUIRED >= 110000)
+    result = TCCAccessPreflight(getkTCCServiceWebKitIntelligentTrackingPrevention(), nullptr);
+#endif
     return result != kTCCAccessPreflightDenied;
-#else
-    return false;
-#endif
 }