Changeset 271275 in webkit

Timestamp:

Jan 7, 2021, 4:45:26 PM (6 years ago)

Author:

rniwa@webkit.org

Message:

compare-results should be able to compare PLUM3 results
​https://bugs.webkit.org/show_bug.cgi?id=220443

Reviewed by Simon Fraser.

Added the support to compare PLUM3 results.

• Scripts/compare-results:

(plum3Breakdown): Added.
(detectPLUM3): Added.
(PLUM3Results): Added.
(detectBenchmark): Detect PLUM3.
(biggerIsBetter): PLUM3 is a smaller-is-better benchmark.
(main): Added PLUM3.

Location:

trunk/Tools

Files:

• ChangeLog (modified) (1 diff)
• Scripts/compare-results (modified) (6 diffs)

trunk/Tools/ChangeLog

@@ +1 @@
+2021-01-07  Ryosuke Niwa  <rniwa@webkit.org>
+
+        compare-results should be able to compare PLUM3 results
+        https://bugs.webkit.org/show_bug.cgi?id=220443
+
+        Reviewed by Simon Fraser.
+
+        Added the support to compare PLUM3 results.
+
+        * Scripts/compare-results:
+        (plum3Breakdown): Added.
+        (detectPLUM3): Added.
+        (PLUM3Results): Added.
+        (detectBenchmark): Detect PLUM3.
+        (biggerIsBetter): PLUM3 is a smaller-is-better benchmark.
+        (main): Added PLUM3.
+
 2021-01-07  Jonathan Bedard  <jbedard@apple.com>
 

trunk/Tools/Scripts/compare-results

@@ -56 +56 @@
 JetStream2 = "JetStream2"
 PLT5 = "PLT5"
+PLUM3 = "PLUM3"
 MotionMark = "MotionMark"
 MotionMark1_1 = "MotionMark-1.1"
@@ -120 +121 @@
             result["cold--" + nameMapping[test]].append(coldTests[test]["Geometric"])
 
+    return result
+
+def plum3Breakdown(jsonObject):
+    breakdown = BenchmarkResults(jsonObject)
+    result = {}
+    result[unitMarker] = "B"
+    for test in breakdown._results["PLUM3-PhysFootprint"]["tests"].keys():
+        result[test] = breakdown._results["PLUM3-PhysFootprint"]["tests"][test]["metrics"]["Allocations"]["Geometric"]["current"]
     return result
 
@@ -310 +319 @@
         results.append(obj["Geometric"])
     return results
+
+def detectPLUM3(payload):
+    return "PLUM3-PhysFootprint" in payload
+
+def PLUM3Results(payload):
+    assert detectPLUM3(payload)
+    breakdown = BenchmarkResults(payload)
+    return breakdown._results["PLUM3-PhysFootprint"]["metrics"]["Allocations"]["Arithmetic"]["current"]
 
 def detectMotionMark(payload):
@@ -346 +363 @@
     if detectPLT5(payload):
         return PLT5
+    if detectPLUM3(payload):
+        return PLUM3
     if detectMotionMark(payload):
         return MotionMark
@@ -364 +383 @@
         return True
     if benchmarkType == PLT5:
+        return False
+    if benchmarkType == PLUM3:
         return False
 
@@ -479 +500 @@
         if args.csv:
             writeCSV(plt5Breakdown(a), plt5Breakdown(b), args.csv)
+    elif typeA == PLUM3:
+        if args.breakdown:
+            dumpBreakdowns(plum3Breakdown(a), plum3Breakdown(b))
+
+        ttest(typeA, PLUM3Results(a), PLUM3Results(b))
+
+        if args.csv:
+            writeCSV(plum3Breakdown(a), plum3Breakdown(b), args.csv)
     else:
         print("Unknown benchmark type")