Changeset 271282 in webkit

Timestamp:

Jan 7, 2021, 7:58:06 PM (6 years ago)

Author:

achristensen@apple.com

Message:

Remove assertions in MESSAGE_CHECK definition
​https://bugs.webkit.org/show_bug.cgi?id=220401

• Platform/IPC/Connection.h:

The unit test associated with r271263 hits these assertions in debug builds.
Since we plan to increase this type of unit testing, I remove the assertions.

Location:

trunk/Source/WebKit

Files:

• ChangeLog (modified) (1 diff)
• Platform/IPC/Connection.h (modified) (2 diffs)

trunk/Source/WebKit/ChangeLog

@@ +1 @@
+2021-01-07  Alex Christensen  <achristensen@webkit.org>
+
+        Remove assertions in MESSAGE_CHECK definition
+        https://bugs.webkit.org/show_bug.cgi?id=220401
+
+        * Platform/IPC/Connection.h:
+        The unit test associated with r271263 hits these assertions in debug builds.
+        Since we plan to increase this type of unit testing, I remove the assertions.
+
 2021-01-07  Mark Lam  <mark.lam@apple.com>
 

trunk/Source/WebKit/Platform/IPC/Connection.h

@@ -81 +81 @@
 
 #define MESSAGE_CHECK_COMPLETION_BASE(assertion, connection, completion) do { \
-    ASSERT(assertion); \
     if (UNLIKELY(!(assertion))) { \
         (connection)->markCurrentlyDispatchedMessageAsInvalid(); \
@@ -90 +89 @@
 
 #define MESSAGE_CHECK_WITH_RETURN_VALUE_BASE(assertion, connection, returnValue) do { \
-    ASSERT(assertion); \
     if (UNLIKELY(!(assertion))) { \
         (connection)->markCurrentlyDispatchedMessageAsInvalid(); \