Changeset 271410 in webkit

Timestamp:

Jan 12, 2021, 12:17:14 PM (6 years ago)

Author:

Patrick Angle

Message:

Web Inspector: Remove experimental setting and enable Font details sidebar
​https://bugs.webkit.org/show_bug.cgi?id=220438

Reviewed by Devin Rousso.

• Localizations/en.lproj/localizedStrings.js:
• UserInterface/Base/Setting.js:
• UserInterface/Views/ElementsTabContentView.js:

(WI.ElementsTabContentView):

• UserInterface/Views/SettingsTabContentView.js:

(WI.SettingsTabContentView.prototype._createExperimentalSettingsView):

Location:

trunk/Source/WebInspectorUI

Files:

• ChangeLog (modified) (1 diff)
• Localizations/en.lproj/localizedStrings.js (modified) (2 diffs)
• UserInterface/Base/Setting.js (modified) (1 diff)
• UserInterface/Views/ElementsTabContentView.js (modified) (1 diff)
• UserInterface/Views/SettingsTabContentView.js (modified) (2 diffs)

trunk/Source/WebInspectorUI/ChangeLog

@@ +1 @@
+2021-01-12  Patrick Angle  <pangle@apple.com>
+
+        Web Inspector: Remove experimental setting and enable Font details sidebar
+        https://bugs.webkit.org/show_bug.cgi?id=220438
+
+        Reviewed by Devin Rousso.
+
+        * Localizations/en.lproj/localizedStrings.js:
+        * UserInterface/Base/Setting.js:
+        * UserInterface/Views/ElementsTabContentView.js:
+        (WI.ElementsTabContentView):
+        * UserInterface/Views/SettingsTabContentView.js:
+        (WI.SettingsTabContentView.prototype._createExperimentalSettingsView):
+
 2021-01-11  Devin Rousso  <drousso@apple.com>
 

trunk/Source/WebInspectorUI/Localizations/en.lproj/localizedStrings.js

@@ -548 +548 @@
 /* Name of Elements Tab */
 localizedStrings["Elements Tab Name"] = "Elements";
-/* Category label for experimental settings pertaining to the Elements tab */
-localizedStrings["Elements Tab: @ Experimental Settings"] = "Elements Tab:";
 /* Checkbox shown in the Console to cause future evaluations as though they are in response to user interaction. */
 localizedStrings["Emulate User Gesture @ Console"] = "Emulate User Gesture";
@@ -1295 +1293 @@
 localizedStrings["Show Console tab"] = "Show Console tab";
 localizedStrings["Show Elements"] = "Show Elements";
-localizedStrings["Show Font details sidebar panel"] = "Show Font details sidebar panel";
 localizedStrings["Show Path"] = "Show Path";
 localizedStrings["Show Remaining (%d)"] = "Show Remaining (%d)";

trunk/Source/WebInspectorUI/UserInterface/Base/Setting.js

@@ -224 +224 @@
     experimentalEnableStylesJumpToEffective: new WI.Setting("experimental-styles-jump-to-effective", false),
     experimentalEnableStylesJumpToVariableDeclaration: new WI.Setting("experimental-styles-jump-to-variable-declaration", false),
-    experimentalEnableFontDetailsPanel: new WI.Setting("experimental-font-details-panel", false),
 
     // Protocol

trunk/Source/WebInspectorUI/UserInterface/Views/ElementsTabContentView.js

@@ -34 +34 @@
         ];
         // COMPATIBILITY (iOS 14.0): `CSS.getFontDataForNode` did not exist yet.
-        if (WI.settings.experimentalEnableFontDetailsPanel.value && InspectorBackend.hasCommand("CSS.getFontDataForNode"))
+        if (InspectorBackend.hasCommand("CSS.getFontDataForNode"))
             detailsSidebarPanelConstructors.push(WI.FontDetailsSidebarPanel);
         detailsSidebarPanelConstructors.push(WI.ChangesDetailsSidebarPanel, WI.DOMNodeDetailsSidebarPanel);

trunk/Source/WebInspectorUI/UserInterface/Views/SettingsTabContentView.js

@@ -403 +403 @@
         }
 
-        let elementsGroup = experimentalSettingsView.addGroup(WI.UIString("Elements Tab:", "Elements Tab: @ Experimental Settings", "Category label for experimental settings pertaining to the Elements tab"));
-        elementsGroup.addSetting(WI.settings.experimentalEnableFontDetailsPanel, WI.UIString("Show Font details sidebar panel"));
-        experimentalSettingsView.addSeparator();
-
         let reloadInspectorButton = document.createElement("button");
         reloadInspectorButton.textContent = WI.UIString("Reload Web Inspector");
@@ -429 +425 @@
             listenForChange(WI.settings.experimentalEnableStylesJumpToVariableDeclaration);
         }
-
-        listenForChange(WI.settings.experimentalEnableFontDetailsPanel);
 
         this._createReferenceLink(experimentalSettingsView);