Changeset 271415 in webkit

Timestamp:

Jan 12, 2021, 2:07:59 PM (6 years ago)

Author:

don.olmstead@sony.com

Message:

Non-unified build fixes mid January 2021 edition
​https://bugs.webkit.org/show_bug.cgi?id=220560

Unreviewed non-unified build fixes.

Source/JavaScriptCore:

• API/JSLockRef.cpp:
• runtime/JSCJSValue.cpp:
• runtime/JSGlobalObjectFunctions.cpp:

Source/WebCore:

• accessibility/AccessibilityObject.cpp:
• bindings/js/JSHTMLAllCollectionCustom.cpp:
• dom/DocumentStorageAccess.cpp:
• layout/inlineformatting/InlineContentBreaker.cpp:
• layout/inlineformatting/InlineFormattingContextQuirks.cpp:
• page/Quirks.h:
• platform/graphics/displaylists/DisplayListRecorder.cpp:

Source/WebKit:

• UIProcess/SpeechRecognitionPermissionManager.cpp:

(WebKit::SpeechRecognitionPermissionManager::~SpeechRecognitionPermissionManager):
(WebKit::SpeechRecognitionPermissionManager::request):
(WebKit::SpeechRecognitionPermissionManager::startProcessingRequest):
(WebKit::SpeechRecognitionPermissionManager::continueProcessingRequest):
(WebKit::SpeechRecognitionPermissionManager::completeCurrentRequest):
(WebKit::SpeechRecognitionPermissionManager::requestSpeechRecognitionServiceAccess):
(WebKit::SpeechRecognitionPermissionManager::requestMicrophoneAccess):
(WebKit::SpeechRecognitionPermissionManager::requestUserPermission):

Location:

trunk/Source

Files:

• JavaScriptCore/API/JSLockRef.cpp (modified) (1 diff)
• JavaScriptCore/ChangeLog (modified) (1 diff)
• JavaScriptCore/runtime/JSCJSValue.cpp (modified) (1 diff)
• JavaScriptCore/runtime/JSGlobalObjectFunctions.cpp (modified) (1 diff)
• WebCore/ChangeLog (modified) (1 diff)
• WebCore/accessibility/AccessibilityObject.cpp (modified) (1 diff)
• WebCore/bindings/js/JSHTMLAllCollectionCustom.cpp (modified) (1 diff)
• WebCore/dom/DocumentStorageAccess.cpp (modified) (1 diff)
• WebCore/layout/inlineformatting/InlineContentBreaker.cpp (modified) (1 diff)
• WebCore/layout/inlineformatting/InlineFormattingContextQuirks.cpp (modified) (1 diff)
• WebCore/page/Quirks.h (modified) (1 diff)
• WebCore/platform/graphics/displaylists/DisplayListRecorder.cpp (modified) (1 diff)
• WebKit/ChangeLog (modified) (1 diff)
• WebKit/UIProcess/SpeechRecognitionPermissionManager.cpp (modified) (11 diffs)

trunk/Source/JavaScriptCore/API/JSLockRef.cpp

@@ -27 +27 @@
 #include "JSLockRefPrivate.h"
 
+#include "APICast.h"
 #include "JSLock.h"
 

trunk/Source/JavaScriptCore/ChangeLog

@@ +1 @@
+2021-01-12  Don Olmstead  <don.olmstead@sony.com>
+
+        Non-unified build fixes mid January 2021 edition
+        https://bugs.webkit.org/show_bug.cgi?id=220560
+
+        Unreviewed non-unified build fixes.
+
+        * API/JSLockRef.cpp:
+        * runtime/JSCJSValue.cpp:
+        * runtime/JSGlobalObjectFunctions.cpp:
+
 2021-01-11  Devin Rousso  <drousso@apple.com>
 

trunk/Source/JavaScriptCore/runtime/JSCJSValue.cpp

@@ -31 +31 @@
 #include "JSCInlines.h"
 #include "NumberObject.h"
+#include "ParseInt.h"
 #include "TypeError.h"
 

trunk/Source/JavaScriptCore/runtime/JSGlobalObjectFunctions.cpp

@@ -35 +35 @@
 #include "JSModuleLoader.h"
 #include "JSPromise.h"
+#include "JSSet.h"
 #include "Lexer.h"
 #include "LiteralParser.h"

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2021-01-12  Don Olmstead  <don.olmstead@sony.com>
+
+        Non-unified build fixes mid January 2021 edition
+        https://bugs.webkit.org/show_bug.cgi?id=220560
+
+        Unreviewed non-unified build fixes.
+
+        * accessibility/AccessibilityObject.cpp:
+        * bindings/js/JSHTMLAllCollectionCustom.cpp:
+        * dom/DocumentStorageAccess.cpp:
+        * layout/inlineformatting/InlineContentBreaker.cpp:
+        * layout/inlineformatting/InlineFormattingContextQuirks.cpp:
+        * page/Quirks.h:
+        * platform/graphics/displaylists/DisplayListRecorder.cpp:
+
 2021-01-12  Wenson Hsieh  <wenson_hsieh@apple.com>
 

trunk/Source/WebCore/accessibility/AccessibilityObject.cpp

@@ -30 +30 @@
 #include "AccessibilityObject.h"
 
+#include "AXLogger.h"
 #include "AXObjectCache.h"
 #include "AccessibilityRenderObject.h"

trunk/Source/WebCore/bindings/js/JSHTMLAllCollectionCustom.cpp

@@ -32 +32 @@
 #include "JSDOMConvertNullable.h"
 #include "JSDOMConvertUnion.h"
+#include "JSElement.h"
+#include "JSHTMLCollection.h"
 
 namespace WebCore {

trunk/Source/WebCore/dom/DocumentStorageAccess.cpp

@@ -39 +39 @@
 #include "NetworkStorageSession.h"
 #include "Page.h"
+#include "Quirks.h"
 #include "RegistrableDomain.h"
 #include "SecurityOrigin.h"

trunk/Source/WebCore/layout/inlineformatting/InlineContentBreaker.cpp

@@ -33 +33 @@
 #include "InlineItem.h"
 #include "InlineTextItem.h"
+#include "LayoutContainerBox.h"
 #include "TextUtil.h"
 

trunk/Source/WebCore/layout/inlineformatting/InlineFormattingContextQuirks.cpp

@@ -28 +28 @@
 
 #if ENABLE(LAYOUT_FORMATTING_CONTEXT)
+
+#include "LayoutBoxGeometry.h"
 
 namespace WebCore {

trunk/Source/WebCore/page/Quirks.h

@@ -39 +39 @@
 class LayoutUnit;
 class PlatformMouseEvent;
+
+#if ENABLE(RESOURCE_LOAD_STATISTICS)
+class RegistrableDomain;
 enum class StorageAccessWasGranted : bool;
+#endif
 
 class Quirks {

trunk/Source/WebCore/platform/graphics/displaylists/DisplayListRecorder.cpp

@@ -33 +33 @@
 #include "ImageBuffer.h"
 #include "Logging.h"
+#include "MediaPlayer.h"
 #include <wtf/MathExtras.h>
 #include <wtf/text/TextStream.h>

trunk/Source/WebKit/ChangeLog

@@ +1 @@
+2021-01-12  Don Olmstead  <don.olmstead@sony.com>
+
+        Non-unified build fixes mid January 2021 edition
+        https://bugs.webkit.org/show_bug.cgi?id=220560
+
+        Unreviewed non-unified build fixes.
+
+        * UIProcess/SpeechRecognitionPermissionManager.cpp:
+        (WebKit::SpeechRecognitionPermissionManager::~SpeechRecognitionPermissionManager):
+        (WebKit::SpeechRecognitionPermissionManager::request):
+        (WebKit::SpeechRecognitionPermissionManager::startProcessingRequest):
+        (WebKit::SpeechRecognitionPermissionManager::continueProcessingRequest):
+        (WebKit::SpeechRecognitionPermissionManager::completeCurrentRequest):
+        (WebKit::SpeechRecognitionPermissionManager::requestSpeechRecognitionServiceAccess):
+        (WebKit::SpeechRecognitionPermissionManager::requestMicrophoneAccess):
+        (WebKit::SpeechRecognitionPermissionManager::requestUserPermission):
+
 2021-01-12  Wenson Hsieh  <wenson_hsieh@apple.com>
 

trunk/Source/WebKit/UIProcess/SpeechRecognitionPermissionManager.cpp

@@ -73 +73 @@
 {
     for (auto& request : m_requests)
-        request->complete(SpeechRecognitionError { SpeechRecognitionErrorType::NotAllowed, "Permission manager has exited"_s });
+        request->complete(WebCore::SpeechRecognitionError { WebCore::SpeechRecognitionErrorType::NotAllowed, "Permission manager has exited"_s });
 }
     
-void SpeechRecognitionPermissionManager::request(const String& lang, const WebCore::ClientOrigin& origin, CompletionHandler<void(Optional<SpeechRecognitionError>&&)>&& completiontHandler)
+void SpeechRecognitionPermissionManager::request(const String& lang, const WebCore::ClientOrigin& origin, CompletionHandler<void(Optional<WebCore::SpeechRecognitionError>&&)>&& completiontHandler)
 {
     m_requests.append(SpeechRecognitionPermissionRequest::create(lang, origin, WTFMove(completiontHandler)));
@@ -95 +95 @@
 #if PLATFORM(COOCA)
     if (!checkSandboxRequirementForType(MediaPermissionType::Audio)) {
-        completeCurrentRequest(SpeechRecognitionError { SpeechRecognitionErrorType::NotAllowed, "Sandbox check has failed"_s });
+        completeCurrentRequest(WebCore::SpeechRecognitionError { WebCore::SpeechRecognitionErrorType::NotAllowed, "Sandbox check has failed"_s });
         return;
     }
@@ -108 +108 @@
         m_microphoneCheck = computeMicrophoneAccess();
         if (m_microphoneCheck == CheckResult::Denied) {
-            completeCurrentRequest(SpeechRecognitionError { SpeechRecognitionErrorType::NotAllowed, "Microphone permission check has failed"_s });
+            completeCurrentRequest(WebCore::SpeechRecognitionError { WebCore::SpeechRecognitionErrorType::NotAllowed, "Microphone permission check has failed"_s });
             return;
         }
@@ -114 +114 @@
         m_speechRecognitionServiceCheck = computeSpeechRecognitionServiceAccess();
         if (m_speechRecognitionServiceCheck == CheckResult::Denied) {
-            completeCurrentRequest(SpeechRecognitionError { SpeechRecognitionErrorType::ServiceNotAllowed, "Speech recognition service permission check has failed"_s });
+            completeCurrentRequest(WebCore::SpeechRecognitionError { WebCore::SpeechRecognitionErrorType::ServiceNotAllowed, "Speech recognition service permission check has failed"_s });
             return;
         }
@@ -120 +120 @@
 #if HAVE(SPEECHRECOGNIZER)
         if (!checkSpeechRecognitionServiceAvailability(m_requests.first()->lang())) {
-            completeCurrentRequest(SpeechRecognitionError { SpeechRecognitionErrorType::ServiceNotAllowed, "Speech recognition service is not available"_s });
+            completeCurrentRequest(WebCore::SpeechRecognitionError { WebCore::SpeechRecognitionErrorType::ServiceNotAllowed, "Speech recognition service is not available"_s });
             return;
         }
@@ -136 +136 @@
 
     if (m_userPermissionCheck == CheckResult::Denied) {
-        completeCurrentRequest(SpeechRecognitionError { SpeechRecognitionErrorType::NotAllowed, "User permission check has failed"_s });
+        completeCurrentRequest(WebCore::SpeechRecognitionError { WebCore::SpeechRecognitionErrorType::NotAllowed, "User permission check has failed"_s });
         return;
     }
@@ -164 +164 @@
 
     if (!m_page.isViewVisible()) {
-        completeCurrentRequest(SpeechRecognitionError { SpeechRecognitionErrorType::NotAllowed, "Page is not visible to user" });
+        completeCurrentRequest(WebCore::SpeechRecognitionError { WebCore::SpeechRecognitionErrorType::NotAllowed, "Page is not visible to user" });
         return;
     }
@@ -171 +171 @@
 }
 
-void SpeechRecognitionPermissionManager::completeCurrentRequest(Optional<SpeechRecognitionError>&& error)
+void SpeechRecognitionPermissionManager::completeCurrentRequest(Optional<WebCore::SpeechRecognitionError>&& error)
 {
     ASSERT(!m_requests.isEmpty());
@@ -191 +191 @@
         m_speechRecognitionServiceCheck = authorized ? CheckResult::Granted : CheckResult::Denied;
         if (m_speechRecognitionServiceCheck == CheckResult::Denied) {
-            completeCurrentRequest(SpeechRecognitionError { SpeechRecognitionErrorType::ServiceNotAllowed, "Speech recognition service permission check has failed"_s });
+            completeCurrentRequest(WebCore::SpeechRecognitionError { WebCore::SpeechRecognitionErrorType::ServiceNotAllowed, "Speech recognition service permission check has failed"_s });
             return;
         }
@@ -211 +211 @@
         m_microphoneCheck = authorized ? CheckResult::Granted : CheckResult::Denied;
         if (m_microphoneCheck == CheckResult::Denied) {
-            completeCurrentRequest(SpeechRecognitionError { SpeechRecognitionErrorType::NotAllowed, "Microphone permission check has failed"_s });
+            completeCurrentRequest(WebCore::SpeechRecognitionError { WebCore::SpeechRecognitionErrorType::NotAllowed, "Microphone permission check has failed"_s });
             return;
         }
@@ -233 +233 @@
         m_userPermissionCheck = granted ? CheckResult::Granted : CheckResult::Denied;
         if (m_userPermissionCheck == CheckResult::Denied) {
-            completeCurrentRequest(SpeechRecognitionError { SpeechRecognitionErrorType::NotAllowed, "User permission check has failed"_s });
+            completeCurrentRequest(WebCore::SpeechRecognitionError { WebCore::SpeechRecognitionErrorType::NotAllowed, "User permission check has failed"_s });
             return;
         }