Changeset 271434 in webkit

Timestamp:

Jan 13, 2021, 1:50:12 AM (6 years ago)

Author:

youenn@apple.com

Message:

Use promise_test in WPT beacon/beacon-common.sub.js instead of async_test
​https://bugs.webkit.org/show_bug.cgi?id=220541
<rdar://problem/72940308>

Reviewed by Geoffrey Garen.

Use promise_test to limit the number of requests sent in parallel.
This helps the server responds properly.

• web-platform-tests/beacon/beacon-common.sub.js:

(runTests):

Location:

trunk/LayoutTests/imported/w3c

Files:

• ChangeLog (modified) (1 diff)
• web-platform-tests/beacon/beacon-common.sub.js (modified) (2 diffs)

trunk/LayoutTests/imported/w3c/ChangeLog

@@ +1 @@
+2021-01-13  Youenn Fablet  <youenn@apple.com>
+
+        Use promise_test in WPT beacon/beacon-common.sub.js instead of async_test
+        https://bugs.webkit.org/show_bug.cgi?id=220541
+        <rdar://problem/72940308>
+
+        Reviewed by Geoffrey Garen.
+
+        Use promise_test to limit the number of requests sent in parallel.
+        This helps the server responds properly.
+
+        * web-platform-tests/beacon/beacon-common.sub.js:
+        (runTests):
+
 2021-01-12  Cathie Chen  <cathiechen@igalia.com>
 

trunk/LayoutTests/imported/w3c/web-platform-tests/beacon/beacon-common.sub.js

@@ -99 +99 @@
 }
 
-// Schedules async_test's for each of the test cases, treating them as a single session,
-// and wires up the continueAfterSendingBeacon() and waitForResults() calls.
+// Schedules promise_test's for each of the test cases.
 // Parameters:
 //     testCases: An array of test cases.
@@ -109 +108 @@
     for (const testCase of testCases) {
         const id = token();
-        async_test((test) => {
+        promise_test((test) => {
             const url = buildUrl(id);
             assert_true(sendData(url, testCase.data), 'sendBeacon should succeed');
-            waitForResult(id).then(() => test.done(), test.step_func((e) => {throw e;}));
+            return waitForResult(id);
         }, `Verify 'navigator.sendbeacon()' successfully sends for variant: ${testCase.name}${suffix}`);
     };