Changeset 271437 in webkit

Timestamp:

Jan 13, 2021, 4:52:08 AM (6 years ago)

Author:

calvaris@igalia.com

Message:

[GStreamer][EME][Thunder] Bail out on failed response message for challenges
​https://bugs.webkit.org/show_bug.cgi?id=220583

Reviewed by Philippe Normand.

When parsing the challenge message, sometimes the message length
is 0 and parsing fails. This should not happen in principle and
that's why we just asserted on that but it looks like the
framework is not as careful as expected here. Hence we need to
bail out to not crash in release mode.

• platform/graphics/gstreamer/eme/CDMThunder.cpp:

(WebCore::CDMInstanceSessionThunder::challengeGeneratedCallback):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• platform/graphics/gstreamer/eme/CDMThunder.cpp (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2021-01-13  Xabier Rodriguez Calvar  <calvaris@igalia.com>
+
+        [GStreamer][EME][Thunder] Bail out on failed response message for challenges
+        https://bugs.webkit.org/show_bug.cgi?id=220583
+
+        Reviewed by Philippe Normand.
+
+        When parsing the challenge message, sometimes the message length
+        is 0 and parsing fails. This should not happen in principle and
+        that's why we just asserted on that but it looks like the
+        framework is not as careful as expected here. Hence we need to
+        bail out to not crash in release mode.
+
+        * platform/graphics/gstreamer/eme/CDMThunder.cpp:
+        (WebCore::CDMInstanceSessionThunder::challengeGeneratedCallback):
+
 2021-01-13  Sergio Villar Senin  <svillar@igalia.com>
 

trunk/Source/WebCore/platform/graphics/gstreamer/eme/CDMThunder.cpp

@@ -361 +361 @@
 {
     ParsedResponseMessage parsedResponseMessage(buffer);
-    ASSERT(parsedResponseMessage);
+    if (!parsedResponseMessage) {
+        GST_ERROR("response message parsing failed");
+        ASSERT_NOT_REACHED();
+        return;
+    }
 
     if (!m_challengeCallbacks.isEmpty()) {