Changeset 271448 in webkit

Timestamp:

Jan 13, 2021, 11:42:29 AM (6 years ago)

Author:

wilander@apple.com

Message:

PCM: Experimental debug mode needs to be read from defaults differently on iOS
​https://bugs.webkit.org/show_bug.cgi?id=220573
<rdar://problem/73092137>

Reviewed by Brent Fulgham.

Experimental features on iOS use the prefix "WebKitExperimental" so we
need to read it that way on that platform. PCM is not supported on other
platforms than macOS and iOS at this point.

• UIProcess/Cocoa/WebProcessPoolCocoa.mm:

(WebKit::WebProcessPool::platformInitializeNetworkProcess):

Location:

trunk/Source/WebKit

Files:

• ChangeLog (modified) (1 diff)
• UIProcess/Cocoa/WebProcessPoolCocoa.mm (modified) (1 diff)

trunk/Source/WebKit/ChangeLog

@@ +1 @@
+2021-01-13  John Wilander  <wilander@apple.com>
+
+        PCM: Experimental debug mode needs to be read from defaults differently on iOS
+        https://bugs.webkit.org/show_bug.cgi?id=220573
+        <rdar://problem/73092137>
+
+        Reviewed by Brent Fulgham.
+
+        Experimental features on iOS use the prefix "WebKitExperimental" so we
+        need to read it that way on that platform. PCM is not supported on other
+        platforms than macOS and iOS at this point.
+
+        * UIProcess/Cocoa/WebProcessPoolCocoa.mm:
+        (WebKit::WebProcessPool::platformInitializeNetworkProcess):
+
 2021-01-13  Megan Gardner  <megan_gardner@apple.com>
 

trunk/Source/WebKit/UIProcess/Cocoa/WebProcessPoolCocoa.mm

@@ -492 +492 @@
 
     parameters.enablePrivateClickMeasurement = ![defaults objectForKey:WebPreferencesKey::privateClickMeasurementEnabledKey()] || [defaults boolForKey:WebPreferencesKey::privateClickMeasurementEnabledKey()];
-    parameters.enablePrivateClickMeasurementDebugMode = [defaults boolForKey:[NSString stringWithFormat:@"Experimental%@", WebPreferencesKey::privateClickMeasurementDebugModeEnabledKey().createCFString().get()]];
+#if PLATFORM(MAC)
+    NSString *format = @"Experimental%@";
+#else
+    NSString *format = @"WebKitExperimental%@";
+#endif
+    parameters.enablePrivateClickMeasurementDebugMode = [defaults boolForKey:[NSString stringWithFormat:format, WebPreferencesKey::privateClickMeasurementDebugModeEnabledKey().createCFString().get()]];
 }