Changeset 271477 in webkit

Timestamp:

Jan 13, 2021, 5:37:59 PM (6 years ago)

Author:

Chris Dumez

Message:

REGRESSION(r270961): Flipgrid can no longer capture video
​https://bugs.webkit.org/show_bug.cgi?id=220609
<rdar://73168009>

Reviewed by Darin Adler.

Add back line in RemoteAudio::setStorage() that was initializing m_buffer and that was
dropped by mistake in the refactoring in r270961. This was causing
RemoteCaptureSampleManager::RemoteAudio::audioSamplesAvailable() to return early because
m_buffer was not initialized.

No new tests, unsure how to test this.

• WebProcess/cocoa/RemoteCaptureSampleManager.cpp:

(WebKit::RemoteCaptureSampleManager::RemoteAudio::setStorage):

Location:

trunk/Source/WebKit

Files:

• ChangeLog (modified) (1 diff)
• WebProcess/cocoa/RemoteCaptureSampleManager.cpp (modified) (1 diff)

trunk/Source/WebKit/ChangeLog

@@ +1 @@
+2021-01-13  Chris Dumez  <cdumez@apple.com>
+
+        REGRESSION(r270961): Flipgrid can no longer capture video
+        https://bugs.webkit.org/show_bug.cgi?id=220609
+        <rdar://73168009>
+
+        Reviewed by Darin Adler.
+
+        Add back line in RemoteAudio::setStorage() that was initializing m_buffer and that was
+        dropped by mistake in the refactoring in r270961. This was causing
+        RemoteCaptureSampleManager::RemoteAudio::audioSamplesAvailable() to return early because
+        m_buffer was not initialized.
+
+        No new tests, unsure how to test this.
+
+        * WebProcess/cocoa/RemoteCaptureSampleManager.cpp:
+        (WebKit::RemoteCaptureSampleManager::RemoteAudio::setStorage):
+
 2021-01-13  John Wilander  <wilander@apple.com>
 

trunk/Source/WebKit/WebProcess/cocoa/RemoteCaptureSampleManager.cpp

@@ -122 +122 @@
     m_description = description;
     m_ringBuffer = makeUnique<CARingBuffer>(makeUniqueRef<ReadOnlySharedRingBufferStorage>(handle), description, numberOfFrames);
+    m_buffer = makeUnique<WebAudioBufferList>(description, numberOfFrames);
 }