Changeset 271487 in webkit

Timestamp:

Jan 14, 2021, 9:17:47 AM (6 years ago)

Author:

youenn@apple.com

Message:

Use AVAudioSessionModeDefault in AVAudioSessionCaptureDeviceManager::createAudioSession
​https://bugs.webkit.org/show_bug.cgi?id=220618
<rdar://problem/73185920>

Reviewed by Eric Carlson.

Manually tested.

• platform/mediastream/ios/AVAudioSessionCaptureDeviceManager.mm:

(WebCore::AVAudioSessionCaptureDeviceManager::createAudioSession):
AVAudioSessionModeDefault is less disruptive than video chat mode.
In particular, if the page is playing audio, the potential audio level bump when activating
this session will be largely less noticeable.

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• platform/mediastream/ios/AVAudioSessionCaptureDeviceManager.mm (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2021-01-14  Youenn Fablet  <youenn@apple.com>
+
+        Use AVAudioSessionModeDefault in AVAudioSessionCaptureDeviceManager::createAudioSession
+        https://bugs.webkit.org/show_bug.cgi?id=220618
+        <rdar://problem/73185920>
+
+        Reviewed by Eric Carlson.
+
+        Manually tested.
+
+        * platform/mediastream/ios/AVAudioSessionCaptureDeviceManager.mm:
+        (WebCore::AVAudioSessionCaptureDeviceManager::createAudioSession):
+        AVAudioSessionModeDefault is less disruptive than video chat mode.
+        In particular, if the page is playing audio, the potential audio level bump when activating
+        this session will be largely less noticeable.
+
 2021-01-14  Zalan Bujtas  <zalan@apple.com>
 

trunk/Source/WebCore/platform/mediastream/ios/AVAudioSessionCaptureDeviceManager.mm

@@ -108 +108 @@
     NSError *error = nil;
     auto options = AVAudioSessionCategoryOptionAllowBluetooth | AVAudioSessionCategoryOptionMixWithOthers;
-    [m_audioSession setCategory:AVAudioSessionCategoryPlayAndRecord mode:AVAudioSessionModeVideoChat options:options error:&error];
-    if (error)
-        RELEASE_LOG_ERROR(WebRTC, "Failed to set audio session category with error: %@.", error.localizedDescription);
+    [m_audioSession setCategory:AVAudioSessionCategoryPlayAndRecord mode:AVAudioSessionModeDefault options:options error:&error];
+    RELEASE_LOG_ERROR_IF(error, WebRTC, "Failed to set audio session category with error: %@.", error.localizedDescription);
 }