Changeset 271490 in webkit

Timestamp:

Jan 14, 2021, 10:12:42 AM (6 years ago)

Author:

sbarati@apple.com

Message:

SpeculativeJIT::compileGetEnumerableLength should not use GPRFlushedCallResult
​https://bugs.webkit.org/show_bug.cgi?id=220557

Reviewed by Yusuke Suzuki.

It wasn't used as the result from a call, so we're overly restricting the
register we allocate for no good reason.

• dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::compileGetEnumerableLength):

Location:

trunk/Source/JavaScriptCore

Files:

• ChangeLog (modified) (1 diff)
• dfg/DFGSpeculativeJIT.cpp (modified) (1 diff)

trunk/Source/JavaScriptCore/ChangeLog

@@ +1 @@
+2021-01-14  Saam Barati  <sbarati@apple.com>
+
+        SpeculativeJIT::compileGetEnumerableLength should not use GPRFlushedCallResult
+        https://bugs.webkit.org/show_bug.cgi?id=220557
+
+        Reviewed by Yusuke Suzuki.
+
+        It wasn't used as the result from a call, so we're overly restricting the
+        register we allocate for no good reason. 
+
+        * dfg/DFGSpeculativeJIT.cpp:
+        (JSC::DFG::SpeculativeJIT::compileGetEnumerableLength):
+
 2021-01-14  Saam Barati  <sbarati@apple.com>
 

trunk/Source/JavaScriptCore/dfg/DFGSpeculativeJIT.cpp

@@ -12834 +12834 @@
 {
     SpeculateCellOperand enumerator(this, node->child1());
-    GPRFlushedCallResult result(this);
+    GPRTemporary result(this, Reuse, enumerator);
+    GPRReg enumeratorGPR = enumerator.gpr();
     GPRReg resultGPR = result.gpr();
 
-    m_jit.load32(MacroAssembler::Address(enumerator.gpr(), JSPropertyNameEnumerator::indexedLengthOffset()), resultGPR);
+    m_jit.load32(MacroAssembler::Address(enumeratorGPR, JSPropertyNameEnumerator::indexedLengthOffset()), resultGPR);
     strictInt32Result(resultGPR, node);
 }