Changeset 27155 in webkit


Ignore:
Timestamp:
Oct 27, 2007 4:25:24 PM (17 years ago)
Author:
mitz
Message:

WebCore:

Reviewed by Darin Adler.

  • fix a crash when opening Zenoss server history view <rdar://problem/5530657>

Test: fast/table/colgroup-relative.html

  • rendering/LayoutState.cpp: (WebCore::LayoutState::LayoutState): Added a hasLayer() check before accessing layer().

LayoutTests:

Reviewed by Darin Adler.

  • test for <rdar://problem/5530657>
  • fast/table/colgroup-relative-expected.txt: Added.
  • fast/table/colgroup-relative.html: Added.
Location:
trunk
Files:
2 added
3 edited

Legend:

Unmodified
Added
Removed

  • trunk/LayoutTests/ChangeLog

    r27151 r27155  
     12007-10-27  Dan Bernstein  <mitz@apple.com>
     2
     3        Reviewed by Darin Adler.
     4
     5        - test for <rdar://problem/5530657>
     6
     7        * fast/table/colgroup-relative-expected.txt: Added.
     8        * fast/table/colgroup-relative.html: Added.
     9
    1102007-10-27  Julien  <julien.chaffraix@gmail.com>
    211
    … …  
    11301139        Modified to create isSuccessfullyParsed() function.
    11311140
    1132 2007-10-18  Dan Bernstein  <dan.bernstein@apple.com>
     11412007-10-18  Dan Bernstein  <mitz@apple.com>
    11331142
    11341143        Rubber-stamped by Mark Rowe.
    … …  
    11531162        * platform/mac/editing/execCommand/5432254-2-expected.txt:
    11541163
    1155 2007-10-18  Dan Bernstein  <dan.bernstein@apple.com>
     11642007-10-18  Dan Bernstein  <mitz@apple.com>
    11561165
    11571166        Reviewed by Adam Roben.
    … …  
    11701179        * fast/dom/Window/alert-undefined-expected.txt: Back to expecting empty string for default value.
    11711180
    1172 2007-10-18  Dan Bernstein  <dan.bernstein@apple.com>
     11812007-10-18  Dan Bernstein  <mitz@apple.com>
    11731182
    11741183        Reviewed by Nikolas Zimmermann.

  • trunk/WebCore/ChangeLog

    r27151 r27155  
     12007-10-27  Dan Bernstein  <mitz@apple.com>
     2
     3        Reviewed by Darin Adler.
     4
     5        - fix a crash when opening Zenoss server history view
     6          <rdar://problem/5530657>
     7
     8        Test: fast/table/colgroup-relative.html
     9
     10        * rendering/LayoutState.cpp:
     11        (WebCore::LayoutState::LayoutState): Added a hasLayer() check before
     12        accessing layer().
     13
    1142007-10-27  Julien  <julien.chaffraix@gmail.com>
    215
    … …  
    26312644        was emitted.
    26322645
    2633 2007-10-18  Dan Bernstein  <dan.bernstein@apple.com>
     26462007-10-18  Dan Bernstein  <mitz@apple.com>
    26342647
    26352648        Reviewed by Adam Roben.
    … …  
    27092722        * platform/graphics/svg/cg/SVGPaintServerGradientCg.cpp:
    27102723
    2711 2007-10-18  Dan Bernstein  <dan.bernstein@apple.com>
     27242007-10-18  Dan Bernstein  <mitz@apple.com>
    27122725
    27132726        Reviewed by Nikolas Zimmermann.

  • trunk/WebCore/rendering/LayoutState.cpp

    r21183 r27155  
    4949
    5050    if (renderer->isRelPositioned()) {
    51         int relX = 0;
    52         int relY = 0;
    53         renderer->layer()->relativePositionOffset(relX, relY);
    54         m_offset += IntSize(relX, relY);
     51        if (renderer->hasLayer()) {
     52            int relX = 0;
     53            int relY = 0;
     54            renderer->layer()->relativePositionOffset(relX, relY);
     55            m_offset += IntSize(relX, relY);
     56        }
    5557    } else if (renderer->isPositioned() && !fixed) {
    5658        if (RenderObject* container = renderer->container())
Note: See TracChangeset for help on using the changeset viewer.