Changeset 27171 in webkit

Timestamp:

Oct 27, 2007, 11:45:10 PM (18 years ago)

Author:

timothy@apple.com

Message:

Reviewed by Adam.

Bug 15727: Resizing the resource sidebar doesn't scale the font preview or network timeline
​http://bugs.webkit.org/show_bug.cgi?id=15727

Add one window resize listener and call the new resize function on the currentPanel.
Also call the currentPanel's resize function when resizing the sidebar.

• page/inspector/DocumentPanel.js: Implement resize and call updateTreeSelection() when the panel is shown and when resizing the DOM sidebar.
• page/inspector/FontPanel.js: Implement resize.
• page/inspector/NetworkPanel.js: Ditto.
• page/inspector/inspector.js: Add a window resize listener.

Location:

trunk/WebCore

Files:

• ChangeLog (modified) (1 diff)
• WebCore.xcodeproj/project.pbxproj (modified) (1 diff)
• page/inspector/DocumentPanel.js (modified) (3 diffs)
• page/inspector/FontPanel.js (modified) (2 diffs)
• page/inspector/NetworkPanel.js (modified) (2 diffs)
• page/inspector/inspector.js (modified) (4 diffs)

trunk/WebCore/ChangeLog

@@ +1 @@
+2007-10-27  Timothy Hatcher  <timothy@apple.com>
+
+        Reviewed by Adam.
+
+        Bug 15727: Resizing the resource sidebar doesn't scale the font preview or network timeline
+        http://bugs.webkit.org/show_bug.cgi?id=15727
+
+        Add one window resize listener and call the new resize function on the currentPanel.
+        Also call the currentPanel's resize function when resizing the sidebar.
+
+        * page/inspector/DocumentPanel.js: Implement resize and call updateTreeSelection() when
+          the panel is shown and when resizing the DOM sidebar.
+        * page/inspector/FontPanel.js: Implement resize.
+        * page/inspector/NetworkPanel.js: Ditto.
+        * page/inspector/inspector.js: Add a window resize listener.
+
 2007-10-27  Maciej Stachowiak  <mjs@apple.com>
 

trunk/WebCore/WebCore.xcodeproj/project.pbxproj

@@ -13662 +13662 @@
                         isa = PBXProject;
                         buildConfigurationList = 149C284308902B11008A9EFC /* Build configuration list for PBXProject "WebCore" */;
+                        compatibilityVersion = "Xcode 2.4";
                         hasScannedForEncodings = 1;
                         knownRegions = (

trunk/WebCore/page/inspector/DocumentPanel.js

@@ -49 +49 @@
     domView.treeOutline.panel = this;
 
-    var panel = this;
-    window.addEventListener("resize", function() { panel.updateTreeSelection() }, false);
-
     domView.crumbsElement = document.createElement("div");
     domView.crumbsElement.className = "crumbs";
@@ -93 +90 @@
 
 WebInspector.DocumentPanel.prototype = {
+    show: function()
+    {
+        WebInspector.SourcePanel.prototype.show.call(this);
+        this.updateTreeSelection();
+    },
+
+    resize: function()
+    {
+        this.updateTreeSelection();
+    },
+
     updateTreeSelection: function()
     {
@@ -704 +712 @@
             this.views.dom.sideContentElement.style.right = newWidth + "px";
             this.views.dom.sidebarResizeElement.style.right = (newWidth - 3) + "px";
+
+            this.updateTreeSelection();
+
             event.preventDefault();
         }

trunk/WebCore/page/inspector/FontPanel.js

@@ -43 +43 @@
 
     this.updateFontPreviewSize();
-
-    var panel = this;
-    var resizeListener = function() {
-        panel.updateFontPreviewSize();
-    };
-
-    window.addEventListener("resize", resizeListener, false);
 }
 
@@ -56 +49 @@
     {
         WebInspector.ResourcePanel.prototype.show.call(this);
+        this.updateFontPreviewSize();
+    },
+
+    resize: function()
+    {
         this.updateFontPreviewSize();
     },

trunk/WebCore/page/inspector/NetworkPanel.js

@@ -89 +89 @@
     graphSideElement.appendChild(this.legendElement);
 
-    var networkPanel = this;
-    window.addEventListener("resize", function() { networkPanel.updateTimelineDividersIfNeeded() }, false);
-
     this.drawSummaryGraph(); // draws an empty graph
 
@@ -109 +106 @@
         WebInspector.Panel.prototype.hide.call(this);
         WebInspector.networkListItem.deselect();
+    },
+
+    resize: function()
+    {
+        this.updateTimelineDividersIfNeeded();
     },
 

trunk/WebCore/page/inspector/inspector.js

@@ -237 +237 @@
 
     window.addEventListener("unload", function(event) { WebInspector.windowUnload(event) }, true);
+    window.addEventListener("resize", function(event) { WebInspector.windowResize(event) }, true);
+
     document.addEventListener("mousedown", function(event) { WebInspector.changeFocus(event) }, true);
     document.addEventListener("focus", function(event) { WebInspector.changeFocus(event) }, true);
@@ -267 +269 @@
 {
     InspectorController.windowUnloading();
+}
+
+WebInspector.windowResize = function(event)
+{
+    if (this.currentPanel && this.currentPanel.resize)
+        this.currentPanel.resize();
 }
 
@@ -462 +470 @@
     var sidebar = document.getElementById("sidebar");
     if (sidebar.dragging == true) {
-
         var x = event.clientX + window.scrollX;
 
@@ -478 +485 @@
         document.getElementById("searchResults").style.left = newWidth + "px";
         document.getElementById("searchResultsResizer").style.left = newWidth + "px";
+
+        if (WebInspector.currentPanel && WebInspector.currentPanel.resize)
+            WebInspector.currentPanel.resize();
+
         event.preventDefault();
     }