Changeset 272507 in webkit

Timestamp:

Feb 8, 2021 12:22:23 PM (3 years ago)

Author:

youenn@apple.com

Message:

[MacOS] Enable Audio Capture in GPUProcess by default
​https://bugs.webkit.org/show_bug.cgi?id=221400

Reviewed by Eric Carlson.

Source/WebKit:

Manually tested.

• Shared/WebPreferencesDefaultValues.cpp:

(WebKit::defaultCaptureAudioInGPUProcessEnabled):

Tools:

• TestWebKitAPI/Tests/WebKit/GetUserMediaReprompt.mm:

(-[GetUserMediaRepromptTestView haveStream:]):
Increase timeout since capture might require spinning GPUProcess.

Location:

trunk

Files:

• Source/WebKit/ChangeLog (modified) (1 diff)
• Source/WebKit/Shared/WebPreferencesDefaultValues.cpp (modified) (1 diff)
• Tools/ChangeLog (modified) (1 diff)
• Tools/TestWebKitAPI/Tests/WebKit/GetUserMediaReprompt.mm (modified) (1 diff)

trunk/Source/WebKit/ChangeLog

@@ +1 @@
+2021-02-08  Youenn Fablet  <youenn@apple.com>
+
+        [MacOS] Enable Audio Capture in GPUProcess by default
+        https://bugs.webkit.org/show_bug.cgi?id=221400
+
+        Reviewed by Eric Carlson.
+
+        Manually tested.
+
+        * Shared/WebPreferencesDefaultValues.cpp:
+        (WebKit::defaultCaptureAudioInGPUProcessEnabled):
+
 2021-02-08  David Kilzer  <ddkilzer@apple.com>
 

trunk/Source/WebKit/Shared/WebPreferencesDefaultValues.cpp

@@ -184 +184 @@
 bool defaultCaptureAudioInGPUProcessEnabled()
 {
-#if HAVE(SYSTEM_FEATURE_FLAGS)
-#if PLATFORM(MAC)
-    return isFeatureFlagEnabled("gpu_process_webrtc");
-#elif PLATFORM(IOS_FAMILY)
+#if PLATFORM(MAC)
+    return true;
+#elif HAVE(SYSTEM_FEATURE_FLAGS)
     return isFeatureFlagEnabled("gpu_process_media");
-#endif
-#endif
-
-    return false;
+#else
+    return false;
+#endif
 }
 

trunk/Tools/ChangeLog

@@ +1 @@
+2021-02-08  Youenn Fablet  <youenn@apple.com>
+
+        [MacOS] Enable Audio Capture in GPUProcess by default
+        https://bugs.webkit.org/show_bug.cgi?id=221400
+
+        Reviewed by Eric Carlson.
+
+        * TestWebKitAPI/Tests/WebKit/GetUserMediaReprompt.mm:
+        (-[GetUserMediaRepromptTestView haveStream:]):
+        Increase timeout since capture might require spinning GPUProcess.
+
 2021-02-08  Youenn Fablet  <youenn@apple.com>
 

trunk/Tools/TestWebKitAPI/Tests/WebKit/GetUserMediaReprompt.mm

@@ -86 +86 @@
 - (BOOL)haveStream:(BOOL)expected
 {
-    int retryCount = 10;
+    int retryCount = 1000;
     while (retryCount--) {
         auto result = [self stringByEvaluatingJavaScript:@"haveStream()"];