Changeset 27251 in webkit


Ignore:
Timestamp:
Oct 29, 2007 7:56:18 PM (17 years ago)
Author:
mitz
Message:

WebCore:

Reviewed by Adam Roben.

Test: fast/backgrounds/size/zero.html

  • platform/graphics/cg/ImageCG.cpp: (WebCore::Image::drawPattern): Added an ASSERT and an early return to guard against singular pattern transforms.
  • rendering/RenderBox.cpp: (WebCore::cacluateBackgroundSize): Changed to ensure a minimum tile size of 1x1.

LayoutTests:

Reviewed by Adam Roben.

  • fast/backgrounds/size/zero.html: Added.
  • platform/mac/fast/backgrounds/size/zero-expected.checksum: Added.
  • platform/mac/fast/backgrounds/size/zero-expected.png: Added.
  • platform/mac/fast/backgrounds/size/zero-expected.txt: Added.
Location:
trunk
Files:
5 added
4 edited

Legend:

Unmodified
Added
Removed

  • trunk/LayoutTests/ChangeLog

    r27239 r27251  
     12007-10-29  Dan Bernstein  <mitz@apple.com>
     2
     3        Reviewed by Adam Roben.
     4
     5        - test for http://bugs.webkit.org/show_bug.cgi?id=15750
     6          REGRESSION(r27173): Web Inspector freezes beneath Image::drawPattern()
     7
     8        * fast/backgrounds/size/zero.html: Added.
     9        * platform/mac/fast/backgrounds/size/zero-expected.checksum: Added.
     10        * platform/mac/fast/backgrounds/size/zero-expected.png: Added.
     11        * platform/mac/fast/backgrounds/size/zero-expected.txt: Added.
     12
    1132007-10-29  Sam Weinig  <sam@webkit.org>
    214

  • trunk/WebCore/ChangeLog

    r27245 r27251  
     12007-10-29  Dan Bernstein  <mitz@apple.com>
     2
     3        Reviewed by Adam Roben.
     4
     5        - fix http://bugs.webkit.org/show_bug.cgi?id=15750
     6          REGRESSION(r27173): Web Inspector freezes beneath Image::drawPattern()
     7
     8        Test: fast/backgrounds/size/zero.html
     9
     10        * platform/graphics/cg/ImageCG.cpp:
     11        (WebCore::Image::drawPattern): Added an ASSERT and an early return
     12        to guard against singular pattern transforms.
     13        * rendering/RenderBox.cpp:
     14        (WebCore::cacluateBackgroundSize): Changed to ensure a minimum tile
     15        size of 1x1.
     16
    1172007-10-29  Alp Toker  <alp@atoker.com>
    218

  • trunk/WebCore/platform/graphics/cg/ImageCG.cpp

    r27150 r27251  
    181181                        const FloatPoint& phase, CompositeOperator op, const FloatRect& destRect)
    182182{
     183    ASSERT(patternTransform.isInvertible());
     184    if (!patternTransform.isInvertible())
     185        // Avoid a hang under CGContextDrawTiledImage on release builds.
     186        return;
     187
    183188    CGContextRef context = ctxt->platformContext();
    184189    ctxt->save();

  • trunk/WebCore/rendering/RenderBox.cpp

    r27228 r27251  
    465465            }
    466466        }
     467        scaledWidth = max(1, scaledWidth);
     468        scaledHeight = max(1, scaledHeight);
    467469    } else {
    468470        scaledWidth = bg->imageSize().width();
Note: See TracChangeset for help on using the changeset viewer.