Changeset 272686 in webkit

Timestamp:

Feb 10, 2021 2:35:59 PM (3 years ago)

Author:

Ryan Haddad

Message:

Unreviewed, reverting r272507.

Caused TestWebKitAPI.WebKit.OnDeviceChangeCrash to become a
flaky timeout

Reverted changeset:

"[MacOS] Enable Audio Capture in GPUProcess by default"
​https://bugs.webkit.org/show_bug.cgi?id=221400
​https://trac.webkit.org/changeset/272507

Location:

trunk

Files:

• Source/WebKit/ChangeLog (modified) (1 diff)
• Source/WebKit/Shared/WebPreferencesDefaultValues.cpp (modified) (1 diff)
• Tools/ChangeLog (modified) (1 diff)
• Tools/TestWebKitAPI/Tests/WebKit/GetUserMediaReprompt.mm (modified) (1 diff)

trunk/Source/WebKit/ChangeLog

@@ +1 @@
+2021-02-10  Ryan Haddad  <ryanhaddad@apple.com>
+
+        Unreviewed, reverting r272507.
+
+        Caused TestWebKitAPI.WebKit.OnDeviceChangeCrash to become a
+        flaky timeout
+
+        Reverted changeset:
+
+        "[MacOS] Enable Audio Capture in GPUProcess by default"
+        https://bugs.webkit.org/show_bug.cgi?id=221400
+        https://trac.webkit.org/changeset/272507
+
 2021-02-10  BJ Burg  <bburg@apple.com>
 

trunk/Source/WebKit/Shared/WebPreferencesDefaultValues.cpp

@@ -184 +184 @@
 bool defaultCaptureAudioInGPUProcessEnabled()
 {
-#if PLATFORM(MAC)
-    return true;
-#elif HAVE(SYSTEM_FEATURE_FLAGS)
+#if HAVE(SYSTEM_FEATURE_FLAGS)
+#if PLATFORM(MAC)
+    return isFeatureFlagEnabled("gpu_process_webrtc");
+#elif PLATFORM(IOS_FAMILY)
     return isFeatureFlagEnabled("gpu_process_media");
-#else
-    return false;
-#endif
+#endif
+#endif
+
+    return false;
 }
 

trunk/Tools/ChangeLog

@@ +1 @@
+2021-02-10  Ryan Haddad  <ryanhaddad@apple.com>
+
+        Unreviewed, reverting r272507.
+
+        Caused TestWebKitAPI.WebKit.OnDeviceChangeCrash to become a
+        flaky timeout
+
+        Reverted changeset:
+
+        "[MacOS] Enable Audio Capture in GPUProcess by default"
+        https://bugs.webkit.org/show_bug.cgi?id=221400
+        https://trac.webkit.org/changeset/272507
+
 2021-02-10  Aakash Jain  <aakash_jain@apple.com>
 

trunk/Tools/TestWebKitAPI/Tests/WebKit/GetUserMediaReprompt.mm

@@ -86 +86 @@
 - (BOOL)haveStream:(BOOL)expected
 {
-    int retryCount = 1000;
+    int retryCount = 10;
     while (retryCount--) {
         auto result = [self stringByEvaluatingJavaScript:@"haveStream()"];