Changeset 273304 in webkit

Timestamp:

Feb 23, 2021, 5:58:35 AM (6 years ago)

Author:

pvollan@apple.com

Message:

[macOS] Crash under AuxiliaryProcess::initializeSandbox
​https://bugs.webkit.org/show_bug.cgi?id=222233

Unreviewed, address additional review feedback.

Add comment and logging when the WebKit client is setting the user directory suffix.

• Shared/mac/AuxiliaryProcessMac.mm:

(WebKit::initializeSandboxParameters):

Location:

trunk/Source/WebKit

Files:

• ChangeLog (modified) (1 diff)
• Shared/mac/AuxiliaryProcessMac.mm (modified) (1 diff)

trunk/Source/WebKit/ChangeLog

@@ +1 @@
+2021-02-23  Per Arne Vollan  <pvollan@apple.com>
+
+        [macOS] Crash under AuxiliaryProcess::initializeSandbox
+        https://bugs.webkit.org/show_bug.cgi?id=222233
+
+        Unreviewed, address additional review feedback.
+
+        Add comment and logging when the WebKit client is setting the user directory suffix.
+
+        * Shared/mac/AuxiliaryProcessMac.mm:
+        (WebKit::initializeSandboxParameters):
+
 2021-02-23  Kimmo Kinnunen  <kkinnunen@apple.com>
 

trunk/Source/WebKit/Shared/mac/AuxiliaryProcessMac.mm

@@ -642 +642 @@
         if (userDirectorySuffix != parameters.extraInitializationData.end()) {
             String suffix = userDirectorySuffix->value;
+            WTFLogAlways("WebKit client is requesting user directory suffix: %s", suffix.utf8().data());
+            // Make sure the user directory suffix is not a path, since confstr will fail when the path does not exist.
             auto firstPathSeparator = suffix.find("/");
-            if (firstPathSeparator != notFound)
+            if (firstPathSeparator != notFound) {
                 suffix.truncate(firstPathSeparator);
+                WTFLogAlways("User directory suffix is a path, which will be truncated: %s", suffix.utf8().data());
+            }
             sandboxParameters.setUserDirectorySuffix(suffix);
         } else {