Changeset 273307 in webkit

Timestamp:

Feb 23, 2021, 8:18:08 AM (6 years ago)

Author:

commit-queue@webkit.org

Message:

Detect unrecognized options in run-javascriptcore-tests
​https://bugs.webkit.org/show_bug.cgi?id=221186

Patch by Angelos Oikonomopoulos <Angelos Oikonomopoulos> on 2021-02-23
Reviewed by Keith Miller.

run-javascriptcore-tests saves unrecognized arguments to pass
through to build-jsc even when --no-build is used. However, when
we're not building, nothing will ever use or look at the extra
arguments. This means that those arguments are silently eaten
up and, consequently, typos in option names can go undetected.

Change the script to fail when --no-build has been passed and
there are unrecognized options.

• Scripts/run-javascriptcore-tests:

Location:

trunk/Tools

Files:

• ChangeLog (modified) (1 diff)
• Scripts/run-javascriptcore-tests (modified) (1 diff)

trunk/Tools/ChangeLog

@@ +1 @@
+2021-02-23  Angelos Oikonomopoulos  <angelos@igalia.com>
+
+        Detect unrecognized options in run-javascriptcore-tests
+        https://bugs.webkit.org/show_bug.cgi?id=221186
+
+        Reviewed by Keith Miller.
+
+        run-javascriptcore-tests saves unrecognized arguments to pass
+        through to build-jsc even when --no-build is used. However, when
+        we're not building, nothing will ever use or look at the extra
+        arguments. This means that those arguments are silently eaten
+        up and, consequently, typos in option names can go undetected.
+
+        Change the script to fail when --no-build has been passed and
+        there are unrecognized options.
+
+        * Scripts/run-javascriptcore-tests:
+
 2021-02-23  Frederic Wang  <fwang@igalia.com>
 

trunk/Tools/Scripts/run-javascriptcore-tests

@@ -485 +485 @@
 $runMozillaTests = enableTestOrNot($runMozillaTests);
 
-# Assume any arguments left over from GetOptions are assumed to be build arguments
-my @buildArgs = @ARGV;
+my @buildArgs;
+
+if ($buildJSC) {
+    # Assume any arguments left over from GetOptions are to be passed as build arguments.
+    @buildArgs = @ARGV;
+} elsif (scalar(@ARGV) > 0) {
+    foreach (@ARGV) {
+        my $arg = $_;
+        if ($arg =~ /^-.*/) {
+            print STDERR "Unrecognized option `$arg'\n";
+        } else {
+            print STDERR "Stray anonymous argument `$arg'\n";
+        }
+    }
+    exit 2;
+}
 
 if ($showHelp) {