Changeset 273442 in webkit

Timestamp:

Feb 24, 2021, 3:02:00 PM (6 years ago)

Author:

Chris Dumez

Message:

Regression(r269481) Kugou Music: Can not leave "MV" category after selecting it
​https://bugs.webkit.org/show_bug.cgi?id=222380
<rdar://74602294>

Reviewed by Geoffrey Garen.

The new behavior in r269481 aligns us with the specification and with Blink so I
am adding a linked-on-after to maintain pre-r269481 behavior until Apps get
rebuilt against the new SDK.

• html/HTMLDocument.cpp:

(WebCore::HTMLDocument::supportedPropertyNames const):

• page/Quirks.cpp:

(WebCore::Quirks::shouldOmitHTMLDocumentSupportedPropertyNames):

• page/Quirks.h:
• platform/cocoa/VersionChecks.h:

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• html/HTMLDocument.cpp (modified) (2 diffs)
• page/Quirks.cpp (modified) (1 diff)
• page/Quirks.h (modified) (1 diff)
• platform/cocoa/VersionChecks.h (modified) (2 diffs)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2021-02-24  Chris Dumez  <cdumez@apple.com>
+
+        Regression(r269481) Kugou Music: Can not leave "MV" category after selecting it
+        https://bugs.webkit.org/show_bug.cgi?id=222380
+        <rdar://74602294>
+
+        Reviewed by Geoffrey Garen.
+
+        The new behavior in r269481 aligns us with the specification and with Blink so I
+        am adding a linked-on-after to maintain pre-r269481 behavior until Apps get
+        rebuilt against the new SDK.
+
+        * html/HTMLDocument.cpp:
+        (WebCore::HTMLDocument::supportedPropertyNames const):
+        * page/Quirks.cpp:
+        (WebCore::Quirks::shouldOmitHTMLDocumentSupportedPropertyNames):
+        * page/Quirks.h:
+        * platform/cocoa/VersionChecks.h:
+
 2021-02-24  Chris Dumez  <cdumez@apple.com>
 

trunk/Source/WebCore/html/HTMLDocument.cpp

@@ -75 +75 @@
 #include "HTMLIFrameElement.h"
 #include "HTMLNames.h"
+#include "Quirks.h"
 #include "ScriptController.h"
 #include "StyleResolver.h"
@@ -141 +142 @@
 Vector<AtomString> HTMLDocument::supportedPropertyNames() const
 {
+    if (Quirks::shouldOmitHTMLDocumentSupportedPropertyNames())
+        return { };
+
     auto properties = m_documentNamedItem.keys();
     // The specification says these should be sorted in document order but this would be expensive

trunk/Source/WebCore/page/Quirks.cpp

@@ -661 +661 @@
 }
 
+bool Quirks::shouldOmitHTMLDocumentSupportedPropertyNames()
+{
+#if PLATFORM(COCOA)
+    static bool shouldOmitHTMLDocumentSupportedPropertyNames = !linkedOnOrAfter(SDKVersion::FirstWithHTMLDocumentSupportedPropertyNames);
+    return shouldOmitHTMLDocumentSupportedPropertyNames;
+#else
+    return false;
+#endif
+}
+
 bool Quirks::shouldSilenceWindowResizeEvents() const
 {

trunk/Source/WebCore/page/Quirks.h

@@ -148 +148 @@
 #endif
 
+    static bool shouldOmitHTMLDocumentSupportedPropertyNames();
+
 private:
     bool needsQuirks() const;

trunk/Source/WebCore/platform/cocoa/VersionChecks.h

@@ -66 +66 @@
     FirstVersionWithiOSAppsOnMacOS = DYLD_IOS_VERSION_FIRST_WITH_IOS_APPS_ON_MACOS,
     FirstWithDataURLFragmentRemoval = DYLD_IOS_VERSION_14_5,
+    FirstWithHTMLDocumentSupportedPropertyNames = DYLD_IOS_VERSION_14_5,
     FirstThatObservesClassProperty = DYLD_IOS_VERSION_14_5,
     FirstWithNullOriginForNonSpecialSchemedURLs = DYLD_IOS_VERSION_15_0,
@@ -87 +88 @@
     FirstWithWKWebsiteDataStoreInitReturningNil = DYLD_MACOSX_VERSION_10_16,
     FirstWithDataURLFragmentRemoval = DYLD_MACOSX_VERSION_11_3,
+    FirstWithHTMLDocumentSupportedPropertyNames = DYLD_MACOSX_VERSION_11_3,
     FirstWithNullOriginForNonSpecialSchemedURLs = DYLD_MACOSX_VERSION_12_00,
 #endif